Re: [PATCH v2] block: fix iolat timestamp and restore accounting semantics

2018-12-13 Thread Jens Axboe
On 12/13/18 1:03 PM, Josef Bacik wrote: > On Thu, Dec 13, 2018 at 12:59:03PM -0700, Jens Axboe wrote: >> On 12/13/18 12:52 PM, Josef Bacik wrote: >>> On Thu, Dec 13, 2018 at 12:48:11PM -0700, Jens Axboe wrote: On 12/11/18 4:01 PM, Dennis Zhou wrote: > The blk-iolatency controller measures

Re: [PATCH v2] block: fix iolat timestamp and restore accounting semantics

2018-12-13 Thread Josef Bacik
On Thu, Dec 13, 2018 at 12:59:03PM -0700, Jens Axboe wrote: > On 12/13/18 12:52 PM, Josef Bacik wrote: > > On Thu, Dec 13, 2018 at 12:48:11PM -0700, Jens Axboe wrote: > >> On 12/11/18 4:01 PM, Dennis Zhou wrote: > >>> The blk-iolatency controller measures the time from > >>> rq_qos_throttle() to

Re: [PATCH v2] block: fix iolat timestamp and restore accounting semantics

2018-12-13 Thread Jens Axboe
On 12/13/18 12:52 PM, Josef Bacik wrote: > On Thu, Dec 13, 2018 at 12:48:11PM -0700, Jens Axboe wrote: >> On 12/11/18 4:01 PM, Dennis Zhou wrote: >>> The blk-iolatency controller measures the time from >>> rq_qos_throttle() to rq_qos_done_bio() and attributes this time to >>> the first bio that

Re: [PATCH v2] block: fix iolat timestamp and restore accounting semantics

2018-12-13 Thread Josef Bacik
On Thu, Dec 13, 2018 at 12:48:11PM -0700, Jens Axboe wrote: > On 12/11/18 4:01 PM, Dennis Zhou wrote: > > The blk-iolatency controller measures the time from rq_qos_throttle() to > > rq_qos_done_bio() and attributes this time to the first bio that needs > > to create the request. This means if a

Re: [PATCH v2] block: fix iolat timestamp and restore accounting semantics

2018-12-13 Thread Jens Axboe
On 12/11/18 4:01 PM, Dennis Zhou wrote: > The blk-iolatency controller measures the time from rq_qos_throttle() to > rq_qos_done_bio() and attributes this time to the first bio that needs > to create the request. This means if a bio is plug-mergeable or > bio-mergeable, it gets to bypass the