Re: [PATCH v2] block: ratelimite pr_err on IO path

On Mon, Apr 16, 2018 at 1:46 PM, Jinpu Wang wrote: > On Fri, Apr 13, 2018 at 6:59 PM, Martin K. Petersen > wrote: >> >> Jinpu, >> >> [CC:ed the mpt3sas maintainers] >> >> The ratelimit patch is just an attempt to treat the symptom, not the

Re: [PATCH v2] block: ratelimite pr_err on IO path

On Mon, Apr 16, 2018 at 1:46 PM, Jinpu Wang wrote: > On Fri, Apr 13, 2018 at 6:59 PM, Martin K. Petersen > wrote: >> >> Jinpu, >> >> [CC:ed the mpt3sas maintainers] >> >> The ratelimit patch is just an attempt to treat the symptom, not the >> cause. > Agree. If we can fix the root cause, it will

Re: [PATCH v2] block: ratelimite pr_err on IO path

On Fri, Apr 13, 2018 at 6:59 PM, Martin K. Petersen wrote: > > Jinpu, > > [CC:ed the mpt3sas maintainers] > > The ratelimit patch is just an attempt to treat the symptom, not the > cause. Agree. If we can fix the root cause, it will be great. > >> Thanks for asking, we

Re: [PATCH v2] block: ratelimite pr_err on IO path

On Fri, Apr 13, 2018 at 6:59 PM, Martin K. Petersen wrote: > > Jinpu, > > [CC:ed the mpt3sas maintainers] > > The ratelimit patch is just an attempt to treat the symptom, not the > cause. Agree. If we can fix the root cause, it will be great. > >> Thanks for asking, we updated mpt3sas driver

Re: [PATCH v2] block: ratelimite pr_err on IO path

Jinpu, [CC:ed the mpt3sas maintainers] The ratelimit patch is just an attempt to treat the symptom, not the cause. > Thanks for asking, we updated mpt3sas driver which enables DIX support > (prot_mask=0x7f), all disks are SATA SSDs, no DIF support. > After reboot, kernel reports the IO errors

Re: [PATCH v2] block: ratelimite pr_err on IO path

Jinpu, [CC:ed the mpt3sas maintainers] The ratelimit patch is just an attempt to treat the symptom, not the cause. > Thanks for asking, we updated mpt3sas driver which enables DIX support > (prot_mask=0x7f), all disks are SATA SSDs, no DIF support. > After reboot, kernel reports the IO errors

Re: [PATCH v2] block: ratelimite pr_err on IO path

On Thu, Apr 12, 2018 at 11:20 PM, Martin K. Petersen wrote: > > Jack, > >> + pr_err_ratelimited("%s: ref tag error at >> location %llu (rcvd %u)\n", > > I'm a bit concerned about dropping records of potential data loss. > > Also, what are

Re: [PATCH v2] block: ratelimite pr_err on IO path

On Thu, Apr 12, 2018 at 11:20 PM, Martin K. Petersen wrote: > > Jack, > >> + pr_err_ratelimited("%s: ref tag error at >> location %llu (rcvd %u)\n", > > I'm a bit concerned about dropping records of potential data loss. > > Also, what are you doing that compels all

Re: [PATCH v2] block: ratelimite pr_err on IO path

Jack, > + pr_err_ratelimited("%s: ref tag error at > location %llu (rcvd %u)\n", I'm a bit concerned about dropping records of potential data loss. Also, what are you doing that compels all these to be logged? This should be a very rare occurrence. -- Martin K.

Re: [PATCH v2] block: ratelimite pr_err on IO path

Jack, > + pr_err_ratelimited("%s: ref tag error at > location %llu (rcvd %u)\n", I'm a bit concerned about dropping records of potential data loss. Also, what are you doing that compels all these to be logged? This should be a very rare occurrence. -- Martin K.