Re: [PATCH v2] gpio: dwapb: Add support for a bus clock

2018-03-27 Thread Linus Walleij
On Mon, Mar 12, 2018 at 7:30 PM, Phil Edworthy wrote: > Enable an optional bus clock provided by DT. > > Signed-off-by: Phil Edworthy > --- > v2: > - Fix include order. > - Use a clock name. > - Check errors from clk_prepare_enable() > -

Re: [PATCH v2] gpio: dwapb: Add support for a bus clock

2018-03-27 Thread Linus Walleij
On Mon, Mar 12, 2018 at 7:30 PM, Phil Edworthy wrote: > Enable an optional bus clock provided by DT. > > Signed-off-by: Phil Edworthy > --- > v2: > - Fix include order. > - Use a clock name. > - Check errors from clk_prepare_enable() > - Add calls to enable/disable the clock in PM Patch

RE: [PATCH v2] gpio: dwapb: Add support for a bus clock

2018-03-13 Thread Phil Edworthy
Hi Andy, On 13 March 2018 16:36, Andy Shevchenko wrote: > On Mon, Mar 12, 2018 at 8:30 PM, Phil Edworthy > wrote: > > Enable an optional bus clock provided by DT. > > FWIW, > Reviewed-by: Andy Shevchenko Thanks! > (Assuming it has been

RE: [PATCH v2] gpio: dwapb: Add support for a bus clock

2018-03-13 Thread Phil Edworthy
Hi Andy, On 13 March 2018 16:36, Andy Shevchenko wrote: > On Mon, Mar 12, 2018 at 8:30 PM, Phil Edworthy > wrote: > > Enable an optional bus clock provided by DT. > > FWIW, > Reviewed-by: Andy Shevchenko Thanks! > (Assuming it has been tested on clock-less cases) I hacked together a test

Re: [PATCH v2] gpio: dwapb: Add support for a bus clock

2018-03-13 Thread Andy Shevchenko
On Mon, Mar 12, 2018 at 8:30 PM, Phil Edworthy wrote: > Enable an optional bus clock provided by DT. FWIW, Reviewed-by: Andy Shevchenko (Assuming it has been tested on clock-less cases) > Signed-off-by: Phil Edworthy

Re: [PATCH v2] gpio: dwapb: Add support for a bus clock

2018-03-13 Thread Andy Shevchenko
On Mon, Mar 12, 2018 at 8:30 PM, Phil Edworthy wrote: > Enable an optional bus clock provided by DT. FWIW, Reviewed-by: Andy Shevchenko (Assuming it has been tested on clock-less cases) > Signed-off-by: Phil Edworthy > --- > v2: > - Fix include order. > - Use a clock name. > - Check