Re: [PATCH v2] mm: move phys_mem_access_prot_allowed() declaration to pgtable.h

2016-09-16 Thread Ralf Baechle
On Tue, Sep 13, 2016 at 03:26:37PM +0800, Baoyou Xie wrote:

> We get 1 warning when building kernel with W=1:
> drivers/char/mem.c:220:12: warning: no previous prototype for 
> 'phys_mem_access_prot_allowed' [-Wmissing-prototypes]
>  int __weak phys_mem_access_prot_allowed(struct file *file,
> 
> In fact, its declaration is spreading to several header files
> in different architecture, but need to be declare in common
> header file.
> 
> So this patch moves phys_mem_access_prot_allowed() to pgtable.h.
> 
> Signed-off-by: Baoyou Xie 

Acked-by: Ralf Baechle 

  Ralf


Re: [PATCH v2] mm: move phys_mem_access_prot_allowed() declaration to pgtable.h

2016-09-13 Thread Thomas Gleixner
On Tue, 13 Sep 2016, Baoyou Xie wrote:

> We get 1 warning when building kernel with W=1:
> drivers/char/mem.c:220:12: warning: no previous prototype for 
> 'phys_mem_access_prot_allowed' [-Wmissing-prototypes]
>  int __weak phys_mem_access_prot_allowed(struct file *file,
> 
> In fact, its declaration is spreading to several header files
> in different architecture, but need to be declare in common
> header file.
> 
> So this patch moves phys_mem_access_prot_allowed() to pgtable.h.
> 
> Signed-off-by: Baoyou Xie 
> ---
>  arch/mips/include/asm/pgtable.h  | 2 --
>  arch/x86/include/asm/pgtable_types.h | 2 --
>  include/asm-generic/pgtable.h| 3 +++
>  3 files changed, 3 insertions(+), 4 deletions(-)

Acked-by: Thomas Gleixner