On Sat, Sep 17, 2016 at 10:15:45AM +0200, Rabin Vincent wrote:
> On Fri, Sep 16, 2016 at 04:26:56PM -0500, Josh Poimboeuf wrote:
> > + addr2line -ie $objfile $hexaddr
>
> Could you pass in -f and -p too to addr2line?
>
> Before:
>
> $ scripts/faddr2line ~/dev/kvm2/vmlinux free_reserved_area+0
On Fri, Sep 16, 2016 at 06:59:22PM -0700, Linus Torvalds wrote:
> On Fri, Sep 16, 2016 at 5:42 PM, Josh Poimboeuf wrote:
> > On Fri, Sep 16, 2016 at 05:09:15PM -0700, Linus Torvalds wrote:
> >> On Fri, Sep 16, 2016 at 2:26 PM, Josh Poimboeuf
> >> wrote:
> >> >
> >> > Ok, how about this. If this
On Fri, Sep 16, 2016 at 04:26:56PM -0500, Josh Poimboeuf wrote:
> + addr2line -ie $objfile $hexaddr
Could you pass in -f and -p too to addr2line?
Before:
$ scripts/faddr2line ~/dev/kvm2/vmlinux free_reserved_area+0x90
/home/rabin/dev/linux/include/linux/compiler.h:222
/home/rabin/dev/linu
On Fri, Sep 16, 2016 at 6:59 PM, Linus Torvalds
wrote:
>
> And finally, I suspect (5) is not reasonably fixable. Oh well. It
> would require some kind of "figure out the largest common prefix of
> all the filenames in the whole object file". So I'm *not* talking
> about just passing "--basenames"
On Fri, Sep 16, 2016 at 5:42 PM, Josh Poimboeuf wrote:
> On Fri, Sep 16, 2016 at 05:09:15PM -0700, Linus Torvalds wrote:
>> On Fri, Sep 16, 2016 at 2:26 PM, Josh Poimboeuf wrote:
>> >
>> > Ok, how about this. If this looks ok, would you be willing to apply it?
>>
>> Looks good to me. Did you tes
On Fri, Sep 16, 2016 at 04:26:56PM -0500, Josh Poimboeuf wrote:
> Ok, how about this. If this looks ok, would you be willing to apply it?
Looks good, and yes without --inline addr2line would be tons less useful
;-) Thanks for cooking this up.
On Fri, Sep 16, 2016 at 05:09:15PM -0700, Linus Torvalds wrote:
> On Fri, Sep 16, 2016 at 2:26 PM, Josh Poimboeuf wrote:
> >
> > Ok, how about this. If this looks ok, would you be willing to apply it?
>
> Looks good to me. Did you test the size verification with some made-up cases?
Yep. And I
On Fri, Sep 16, 2016 at 2:26 PM, Josh Poimboeuf wrote:
>
> Ok, how about this. If this looks ok, would you be willing to apply it?
Looks good to me. Did you test the size verification with some made-up cases?
Linus
8 matches
Mail list logo