Re: [PATCH v2] skd: fix assert typo

On Fri, Sep 16, 2016 at 08:40:54AM -0400, Jeff Moyer wrote: > Eric Engestrom writes: > > > The assert was missing a `!` to become active, but since that would only > > turn > > it into a complicated codepath for a pr_err(), let's simply replace it. > > The skd assert

Re: [PATCH v2] skd: fix assert typo

On Fri, Sep 16, 2016 at 08:40:54AM -0400, Jeff Moyer wrote: > Eric Engestrom writes: > > > The assert was missing a `!` to become active, but since that would only > > turn > > it into a complicated codepath for a pr_err(), let's simply replace it. > > The skd assert macro prints out file and

Re: [PATCH v2] skd: fix assert typo

Eric Engestrom writes: > The assert was missing a `!` to become active, but since that would only turn > it into a complicated codepath for a pr_err(), let's simply replace it. The skd assert macro prints out file and line number, which would have been nice to keep.

Re: [PATCH v2] skd: fix assert typo

Eric Engestrom writes: > The assert was missing a `!` to become active, but since that would only turn > it into a complicated codepath for a pr_err(), let's simply replace it. The skd assert macro prints out file and line number, which would have been nice to keep. Sorry I didn't explicitly

Re: [PATCH v2] skd: fix assert typo

On Fri, Sep 16, 2016 at 10:31:23AM +0100, Eric Engestrom wrote: > The assert was missing a `!` to become active, but since that would only turn > it into a complicated codepath for a pr_err(), let's simply replace it. > > CC: Jeff Moyer > Signed-off-by: Eric Engestrom

Re: [PATCH v2] skd: fix assert typo

On Fri, Sep 16, 2016 at 10:31:23AM +0100, Eric Engestrom wrote: > The assert was missing a `!` to become active, but since that would only turn > it into a complicated codepath for a pr_err(), let's simply replace it. > > CC: Jeff Moyer > Signed-off-by: Eric Engestrom > --- Looks ok,