Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-10-03 Thread Krzysztof Kozlowski
On wto, 2013-10-01 at 16:04 -0500, Seth Jennings wrote: > Yes, it is very similar. I'm beginning to like aspects of this patch > more as I explore this issue more. > > At first, I balked at the idea of yet another abstraction layer, but it > is very hard to avoid unless you want to completely

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-10-03 Thread Krzysztof Kozlowski
On wto, 2013-10-01 at 16:04 -0500, Seth Jennings wrote: Yes, it is very similar. I'm beginning to like aspects of this patch more as I explore this issue more. At first, I balked at the idea of yet another abstraction layer, but it is very hard to avoid unless you want to completely

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-10-01 Thread Seth Jennings
On Mon, Sep 30, 2013 at 10:28:46AM +0200, Krzysztof Kozlowski wrote: > On pią, 2013-09-27 at 17:00 -0500, Seth Jennings wrote: > > I have to say that when I first came up with the idea, I was thinking > > the address space would be at the zswap layer and the radix slots would > > hold zbud

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-10-01 Thread Seth Jennings
On Mon, Sep 30, 2013 at 10:28:46AM +0200, Krzysztof Kozlowski wrote: On pią, 2013-09-27 at 17:00 -0500, Seth Jennings wrote: I have to say that when I first came up with the idea, I was thinking the address space would be at the zswap layer and the radix slots would hold zbud handles, not

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-30 Thread Krzysztof Kozlowski
On pią, 2013-09-27 at 17:00 -0500, Seth Jennings wrote: > I have to say that when I first came up with the idea, I was thinking > the address space would be at the zswap layer and the radix slots would > hold zbud handles, not struct page pointers. > > However, as I have discovered today, this is

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-30 Thread Krzysztof Kozlowski
On pią, 2013-09-27 at 17:00 -0500, Seth Jennings wrote: I have to say that when I first came up with the idea, I was thinking the address space would be at the zswap layer and the radix slots would hold zbud handles, not struct page pointers. However, as I have discovered today, this is

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-27 Thread Bob Liu
On 09/28/2013 06:00 AM, Seth Jennings wrote: > On Fri, Sep 27, 2013 at 12:16:37PM +0200, Tomasz Stanislawski wrote: >> On 09/25/2013 11:57 PM, Seth Jennings wrote: >>> On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote: > I just had an idea this afternoon to potentially kill

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-27 Thread Seth Jennings
On Fri, Sep 27, 2013 at 12:16:37PM +0200, Tomasz Stanislawski wrote: > On 09/25/2013 11:57 PM, Seth Jennings wrote: > > On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote: > >>> I just had an idea this afternoon to potentially kill both these birds > >>> with one > >>> stone:

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-27 Thread Tomasz Stanislawski
On 09/25/2013 11:57 PM, Seth Jennings wrote: > On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote: >>> I just had an idea this afternoon to potentially kill both these birds with >>> one >>> stone: Replace the rbtree in zswap with an address_space. >>> >>> Each swap type would

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-27 Thread Tomasz Stanislawski
On 09/25/2013 11:57 PM, Seth Jennings wrote: On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote: I just had an idea this afternoon to potentially kill both these birds with one stone: Replace the rbtree in zswap with an address_space. Each swap type would have its own

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-27 Thread Seth Jennings
On Fri, Sep 27, 2013 at 12:16:37PM +0200, Tomasz Stanislawski wrote: On 09/25/2013 11:57 PM, Seth Jennings wrote: On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote: I just had an idea this afternoon to potentially kill both these birds with one stone: Replace the rbtree

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-27 Thread Bob Liu
On 09/28/2013 06:00 AM, Seth Jennings wrote: On Fri, Sep 27, 2013 at 12:16:37PM +0200, Tomasz Stanislawski wrote: On 09/25/2013 11:57 PM, Seth Jennings wrote: On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote: I just had an idea this afternoon to potentially kill both these

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-25 Thread Seth Jennings
On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote: > > I just had an idea this afternoon to potentially kill both these birds with > > one > > stone: Replace the rbtree in zswap with an address_space. > > > > Each swap type would have its own page_tree to organize the

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-25 Thread Tomasz Stanislawski
> I just had an idea this afternoon to potentially kill both these birds with > one > stone: Replace the rbtree in zswap with an address_space. > > Each swap type would have its own page_tree to organize the compressed objects > by type and offset (radix tree is more suited for this anyway) and

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-25 Thread Tomasz Stanislawski
I just had an idea this afternoon to potentially kill both these birds with one stone: Replace the rbtree in zswap with an address_space. Each swap type would have its own page_tree to organize the compressed objects by type and offset (radix tree is more suited for this anyway) and a_ops

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-25 Thread Seth Jennings
On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote: I just had an idea this afternoon to potentially kill both these birds with one stone: Replace the rbtree in zswap with an address_space. Each swap type would have its own page_tree to organize the compressed

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-24 Thread Bob Liu
On Tue, Sep 24, 2013 at 5:20 PM, Krzysztof Kozlowski wrote: > Hi, > > On pon, 2013-09-23 at 17:07 -0500, Seth Jennings wrote: >> On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: >> > Mel mentioned several problems about zswap/zbud in thread "[PATCH v6 >> > 0/5] zram/zsmalloc promotion".

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-24 Thread Krzysztof Kozlowski
Hi, On pon, 2013-09-23 at 17:07 -0500, Seth Jennings wrote: > On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: > > Mel mentioned several problems about zswap/zbud in thread "[PATCH v6 > > 0/5] zram/zsmalloc promotion". > > > > Like "it's clunky as hell and the layering between zswap and

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-24 Thread Krzysztof Kozlowski
Hi, On pon, 2013-09-23 at 17:07 -0500, Seth Jennings wrote: On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: Mel mentioned several problems about zswap/zbud in thread [PATCH v6 0/5] zram/zsmalloc promotion. Like it's clunky as hell and the layering between zswap and zbud is

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-24 Thread Bob Liu
On Tue, Sep 24, 2013 at 5:20 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Hi, On pon, 2013-09-23 at 17:07 -0500, Seth Jennings wrote: On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: Mel mentioned several problems about zswap/zbud in thread [PATCH v6 0/5] zram/zsmalloc

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-23 Thread Seth Jennings
On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: > Mel mentioned several problems about zswap/zbud in thread "[PATCH v6 > 0/5] zram/zsmalloc promotion". > > Like "it's clunky as hell and the layering between zswap and zbud is > twisty" and "I think I brought up its stalling behaviour

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-23 Thread Seth Jennings
On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: > Hi Krzysztof, > > On 09/11/2013 04:58 PM, Krzysztof Kozlowski wrote: > > Hi, > > > > Currently zbud pages are not movable and they cannot be allocated from CMA > > (Contiguous Memory Allocator) region. These patches add migration of zbud

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-23 Thread Seth Jennings
On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: Hi Krzysztof, On 09/11/2013 04:58 PM, Krzysztof Kozlowski wrote: Hi, Currently zbud pages are not movable and they cannot be allocated from CMA (Contiguous Memory Allocator) region. These patches add migration of zbud pages.

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-23 Thread Seth Jennings
On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote: Mel mentioned several problems about zswap/zbud in thread [PATCH v6 0/5] zram/zsmalloc promotion. Like it's clunky as hell and the layering between zswap and zbud is twisty and I think I brought up its stalling behaviour during review

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-17 Thread Bob Liu
Hi Krzysztof, On 09/11/2013 04:58 PM, Krzysztof Kozlowski wrote: > Hi, > > Currently zbud pages are not movable and they cannot be allocated from CMA > (Contiguous Memory Allocator) region. These patches add migration of zbud > pages. > I agree that the migration of zbud pages is important so

Re: [PATCH v2 0/5] mm: migrate zbud pages

2013-09-17 Thread Bob Liu
Hi Krzysztof, On 09/11/2013 04:58 PM, Krzysztof Kozlowski wrote: Hi, Currently zbud pages are not movable and they cannot be allocated from CMA (Contiguous Memory Allocator) region. These patches add migration of zbud pages. I agree that the migration of zbud pages is important so that