Re: [PATCH v2 00/49] *** SUBJECT HERE ***
On Wed, Apr 07, 2021 at 10:32:53AM +0200, Greg KH wrote: > On Wed, Apr 07, 2021 at 09:32:29AM +0200, Greg KH wrote: > > On Wed, Apr 07, 2021 at 12:15:22AM -0700, Pavle Rohalj wrote: > > > On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote: > > > > On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > > > > > Changes in v2: > > > > > - Removed type information from variable names > > > > > - Broken up the changes into smaller patches > > > > > > > > Your subject is very odd :( > > > > > > Sorry about that, I overlooked the fact that I reran format-patch. The > > > subject should be: > > > > > > [PATCH] staging: sm750fb: Convert camel case to snake case > > > > > > Should I resubmit? > > > > Not yet, let me review these first, I think they might need some work... > > > > Ok, now you can fix them up, I stopped after reviewing patch 02/49, > these need some work. > > thanks, > > greg k-h Will do. Thank you. -Pavle
Re: [PATCH v2 00/49] *** SUBJECT HERE ***
On Wed, Apr 07, 2021 at 09:11:18AM +0200, Fabio Aiuto wrote: > On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > > Changes in v2: > > - Removed type information from variable names > > - Broken up the changes into smaller patches > > Hi Pavle, > > I think you missed the subject in cover letter, but maybe > is not a relevant issue... (Resending this because I realized I did not reply to everyone) Hi Fabio, I did, my bad. This patchset is an attempt to fix checkpatch.pl checks for camel case usage in sm750fb driver. -Pavle
Re: [PATCH v2 00/49] *** SUBJECT HERE ***
On Wed, Apr 07, 2021 at 09:32:29AM +0200, Greg KH wrote: > On Wed, Apr 07, 2021 at 12:15:22AM -0700, Pavle Rohalj wrote: > > On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote: > > > On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > > > > Changes in v2: > > > > - Removed type information from variable names > > > > - Broken up the changes into smaller patches > > > > > > Your subject is very odd :( > > > > Sorry about that, I overlooked the fact that I reran format-patch. The > > subject should be: > > > > [PATCH] staging: sm750fb: Convert camel case to snake case > > > > Should I resubmit? > > Not yet, let me review these first, I think they might need some work... > Ok, now you can fix them up, I stopped after reviewing patch 02/49, these need some work. thanks, greg k-h
Re: [PATCH v2 00/49] *** SUBJECT HERE ***
On Wed, Apr 07, 2021 at 12:15:22AM -0700, Pavle Rohalj wrote: > On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote: > > On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > > > Changes in v2: > > > - Removed type information from variable names > > > - Broken up the changes into smaller patches > > > > Your subject is very odd :( > > Sorry about that, I overlooked the fact that I reran format-patch. The > subject should be: > > [PATCH] staging: sm750fb: Convert camel case to snake case > > Should I resubmit? Not yet, let me review these first, I think they might need some work...
Re: [PATCH v2 00/49] *** SUBJECT HERE ***
On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote: > On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > > Changes in v2: > > - Removed type information from variable names > > - Broken up the changes into smaller patches > > Your subject is very odd :( Sorry about that, I overlooked the fact that I reran format-patch. The subject should be: [PATCH] staging: sm750fb: Convert camel case to snake case Should I resubmit? -Pavle
Re: [PATCH v2 00/49] *** SUBJECT HERE ***
On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > Changes in v2: > - Removed type information from variable names > - Broken up the changes into smaller patches Hi Pavle, I think you missed the subject in cover letter, but maybe is not a relevant issue...
Re: [PATCH v2 00/49] *** SUBJECT HERE ***
On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > Changes in v2: > - Removed type information from variable names > - Broken up the changes into smaller patches Your subject is very odd :(
