Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros

2016-10-24 Thread Luc, Piotr
On Fri, 2016-10-14 at 13:56 +0200, Thomas Gleixner wrote: > On Thu, 13 Oct 2016, Piotr Luc wrote: > > > > + case INTEL_FAM6_SANDYBRIDGE:/* SNB */ > > Especialy those, which are completely useless? > > The defines are there to be self explaining and the extra verbose > information

Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros

2016-10-24 Thread Luc, Piotr
On Fri, 2016-10-14 at 13:56 +0200, Thomas Gleixner wrote: > On Thu, 13 Oct 2016, Piotr Luc wrote: > > > > + case INTEL_FAM6_SANDYBRIDGE:/* SNB */ > > Especialy those, which are completely useless? > > The defines are there to be self explaining and the extra verbose > information

Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros

2016-10-14 Thread Thomas Gleixner
On Thu, 13 Oct 2016, Piotr Luc wrote: > + case INTEL_FAM6_NEHALEM_EP: /* Core i7, Xeon 5500 series - > Bloomfield, Gainstown NHM-EP */ What's the point of keeping all those comments around? > + case INTEL_FAM6_SANDYBRIDGE:/* SNB */ Especialy those, which are

Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros

2016-10-14 Thread Thomas Gleixner
On Thu, 13 Oct 2016, Piotr Luc wrote: > + case INTEL_FAM6_NEHALEM_EP: /* Core i7, Xeon 5500 series - > Bloomfield, Gainstown NHM-EP */ What's the point of keeping all those comments around? > + case INTEL_FAM6_SANDYBRIDGE:/* SNB */ Especialy those, which are