Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Thu, Dec 07, 2017 at 12:17:32AM +0200, Marcus Wolf wrote: > To be honest, I am a little bit astonished about that question. Don't you do > a regression test after such a redesign? I would be a little bit afraid to > offer such redesign without testing. He probably doesn't have the hardware...

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Thu, Dec 07, 2017 at 12:17:32AM +0200, Marcus Wolf wrote: > To be honest, I am a little bit astonished about that question. Don't you do > a regression test after such a redesign? I would be a little bit afraid to > offer such redesign without testing. He probably doesn't have the hardware...

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 21:57 schrieb Simon Sandström: On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: Am 06.12.2017 um 12:23 schrieb Dan Carpenter: Wow... This was the one patch I thought was going to sink this

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 21:57 schrieb Simon Sandström: On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: Am 06.12.2017 um 12:23 schrieb Dan Carpenter: Wow... This was the one patch I thought was going to sink this

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: > On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: > > > > > > Am 06.12.2017 um 12:23 schrieb Dan Carpenter: > > > > > > > > > Wow... This was the one patch I thought was going to sink this > > > patchset... > > > > I

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: > On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: > > > > > > Am 06.12.2017 um 12:23 schrieb Dan Carpenter: > > > > > > > > > Wow... This was the one patch I thought was going to sink this > > > patchset... > > > > I

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Sorry, for sending HTML as well - I am writing from my phone... Yes, you will break something, when renaming. Since order isn't changed, most probably old programs will still compile with old enum.h. If we want to move from optionOnOff to bool, we will also break old progs. Since driver is

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Sorry, for sending HTML as well - I am writing from my phone... Yes, you will break something, when renaming. Since order isn't changed, most probably old programs will still compile with old enum.h. If we want to move from optionOnOff to bool, we will also break old progs. Since driver is

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: > > > Am 06.12.2017 um 12:23 schrieb Dan Carpenter: > > On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: > > > > diff --git a/drivers/staging/pi433/rf69_enum.h > > > > b/drivers/staging/pi433/rf69_enum.h > > > > index

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: > > > Am 06.12.2017 um 12:23 schrieb Dan Carpenter: > > On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: > > > > diff --git a/drivers/staging/pi433/rf69_enum.h > > > > b/drivers/staging/pi433/rf69_enum.h > > > > index

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 12:23 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h index babe597e2ec6..5247e9269de9 100644 --- a/drivers/staging/pi433/rf69_enum.h +++

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 12:23 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h index babe597e2ec6..5247e9269de9 100644 --- a/drivers/staging/pi433/rf69_enum.h +++

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: > > diff --git a/drivers/staging/pi433/rf69_enum.h > > b/drivers/staging/pi433/rf69_enum.h > > index babe597e2ec6..5247e9269de9 100644 > > --- a/drivers/staging/pi433/rf69_enum.h > > +++ b/drivers/staging/pi433/rf69_enum.h > > @@ -18,9

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: > > diff --git a/drivers/staging/pi433/rf69_enum.h > > b/drivers/staging/pi433/rf69_enum.h > > index babe597e2ec6..5247e9269de9 100644 > > --- a/drivers/staging/pi433/rf69_enum.h > > +++ b/drivers/staging/pi433/rf69_enum.h > > @@ -18,9

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström ---

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34