Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes
On Mon, Feb 12, 2018 at 10:35:50AM +0100, Philippe Ombredanne wrote: > Jerry, > > On Mon, Feb 12, 2018 at 6:21 AM, Jerry Hoemannwrote: > > Minor white space changes and some name clean up. > > > > Signed-off-by: Jerry Hoemann > > --- > > drivers/watchdog/hpwdt.c | 49 > > +++- > > 1 file changed, 23 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > > index 6f7949ef9a23..ee9a92220ece 100644 > > --- a/drivers/watchdog/hpwdt.c > > +++ b/drivers/watchdog/hpwdt.c > > @@ -1,11 +1,9 @@ > > /* > > * HPE WatchDog Driver > > - * based on > > * > > - * SoftDog 0.05: A Software Watchdog Device > > - * > > - * (c) Copyright 2015 Hewlett Packard Enterprise Development LP > > + * (c) Copyright 2018 Hewlett Packard Enterprise Development LP > > * Thomas Mingarelli > > + * Jerry Hoemann > > * > > * This program is free software; you can redistribute it and/or > > * modify it under the terms of the GNU General Public License > > Since you are updating the copyright, why not updating the licensing > to use the new concise SPDX ids instead? [1] > And you get a big good karma bonus if you can also do the same for all > HPE-copyrighted files, tree-wide ;) and/or spread the word inside your > team. > Different logical change, separate patch, please. Which, on a side note, you might consider submitting yourself. Thanks, Guenter
Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes
On Mon, Feb 12, 2018 at 10:35:50AM +0100, Philippe Ombredanne wrote: > Jerry, > > On Mon, Feb 12, 2018 at 6:21 AM, Jerry Hoemann wrote: > > Minor white space changes and some name clean up. > > > > Signed-off-by: Jerry Hoemann > > --- > > drivers/watchdog/hpwdt.c | 49 > > +++- > > 1 file changed, 23 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > > index 6f7949ef9a23..ee9a92220ece 100644 > > --- a/drivers/watchdog/hpwdt.c > > +++ b/drivers/watchdog/hpwdt.c > > @@ -1,11 +1,9 @@ > > /* > > * HPE WatchDog Driver > > - * based on > > * > > - * SoftDog 0.05: A Software Watchdog Device > > - * > > - * (c) Copyright 2015 Hewlett Packard Enterprise Development LP > > + * (c) Copyright 2018 Hewlett Packard Enterprise Development LP > > * Thomas Mingarelli > > + * Jerry Hoemann > > * > > * This program is free software; you can redistribute it and/or > > * modify it under the terms of the GNU General Public License > > Since you are updating the copyright, why not updating the licensing > to use the new concise SPDX ids instead? [1] > And you get a big good karma bonus if you can also do the same for all > HPE-copyrighted files, tree-wide ;) and/or spread the word inside your > team. > Different logical change, separate patch, please. Which, on a side note, you might consider submitting yourself. Thanks, Guenter
Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes
Jerry, On Mon, Feb 12, 2018 at 6:21 AM, Jerry Hoemannwrote: > Minor white space changes and some name clean up. > > Signed-off-by: Jerry Hoemann > --- > drivers/watchdog/hpwdt.c | 49 > +++- > 1 file changed, 23 insertions(+), 26 deletions(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index 6f7949ef9a23..ee9a92220ece 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -1,11 +1,9 @@ > /* > * HPE WatchDog Driver > - * based on > * > - * SoftDog 0.05: A Software Watchdog Device > - * > - * (c) Copyright 2015 Hewlett Packard Enterprise Development LP > + * (c) Copyright 2018 Hewlett Packard Enterprise Development LP > * Thomas Mingarelli > + * Jerry Hoemann > * > * This program is free software; you can redistribute it and/or > * modify it under the terms of the GNU General Public License Since you are updating the copyright, why not updating the licensing to use the new concise SPDX ids instead? [1] And you get a big good karma bonus if you can also do the same for all HPE-copyrighted files, tree-wide ;) and/or spread the word inside your team. Thank you for your kind consideration! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst Cordially Philippe Ombredanne
Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes
Jerry, On Mon, Feb 12, 2018 at 6:21 AM, Jerry Hoemann wrote: > Minor white space changes and some name clean up. > > Signed-off-by: Jerry Hoemann > --- > drivers/watchdog/hpwdt.c | 49 > +++- > 1 file changed, 23 insertions(+), 26 deletions(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index 6f7949ef9a23..ee9a92220ece 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -1,11 +1,9 @@ > /* > * HPE WatchDog Driver > - * based on > * > - * SoftDog 0.05: A Software Watchdog Device > - * > - * (c) Copyright 2015 Hewlett Packard Enterprise Development LP > + * (c) Copyright 2018 Hewlett Packard Enterprise Development LP > * Thomas Mingarelli > + * Jerry Hoemann > * > * This program is free software; you can redistribute it and/or > * modify it under the terms of the GNU General Public License Since you are updating the copyright, why not updating the licensing to use the new concise SPDX ids instead? [1] And you get a big good karma bonus if you can also do the same for all HPE-copyrighted files, tree-wide ;) and/or spread the word inside your team. Thank you for your kind consideration! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst Cordially Philippe Ombredanne