Re: [PATCH v2 06/11] watchdog/hpwdt: Modify to use watchdog core.

2018-02-14 Thread Jerry Hoemann
On Mon, Feb 12, 2018 at 10:06:21AM +0100, Marcus Folkesson wrote: > Hi Jerry, > > On Sun, Feb 11, 2018 at 10:21:06PM -0700, Jerry Hoemann wrote: > > Follow Documentation/watchdog/convert_drivers_to_kernel_api.txt to > > convert hpwdt from legacy watchdog driver to use the watchdog core. > > > >

Re: [PATCH v2 06/11] watchdog/hpwdt: Modify to use watchdog core.

2018-02-13 Thread Jerry Hoemann
On Tue, Feb 13, 2018 at 01:55:49PM -0800, Guenter Roeck wrote: > On Tue, Feb 13, 2018 at 02:36:48PM -0700, Jerry Hoemann wrote: > > > > > > > > > > dev_dbg() > > > > I think you are proposing I do: > > > > dev_dbg(dev->parent, "settimeout = %d\n", val); > > > > This raises the issue that

Re: [PATCH v2 06/11] watchdog/hpwdt: Modify to use watchdog core.

2018-02-13 Thread Guenter Roeck
On Tue, Feb 13, 2018 at 02:36:48PM -0700, Jerry Hoemann wrote: > > > Thanks for the review. Comments inline. > > On Mon, Feb 12, 2018 at 10:06:21AM +0100, Marcus Folkesson wrote: > > Hi Jerry, > > > > On Sun, Feb 11, 2018 at 10:21:06PM -0700, Jerry Hoemann wrote: > > > Follow

Re: [PATCH v2 06/11] watchdog/hpwdt: Modify to use watchdog core.

2018-02-13 Thread Jerry Hoemann
Thanks for the review. Comments inline. On Mon, Feb 12, 2018 at 10:06:21AM +0100, Marcus Folkesson wrote: > Hi Jerry, > > On Sun, Feb 11, 2018 at 10:21:06PM -0700, Jerry Hoemann wrote: > > Follow Documentation/watchdog/convert_drivers_to_kernel_api.txt to > > convert hpwdt from legacy watchdog

Re: [PATCH v2 06/11] watchdog/hpwdt: Modify to use watchdog core.

2018-02-13 Thread Guenter Roeck
On Mon, Feb 12, 2018 at 10:06:21AM +0100, Marcus Folkesson wrote: > Hi Jerry, > > On Sun, Feb 11, 2018 at 10:21:06PM -0700, Jerry Hoemann wrote: > > Follow Documentation/watchdog/convert_drivers_to_kernel_api.txt to > > convert hpwdt from legacy watchdog driver to use the watchdog core. > > > >

Re: [PATCH v2 06/11] watchdog/hpwdt: Modify to use watchdog core.

2018-02-12 Thread Marcus Folkesson
Hi Jerry, On Sun, Feb 11, 2018 at 10:21:06PM -0700, Jerry Hoemann wrote: > Follow Documentation/watchdog/convert_drivers_to_kernel_api.txt to > convert hpwdt from legacy watchdog driver to use the watchdog core. > > Removed functions: hpwdt_open, hpwdt_release, hpwdt_write, hpwdt_ioctl > Removed