Re: [PATCH v2 06/13] PCI/portdrv: Remove pcie_port_bus_type link order dependency

2018-03-12 Thread Bjorn Helgaas
On Mon, Mar 12, 2018 at 01:01:47AM -0700, Christoph Hellwig wrote:
> > +   if ((driver->port_type != PCIE_ANY_PORT) &&
> > +   (driver->port_type != pci_pcie_type(pciedev->port)))
> 
> No need for the inner braces here.

Thanks, I removed them.


Re: [PATCH v2 06/13] PCI/portdrv: Remove pcie_port_bus_type link order dependency

2018-03-12 Thread Christoph Hellwig
> + if ((driver->port_type != PCIE_ANY_PORT) &&
> + (driver->port_type != pci_pcie_type(pciedev->port)))

No need for the inner braces here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig