Re: [PATCH v2 08/16] mmc: sdhci-omap: Add support to override f_max and iodelay from pdata
Hi, On Wednesday 14 February 2018 10:54 PM, Tony Lindgren wrote: > * Ulf Hansson [180214 09:53]: >> On 5 February 2018 at 13:50, Kishon Vijay Abraham I wrote: >>> DRA74x EVM Rev H EVM comes with revision 2.0 silicon. However, earlier >>> versions of EVM can come with either revision 1.1 or revision 1.0 of >>> silicon. >>> >>> The device-tree file is written to support rev 2.0 of silicon. >>> pdata-quirks are used to then override the settings needed for >>> PG 1.1 silicon. >>> >>> PG 1.1 silicon has limitations w.r.t frequencies at which MMC1/2/3 >>> can operate as well as different IOdelay numbers. >> >> I fail to understand the need for platform data. Why can't DT be used >> for the older revisions as well? It was decided to have dt file for a single soc revision. So the default dts corresponds to rev 2.0. > > Maybe the silicon revision is not available via soc_device_match()? hmm.. looks like we can get rid of pdata if we use soc_device_match. Thanks for the hint. Regards Kishon
Re: [PATCH v2 08/16] mmc: sdhci-omap: Add support to override f_max and iodelay from pdata
* Ulf Hansson [180214 09:53]: > On 5 February 2018 at 13:50, Kishon Vijay Abraham I wrote: > > DRA74x EVM Rev H EVM comes with revision 2.0 silicon. However, earlier > > versions of EVM can come with either revision 1.1 or revision 1.0 of > > silicon. > > > > The device-tree file is written to support rev 2.0 of silicon. > > pdata-quirks are used to then override the settings needed for > > PG 1.1 silicon. > > > > PG 1.1 silicon has limitations w.r.t frequencies at which MMC1/2/3 > > can operate as well as different IOdelay numbers. > > I fail to understand the need for platform data. Why can't DT be used > for the older revisions as well? Maybe the silicon revision is not available via soc_device_match()? Regards, Tony
Re: [PATCH v2 08/16] mmc: sdhci-omap: Add support to override f_max and iodelay from pdata
On 5 February 2018 at 13:50, Kishon Vijay Abraham I wrote: > DRA74x EVM Rev H EVM comes with revision 2.0 silicon. However, earlier > versions of EVM can come with either revision 1.1 or revision 1.0 of > silicon. > > The device-tree file is written to support rev 2.0 of silicon. > pdata-quirks are used to then override the settings needed for > PG 1.1 silicon. > > PG 1.1 silicon has limitations w.r.t frequencies at which MMC1/2/3 > can operate as well as different IOdelay numbers. I fail to understand the need for platform data. Why can't DT be used for the older revisions as well? > > Add support in sdhci-omap driver to get platform data if available > (added using pdata quirks) and override the data (max-frequency and > iodelay data) obtained from device tree. [...] Kind regards Uffe
