Re: [PATCH v2 09/13] locking/qspinlock: Merge struct __qspinlock into struct qspinlock

[Waiman Long]

On 04/11/2018 02:01 PM, Will Deacon wrote:
> struct __qspinlock provides a handy union of fields so that
> subcomponents of the lockword can be accessed by name, without having to
> manage shifts and masks explicitly and take endianness into account.
>
> This is useful in qspinlock.h and also potentially in arch headers, so
> move the struct __qspinlock into struct qspinlock and kill the extra
> definition.
>
> Cc: Peter Zijlstra 
> Cc: Ingo Molnar 
> Acked-by: Boqun Feng 
> Signed-off-by: Will Deacon 

I think you are using the new qspinlock structure in some of your
earlier patches like patch 4. So you may want to move that earlier in
the series to avoid bisection problem.

Cheers,
Longman

Re: [PATCH v2 09/13] locking/qspinlock: Merge struct __qspinlock into struct qspinlock

[Waiman Long]

On 04/11/2018 02:01 PM, Will Deacon wrote:
> struct __qspinlock provides a handy union of fields so that
> subcomponents of the lockword can be accessed by name, without having to
> manage shifts and masks explicitly and take endianness into account.
>
> This is useful in qspinlock.h and also potentially in arch headers, so
> move the struct __qspinlock into struct qspinlock and kill the extra
> definition.
>
> Cc: Peter Zijlstra 
> Cc: Ingo Molnar 
> Acked-by: Boqun Feng 
> Signed-off-by: Will Deacon 

I think you are using the new qspinlock structure in some of your
earlier patches like patch 4. So you may want to move that earlier in
the series to avoid bisection problem.

Cheers,
Longman