Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-04 Thread Benson Leung
Hi Corentin, Thanks for your feedback on this. Indeed, what Olof is saying is correct. In its current form, this driver exists to register i2c devices on our laptops. We have one piece of information (the irq, specifically) that cannot be added to the i2c_board_info when using user space probing.

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-04 Thread Benson Leung
Hi Corentin, Thanks for your feedback on this. Indeed, what Olof is saying is correct. In its current form, this driver exists to register i2c devices on our laptops. We have one piece of information (the irq, specifically) that cannot be added to the i2c_board_info when using user space probing.

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-02 Thread Corentin Chary
On Fri, Nov 2, 2012 at 1:09 PM, Olof Johansson wrote: > On Fri, Nov 2, 2012 at 2:03 PM, Corentin Chary > wrote: >> On Fri, Nov 2, 2012 at 12:45 PM, Olof Johansson wrote: >>> On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary >>> wrote: >>> Looks better, but I'm curious, what is the final

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-02 Thread Olof Johansson
On Fri, Nov 2, 2012 at 2:03 PM, Corentin Chary wrote: > On Fri, Nov 2, 2012 at 12:45 PM, Olof Johansson wrote: >> On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary >> wrote: >> >>> Looks better, but I'm curious, what is the final purpose of this driver ? >>> What ABI will be exposed, who will

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-02 Thread Corentin Chary
On Fri, Nov 2, 2012 at 12:45 PM, Olof Johansson wrote: > On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary > wrote: > >> Looks better, but I'm curious, what is the final purpose of this driver ? >> What ABI will be exposed, who will use it ? >> >> If it is going to be bigger, it may be a good

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-02 Thread Olof Johansson
On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary wrote: > Looks better, but I'm curious, what is the final purpose of this driver ? > What ABI will be exposed, who will use it ? > > If it is going to be bigger, it may be a good idea to convert it to a > real platform driver

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-02 Thread Olof Johansson
On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary corentin.ch...@gmail.com wrote: Looks better, but I'm curious, what is the final purpose of this driver ? What ABI will be exposed, who will use it ? If it is going to be bigger, it may be a good idea to convert it to a real platform driver

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-02 Thread Corentin Chary
On Fri, Nov 2, 2012 at 12:45 PM, Olof Johansson o...@lixom.net wrote: On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary corentin.ch...@gmail.com wrote: Looks better, but I'm curious, what is the final purpose of this driver ? What ABI will be exposed, who will use it ? If it is going to be

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-02 Thread Olof Johansson
On Fri, Nov 2, 2012 at 2:03 PM, Corentin Chary corentin.ch...@gmail.com wrote: On Fri, Nov 2, 2012 at 12:45 PM, Olof Johansson o...@lixom.net wrote: On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary corentin.ch...@gmail.com wrote: Looks better, but I'm curious, what is the final purpose of

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-02 Thread Corentin Chary
On Fri, Nov 2, 2012 at 1:09 PM, Olof Johansson o...@lixom.net wrote: On Fri, Nov 2, 2012 at 2:03 PM, Corentin Chary corentin.ch...@gmail.com wrote: On Fri, Nov 2, 2012 at 12:45 PM, Olof Johansson o...@lixom.net wrote: On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary corentin.ch...@gmail.com

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-10-26 Thread Corentin Chary
On Thu, Oct 25, 2012 at 10:21 PM, Benson Leung wrote: > This adds the chromeos_laptop driver. It supports > the Cypress APA SMBUS touchpad as well as the isl29018 i2c ambient > light sensor on the Samsung Series 5 550 Chromebook. > > Signed-off-by: Benson Leung > Reviewed-by: Olof Johansson >

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-10-26 Thread Corentin Chary
On Thu, Oct 25, 2012 at 10:21 PM, Benson Leung ble...@chromium.org wrote: This adds the chromeos_laptop driver. It supports the Cypress APA SMBUS touchpad as well as the isl29018 i2c ambient light sensor on the Samsung Series 5 550 Chromebook. Signed-off-by: Benson Leung ble...@chromium.org