Re: [PATCH v2 1/1] mm: initialize pages on demand during boot

2018-02-09 Thread kbuild test robot
Hi Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mmotm/master] [also build test WARNING on next-20180209] [cannot apply to v4.15] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://githu

Re: [PATCH v2 1/1] mm: initialize pages on demand during boot

2018-02-09 Thread kbuild test robot
Hi Pavel, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on next-20180209] [cannot apply to v4.15] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0d

Re: [PATCH v2 1/1] mm: initialize pages on demand during boot

2018-02-08 Thread Pavel Tatashin
>> >> It would be nice to have a little comment explaining why READ_ONCE was >> needed. >> >> Would it still be needed if this code was moved into the locked region? > > > No, we would need to use READ_ONCE() if we grabbed deferred_zone_grow_lock > before this code. In fact I do not even think we s

Re: [PATCH v2 1/1] mm: initialize pages on demand during boot

2018-02-08 Thread Pavel Tatashin
Hi Andrew, Thank you for your comments. My replies below: + +/* + * Protects some early interrupt threads, and also for a short period of time + * from smp_init() to page_alloc_init_late() when deferred pages are + * initialized. + */ +static __initdata DEFINE_SPINLOCK(deferred_zone_grow_lock)

Re: [PATCH v2 1/1] mm: initialize pages on demand during boot

2018-02-08 Thread Andrew Morton
On Thu, 8 Feb 2018 13:45:55 -0500 Pavel Tatashin wrote: > Deferred page initialization allows the boot cpu to initialize a small > subset of the system's pages early in boot, with other cpus doing the rest > later on. > > It is, however, problematic to know how many pages the kernel needs duri