Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-18 Thread Dmitry Osipenko
On 19.02.2018 05:04, Dmitry Osipenko wrote: > On 13.02.2018 13:30, Thierry Reding wrote: >> On Mon, Feb 12, 2018 at 08:06:30PM +0300, Dmitry Osipenko wrote: >>> Tegra30+ has some minor differences in registers / bits layout compared >>> to Tegra20. Let's squash Tegra20 driver into the common

Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-18 Thread Dmitry Osipenko
On 19.02.2018 05:04, Dmitry Osipenko wrote: > On 13.02.2018 13:30, Thierry Reding wrote: >> On Mon, Feb 12, 2018 at 08:06:30PM +0300, Dmitry Osipenko wrote: >>> Tegra30+ has some minor differences in registers / bits layout compared >>> to Tegra20. Let's squash Tegra20 driver into the common

Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-18 Thread Dmitry Osipenko
On 13.02.2018 13:30, Thierry Reding wrote: > On Mon, Feb 12, 2018 at 08:06:30PM +0300, Dmitry Osipenko wrote: >> Tegra30+ has some minor differences in registers / bits layout compared >> to Tegra20. Let's squash Tegra20 driver into the common tegra-mc driver >> to reduce code a tad, this also

Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-18 Thread Dmitry Osipenko
On 13.02.2018 13:30, Thierry Reding wrote: > On Mon, Feb 12, 2018 at 08:06:30PM +0300, Dmitry Osipenko wrote: >> Tegra30+ has some minor differences in registers / bits layout compared >> to Tegra20. Let's squash Tegra20 driver into the common tegra-mc driver >> to reduce code a tad, this also

Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-14 Thread Dmitry Osipenko
On 14.02.2018 14:15, Peter De Schrijver wrote: > On Tue, Feb 13, 2018 at 11:30:39AM +0100, Thierry Reding wrote: >>> } >> >> It's odd that we don't have an MC clock on Tegra2. I wonder if perhaps >> we just never implemented one, or it uses one which is always on by >> default. Cc Peter to see

Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-14 Thread Dmitry Osipenko
On 14.02.2018 14:15, Peter De Schrijver wrote: > On Tue, Feb 13, 2018 at 11:30:39AM +0100, Thierry Reding wrote: >>> } >> >> It's odd that we don't have an MC clock on Tegra2. I wonder if perhaps >> we just never implemented one, or it uses one which is always on by >> default. Cc Peter to see

Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-14 Thread Peter De Schrijver
On Tue, Feb 13, 2018 at 11:30:39AM +0100, Thierry Reding wrote: > > } > > It's odd that we don't have an MC clock on Tegra2. I wonder if perhaps > we just never implemented one, or it uses one which is always on by > default. Cc Peter to see if he knows. We do, it has DT ID TEGRA20_CLK_MC.

Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-14 Thread Peter De Schrijver
On Tue, Feb 13, 2018 at 11:30:39AM +0100, Thierry Reding wrote: > > } > > It's odd that we don't have an MC clock on Tegra2. I wonder if perhaps > we just never implemented one, or it uses one which is always on by > default. Cc Peter to see if he knows. We do, it has DT ID TEGRA20_CLK_MC.

Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-13 Thread Thierry Reding
On Mon, Feb 12, 2018 at 08:06:30PM +0300, Dmitry Osipenko wrote: > Tegra30+ has some minor differences in registers / bits layout compared > to Tegra20. Let's squash Tegra20 driver into the common tegra-mc driver > to reduce code a tad, this also will be useful for the upcoming Tegra's MC > reset

Re: [PATCH v2 1/2] memory: tegra: Squash tegra20-mc into common tegra-mc driver

2018-02-13 Thread Thierry Reding
On Mon, Feb 12, 2018 at 08:06:30PM +0300, Dmitry Osipenko wrote: > Tegra30+ has some minor differences in registers / bits layout compared > to Tegra20. Let's squash Tegra20 driver into the common tegra-mc driver > to reduce code a tad, this also will be useful for the upcoming Tegra's MC > reset