Re: [PATCH v2 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-27 Thread Neil Armstrong
On 07/27/2017 04:43 PM, Neil Armstrong wrote: > On 07/25/2017 03:45 PM, Hans Verkuil wrote: >> On 07/25/17 14:34, Neil Armstrong wrote: >>> Hi Hans, >> > +static int meson_ao_cec_probe(struct platform_device *pdev) > +{ > + struct meson_ao_cec_device *ao_cec; > + struct platform_dev

Re: [PATCH v2 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-27 Thread Neil Armstrong
On 07/25/2017 03:45 PM, Hans Verkuil wrote: > On 07/25/17 14:34, Neil Armstrong wrote: >> Hi Hans, > +static int meson_ao_cec_probe(struct platform_device *pdev) +{ + struct meson_ao_cec_device *ao_cec; + struct platform_device *hdmi_dev; + struct device_node *np;

Re: [PATCH v2 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-25 Thread Hans Verkuil
On 07/25/17 14:34, Neil Armstrong wrote: > Hi Hans, >>> +static int meson_ao_cec_probe(struct platform_device *pdev) >>> +{ >>> + struct meson_ao_cec_device *ao_cec; >>> + struct platform_device *hdmi_dev; >>> + struct device_node *np; >>> + struct resource *res; >>> + int ret, irq; >>>

Re: [PATCH v2 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-25 Thread Neil Armstrong
Hi Hans, On 07/17/2017 10:01 AM, Hans Verkuil wrote: > On 10/07/17 10:01, Neil Armstrong wrote: >> The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver >> for such controller. >> The controller does not need HPD to be active, and could support up to max >> 5 logical address

Re: [PATCH v2 1/2] platform: Add Amlogic Meson AO CEC Controller driver

2017-07-17 Thread Hans Verkuil
On 10/07/17 10:01, Neil Armstrong wrote: > The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver > for such controller. > The controller does not need HPD to be active, and could support up to max > 5 logical addresses, but only 1 is handled since the Suspend firmware can > m