Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Sakari Ailus
Hi Mani, On Tue, Aug 13, 2019 at 07:22:09PM +0530, Manivannan Sadhasivam wrote: > Hi Sakari, > > On Tue, Aug 13, 2019 at 03:22:12PM +0300, Sakari Ailus wrote: > > Hi Manivannan, > > > > On Tue, Aug 13, 2019 at 05:44:00PM +0530, Manivannan Sadhasivam wrote: > > > Hi Sakari, > > > > > > On Tue,

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Manivannan Sadhasivam
Hi Sakari, On Tue, Aug 13, 2019 at 03:22:12PM +0300, Sakari Ailus wrote: > Hi Manivannan, > > On Tue, Aug 13, 2019 at 05:44:00PM +0530, Manivannan Sadhasivam wrote: > > Hi Sakari, > > > > On Tue, Aug 13, 2019 at 02:46:43PM +0300, Sakari Ailus wrote: > > > Hi Manivannan, > > > > > > On Tue, Aug

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Sakari Ailus
Hi Manivannan, On Tue, Aug 13, 2019 at 05:44:00PM +0530, Manivannan Sadhasivam wrote: > Hi Sakari, > > On Tue, Aug 13, 2019 at 02:46:43PM +0300, Sakari Ailus wrote: > > Hi Manivannan, > > > > On Tue, Aug 13, 2019 at 05:03:58PM +0530, Manivannan Sadhasivam wrote: > > > Hi Sakari, > > > > > >

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Manivannan Sadhasivam
On Tue, Aug 13, 2019 at 02:54:27PM +0300, Sakari Ailus wrote: > On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote: > ... > > +Required Properties: > > +- compatible: Should be "sony,imx290" > > +- reg: I2C bus address of the device > > +- clocks: Reference to the xclk clock. >

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Manivannan Sadhasivam
Hi Sakari, On Tue, Aug 13, 2019 at 02:46:43PM +0300, Sakari Ailus wrote: > Hi Manivannan, > > On Tue, Aug 13, 2019 at 05:03:58PM +0530, Manivannan Sadhasivam wrote: > > Hi Sakari, > > > > Thanks for the review! > > > > On Tue, Aug 13, 2019 at 12:45:26PM +0300, Sakari Ailus wrote: > > > Hi

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Sakari Ailus
On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote: ... > +Required Properties: > +- compatible: Should be "sony,imx290" > +- reg: I2C bus address of the device > +- clocks: Reference to the xclk clock. > +- clock-names: Should be "xclk". > +- clock-frequency: Frequency of the

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Sakari Ailus
Hi Russell, On Tue, Aug 13, 2019 at 12:38:46PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote: > > +Required Properties: > > +- compatible: Should be "sony,imx290" > > +- reg: I2C bus address of the device > > +- clocks:

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Manivannan Sadhasivam
Hi Russel, On Tue, Aug 13, 2019 at 12:38:46PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote: > > +Required Properties: > > +- compatible: Should be "sony,imx290" > > +- reg: I2C bus address of the device > > +- clocks:

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Sakari Ailus
Hi Manivannan, On Tue, Aug 13, 2019 at 05:03:58PM +0530, Manivannan Sadhasivam wrote: > Hi Sakari, > > Thanks for the review! > > On Tue, Aug 13, 2019 at 12:45:26PM +0300, Sakari Ailus wrote: > > Hi Manivannan, > > > > On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote: > >

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Russell King - ARM Linux admin
On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote: > +Required Properties: > +- compatible: Should be "sony,imx290" > +- reg: I2C bus address of the device > +- clocks: Reference to the xclk clock. > +- clock-names: Should be "xclk". > +- clock-frequency: Frequency of the xclk

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Manivannan Sadhasivam
Hi Sakari, Thanks for the review! On Tue, Aug 13, 2019 at 12:45:26PM +0300, Sakari Ailus wrote: > Hi Manivannan, > > On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote: > > Add devicetree binding for IMX290 CMOS image sensor. > > > > Signed-off-by: Manivannan Sadhasivam > >

Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding

2019-08-13 Thread Sakari Ailus
Hi Manivannan, On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote: > Add devicetree binding for IMX290 CMOS image sensor. > > Signed-off-by: Manivannan Sadhasivam > Reviewed-by: Rob Herring > --- > .../devicetree/bindings/media/i2c/imx290.txt | 51 +++ > 1