Re: [PATCH v2 1/3] mm/gup_benchmark: handle gup failures

On Sun, 8 Apr 2018 06:12:13 +0300 "Michael S. Tsirkin" wrote: > On Sat, Apr 07, 2018 at 01:08:43PM -0700, Linus Torvalds wrote: > > On Thu, Apr 5, 2018 at 2:03 PM, Michael S. Tsirkin wrote: > > > > > > nr = get_user_pages_fast(addr, nr,

Re: [PATCH v2 1/3] mm/gup_benchmark: handle gup failures

On Sun, 8 Apr 2018 06:12:13 +0300 "Michael S. Tsirkin" wrote: > On Sat, Apr 07, 2018 at 01:08:43PM -0700, Linus Torvalds wrote: > > On Thu, Apr 5, 2018 at 2:03 PM, Michael S. Tsirkin wrote: > > > > > > nr = get_user_pages_fast(addr, nr, gup->flags & 1, pages > > > + i); > > > -

Re: [PATCH v2 1/3] mm/gup_benchmark: handle gup failures

On Sat, Apr 07, 2018 at 01:08:43PM -0700, Linus Torvalds wrote: > On Thu, Apr 5, 2018 at 2:03 PM, Michael S. Tsirkin wrote: > > > > nr = get_user_pages_fast(addr, nr, gup->flags & 1, pages + > > i); > > - i += nr; > > + if (nr > 0) > >

Re: [PATCH v2 1/3] mm/gup_benchmark: handle gup failures

On Sat, Apr 07, 2018 at 01:08:43PM -0700, Linus Torvalds wrote: > On Thu, Apr 5, 2018 at 2:03 PM, Michael S. Tsirkin wrote: > > > > nr = get_user_pages_fast(addr, nr, gup->flags & 1, pages + > > i); > > - i += nr; > > + if (nr > 0) > > +

Re: [PATCH v2 1/3] mm/gup_benchmark: handle gup failures

On Thu, Apr 5, 2018 at 2:03 PM, Michael S. Tsirkin wrote: > > nr = get_user_pages_fast(addr, nr, gup->flags & 1, pages + i); > - i += nr; > + if (nr > 0) > + i += nr; Can we just make this robust while at it, and

Re: [PATCH v2 1/3] mm/gup_benchmark: handle gup failures

On Thu, Apr 5, 2018 at 2:03 PM, Michael S. Tsirkin wrote: > > nr = get_user_pages_fast(addr, nr, gup->flags & 1, pages + i); > - i += nr; > + if (nr > 0) > + i += nr; Can we just make this robust while at it, and just make it