Re: [PATCH v2 1/3] mux: Add mux_control_get_optional() API

2017-07-19 Thread Stephen Boyd
Quoting Peter Rosin (2017-07-19 00:15:38) > On 2017-07-19 04:08, Stephen Boyd wrote: > > Quoting Peter Rosin (2017-07-17 01:20:14) > >> On 2017-07-14 23:40, Stephen Boyd wrote: > >>> @@ -441,6 +447,8 @@ struct mux_control *mux_control_get(struct device > >>> *dev, const char *mux_name) > >>>

Re: [PATCH v2 1/3] mux: Add mux_control_get_optional() API

2017-07-19 Thread Stephen Boyd
Quoting Peter Rosin (2017-07-19 00:15:38) > On 2017-07-19 04:08, Stephen Boyd wrote: > > Quoting Peter Rosin (2017-07-17 01:20:14) > >> On 2017-07-14 23:40, Stephen Boyd wrote: > >>> @@ -441,6 +447,8 @@ struct mux_control *mux_control_get(struct device > >>> *dev, const char *mux_name) > >>>

Re: [PATCH v2 1/3] mux: Add mux_control_get_optional() API

2017-07-19 Thread Peter Rosin
On 2017-07-19 04:08, Stephen Boyd wrote: > Quoting Peter Rosin (2017-07-17 01:20:14) >> On 2017-07-14 23:40, Stephen Boyd wrote: >>> diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c >>> index 90b8995f07cb..a0e5bf16f02f 100644 >>> --- a/drivers/mux/mux-core.c >>> +++

Re: [PATCH v2 1/3] mux: Add mux_control_get_optional() API

2017-07-19 Thread Peter Rosin
On 2017-07-19 04:08, Stephen Boyd wrote: > Quoting Peter Rosin (2017-07-17 01:20:14) >> On 2017-07-14 23:40, Stephen Boyd wrote: >>> diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c >>> index 90b8995f07cb..a0e5bf16f02f 100644 >>> --- a/drivers/mux/mux-core.c >>> +++

Re: [PATCH v2 1/3] mux: Add mux_control_get_optional() API

2017-07-18 Thread Stephen Boyd
Quoting Peter Rosin (2017-07-17 01:20:14) > On 2017-07-14 23:40, Stephen Boyd wrote: > > diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c > > index 90b8995f07cb..a0e5bf16f02f 100644 > > --- a/drivers/mux/mux-core.c > > +++ b/drivers/mux/mux-core.c > > @@ -289,6 +289,9 @@

Re: [PATCH v2 1/3] mux: Add mux_control_get_optional() API

2017-07-18 Thread Stephen Boyd
Quoting Peter Rosin (2017-07-17 01:20:14) > On 2017-07-14 23:40, Stephen Boyd wrote: > > diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c > > index 90b8995f07cb..a0e5bf16f02f 100644 > > --- a/drivers/mux/mux-core.c > > +++ b/drivers/mux/mux-core.c > > @@ -289,6 +289,9 @@

Re: [PATCH v2 1/3] mux: Add mux_control_get_optional() API

2017-07-17 Thread Peter Rosin
Generally looks like I imagined, but there are a few nits and some things that I'd like to do differently. Comments inline. Thanks! On 2017-07-14 23:40, Stephen Boyd wrote: > Sometimes drivers only use muxes under certain scenarios. For > example, the chipidea usb controller may be connected to a

Re: [PATCH v2 1/3] mux: Add mux_control_get_optional() API

2017-07-17 Thread Peter Rosin
Generally looks like I imagined, but there are a few nits and some things that I'd like to do differently. Comments inline. Thanks! On 2017-07-14 23:40, Stephen Boyd wrote: > Sometimes drivers only use muxes under certain scenarios. For > example, the chipidea usb controller may be connected to a