Re: [PATCH v2 1/4] ACPI / watchdog: Add support for WDAT hardware watchdog

2016-09-20 Thread Guenter Roeck
On 09/20/2016 05:30 AM, Mika Westerberg wrote: Starting from Intel Skylake the iTCO watchdog timer registers were moved to reside in the same register space with SMBus host controller. Not all needed registers are available though and we need to unhide P2SB (Primary to Sideband) device briefly t

Re: [PATCH v2 1/4] ACPI / watchdog: Add support for WDAT hardware watchdog

2016-09-20 Thread Guenter Roeck
On 09/20/2016 06:50 AM, Mika Westerberg wrote: On Tue, Sep 20, 2016 at 06:37:23AM -0700, Guenter Roeck wrote: + for (i = 0; i < tbl->entries; i++) { + const struct acpi_generic_address *gas; + struct wdat_instruction *instr; + struct list_head *ins

Re: [PATCH v2 1/4] ACPI / watchdog: Add support for WDAT hardware watchdog

2016-09-20 Thread Mika Westerberg
On Tue, Sep 20, 2016 at 06:37:23AM -0700, Guenter Roeck wrote: > > + for (i = 0; i < tbl->entries; i++) { > > + const struct acpi_generic_address *gas; > > + struct wdat_instruction *instr; > > + struct list_head *instructions; > > + unsigned int action; >

Re: [PATCH v2 1/4] ACPI / watchdog: Add support for WDAT hardware watchdog

2016-09-20 Thread Guenter Roeck
On 09/20/2016 05:30 AM, Mika Westerberg wrote: Starting from Intel Skylake the iTCO watchdog timer registers were moved to reside in the same register space with SMBus host controller. Not all needed registers are available though and we need to unhide P2SB (Primary to Sideband) device briefly t