Re: [PATCH v2 1/4] KVM: add spinlock optimization framework

2017-08-08 Thread Longpeng (Mike)
On 2017/8/8 17:00, Paolo Bonzini wrote: > On 08/08/2017 10:42, David Hildenbrand wrote: >> >>> +bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu) >>> +{ >>> + return false; >>> +} >> >> why don't we need an EXPORT_SYMBOL here? > > Is it used outside the KVM module? I think no architecture

Re: [PATCH v2 1/4] KVM: add spinlock optimization framework

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 10:42, David Hildenbrand wrote: > >> +bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu) >> +{ >> +return false; >> +} > > why don't we need an EXPORT_SYMBOL here? Is it used outside the KVM module? I think no architecture actually needs to export it. >> -void kvm_vcpu_on_sp

Re: [PATCH v2 1/4] KVM: add spinlock optimization framework

2017-08-08 Thread David Hildenbrand
On 08.08.2017 10:42, David Hildenbrand wrote: > >> +bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu) >> +{ >> +return false; >> +} > > why don't we need an EXPORT_SYMBOL here? > >> + >> /* Just ensure a guest exit from a particular CPU */ >> static void exit_vm_noop(void *info) >> { >>

Re: [PATCH v2 1/4] KVM: add spinlock optimization framework

2017-08-08 Thread David Hildenbrand
> +bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu) > +{ > + return false; > +} why don't we need an EXPORT_SYMBOL here? > + > /* Just ensure a guest exit from a particular CPU */ > static void exit_vm_noop(void *info) > { > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > inde

Re: [PATCH v2 1/4] KVM: add spinlock optimization framework

2017-08-08 Thread Cornelia Huck
On Tue, 8 Aug 2017 09:34:14 +0200 Paolo Bonzini wrote: > On 08/08/2017 06:05, Longpeng(Mike) wrote: > > return 1; > > diff --git a/arch/s390/kvm/diag.c b/arch/s390/kvm/diag.c > > index ce865bd..4ea8c38 100644 > > --- a/arch/s390/kvm/diag.c > > +++ b/arch/s390/kvm/diag.c > > @@ -150,7 +150,7 @

Re: [PATCH v2 1/4] KVM: add spinlock optimization framework

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 06:05, Longpeng(Mike) wrote: > return 1; > diff --git a/arch/s390/kvm/diag.c b/arch/s390/kvm/diag.c > index ce865bd..4ea8c38 100644 > --- a/arch/s390/kvm/diag.c > +++ b/arch/s390/kvm/diag.c > @@ -150,7 +150,7 @@ static int __diag_time_slice_end(struct kvm_vcpu *vcpu) > { >