Re: [PATCH v2 1/5] dmaengine: qcom: bam_dma: make bam clk optional

On Wed 14 Feb 10:19 PST 2018, Srinivas Kandagatla wrote: > Thanks for the Review, > > On 14/02/18 15:41, Bjorn Andersson wrote: > > > bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk"); > > > - if (IS_ERR(bdev->bamclk)) > > > - return PTR_ERR(bdev->bamclk); > > > - > > > - ret =

Re: [PATCH v2 1/5] dmaengine: qcom: bam_dma: make bam clk optional

On Wed 14 Feb 10:19 PST 2018, Srinivas Kandagatla wrote: > Thanks for the Review, > > On 14/02/18 15:41, Bjorn Andersson wrote: > > > bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk"); > > > - if (IS_ERR(bdev->bamclk)) > > > - return PTR_ERR(bdev->bamclk); > > > - > > > - ret =

Re: [PATCH v2 1/5] dmaengine: qcom: bam_dma: make bam clk optional

Thanks for the Review, On 14/02/18 15:41, Bjorn Andersson wrote: bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk"); - if (IS_ERR(bdev->bamclk)) - return PTR_ERR(bdev->bamclk); - - ret = clk_prepare_enable(bdev->bamclk); - if (ret) { -

Re: [PATCH v2 1/5] dmaengine: qcom: bam_dma: make bam clk optional

Thanks for the Review, On 14/02/18 15:41, Bjorn Andersson wrote: bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk"); - if (IS_ERR(bdev->bamclk)) - return PTR_ERR(bdev->bamclk); - - ret = clk_prepare_enable(bdev->bamclk); - if (ret) { -

Re: [PATCH v2 1/5] dmaengine: qcom: bam_dma: make bam clk optional

On Wed 14 Feb 06:44 PST 2018, Srinivas Kandagatla wrote: > @@ -1233,13 +1233,14 @@ static int bam_dma_probe(struct platform_device *pdev) > "qcom,controlled-remotely"); > > bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk"); > - if

Re: [PATCH v2 1/5] dmaengine: qcom: bam_dma: make bam clk optional

On Wed 14 Feb 06:44 PST 2018, Srinivas Kandagatla wrote: > @@ -1233,13 +1233,14 @@ static int bam_dma_probe(struct platform_device *pdev) > "qcom,controlled-remotely"); > > bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk"); > - if