Re: [PATCH v2 1/5] iio: Change ISA_BUS_API dependency to selection

[Linus Walleij]

On Fri, Dec 29, 2017 at 9:13 PM, William Breathitt Gray
 wrote:

> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus
> driver. The ISA bus driver does not perform any hardware interaction,
> and is instead just a thin layer of software abstraction to eliminate
> boilerplate code common to ISA-style device drivers. Since ISA_BUS_API
> has no dependencies and does not jeopardize the integrity of the system
> when enabled, drivers should select it when the ISA bus driver
> functionality is needed.
>
> Cc: Jonathan Cameron 
> Cc: Hartmut Knaack 
> Cc: Lars-Peter Clausen 
> Cc: Peter Meerwald-Stadler 
> Signed-off-by: William Breathitt Gray 

Patch applied to the GPIO tree for v4.17.

Yours,
Linus Walleij

Re: [PATCH v2 1/5] iio: Change ISA_BUS_API dependency to selection

[Linus Walleij]

On Fri, Dec 29, 2017 at 9:13 PM, William Breathitt Gray
 wrote:

> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus
> driver. The ISA bus driver does not perform any hardware interaction,
> and is instead just a thin layer of software abstraction to eliminate
> boilerplate code common to ISA-style device drivers. Since ISA_BUS_API
> has no dependencies and does not jeopardize the integrity of the system
> when enabled, drivers should select it when the ISA bus driver
> functionality is needed.
>
> Cc: Jonathan Cameron 
> Cc: Hartmut Knaack 
> Cc: Lars-Peter Clausen 
> Cc: Peter Meerwald-Stadler 
> Signed-off-by: William Breathitt Gray 

Patch applied to the GPIO tree for v4.17.

Yours,
Linus Walleij

Re: [PATCH v2 1/5] iio: Change ISA_BUS_API dependency to selection

[Jonathan Cameron]

On Fri, 29 Dec 2017 15:13:19 -0500
William Breathitt Gray  wrote:

> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus
> driver. The ISA bus driver does not perform any hardware interaction,
> and is instead just a thin layer of software abstraction to eliminate
> boilerplate code common to ISA-style device drivers. Since ISA_BUS_API
> has no dependencies and does not jeopardize the integrity of the system
> when enabled, drivers should select it when the ISA bus driver
> functionality is needed.
> 
> Cc: Jonathan Cameron 
> Cc: Hartmut Knaack 
> Cc: Lars-Peter Clausen 
> Cc: Peter Meerwald-Stadler 
> Signed-off-by: William Breathitt Gray 
Acked-by: Jonathan Cameron 
> ---
>  drivers/iio/adc/Kconfig | 3 ++-
>  drivers/iio/counter/Kconfig | 3 ++-
>  drivers/iio/dac/Kconfig | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index ef86296b8b0d..7c00e5858693 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -658,7 +658,8 @@ config STM32_ADC
>  
>  config STX104
>   tristate "Apex Embedded Systems STX104 driver"
> - depends on PC104 && X86 && ISA_BUS_API
> + depends on PC104 && X86
> + select ISA_BUS_API
>   select GPIOLIB
>   help
> Say yes here to build support for the Apex Embedded Systems STX104
> diff --git a/drivers/iio/counter/Kconfig b/drivers/iio/counter/Kconfig
> index 474e1ac4e7c0..bf1e559ad7cd 100644
> --- a/drivers/iio/counter/Kconfig
> +++ b/drivers/iio/counter/Kconfig
> @@ -7,7 +7,8 @@ menu "Counters"
>  
>  config 104_QUAD_8
>   tristate "ACCES 104-QUAD-8 driver"
> - depends on PC104 && X86 && ISA_BUS_API
> + depends on PC104 && X86
> + select ISA_BUS_API
>   help
> Say yes here to build support for the ACCES 104-QUAD-8 quadrature
> encoder counter/interface device family (104-QUAD-8, 104-QUAD-4).
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 965d5c0d2468..76db0768e454 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -195,7 +195,8 @@ config AD7303
>  
>  config CIO_DAC
>   tristate "Measurement Computing CIO-DAC IIO driver"
> - depends on X86 && ISA_BUS_API
> + depends on X86 && (ISA_BUS || PC104)
> + select ISA_BUS_API
>   help
> Say yes here to build support for the Measurement Computing CIO-DAC
> analog output device family (CIO-DAC16, CIO-DAC08, PC104-DAC06). The

Re: [PATCH v2 1/5] iio: Change ISA_BUS_API dependency to selection

[Jonathan Cameron]

On Fri, 29 Dec 2017 15:13:19 -0500
William Breathitt Gray  wrote:

> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus
> driver. The ISA bus driver does not perform any hardware interaction,
> and is instead just a thin layer of software abstraction to eliminate
> boilerplate code common to ISA-style device drivers. Since ISA_BUS_API
> has no dependencies and does not jeopardize the integrity of the system
> when enabled, drivers should select it when the ISA bus driver
> functionality is needed.
> 
> Cc: Jonathan Cameron 
> Cc: Hartmut Knaack 
> Cc: Lars-Peter Clausen 
> Cc: Peter Meerwald-Stadler 
> Signed-off-by: William Breathitt Gray 
Acked-by: Jonathan Cameron 
> ---
>  drivers/iio/adc/Kconfig | 3 ++-
>  drivers/iio/counter/Kconfig | 3 ++-
>  drivers/iio/dac/Kconfig | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index ef86296b8b0d..7c00e5858693 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -658,7 +658,8 @@ config STM32_ADC
>  
>  config STX104
>   tristate "Apex Embedded Systems STX104 driver"
> - depends on PC104 && X86 && ISA_BUS_API
> + depends on PC104 && X86
> + select ISA_BUS_API
>   select GPIOLIB
>   help
> Say yes here to build support for the Apex Embedded Systems STX104
> diff --git a/drivers/iio/counter/Kconfig b/drivers/iio/counter/Kconfig
> index 474e1ac4e7c0..bf1e559ad7cd 100644
> --- a/drivers/iio/counter/Kconfig
> +++ b/drivers/iio/counter/Kconfig
> @@ -7,7 +7,8 @@ menu "Counters"
>  
>  config 104_QUAD_8
>   tristate "ACCES 104-QUAD-8 driver"
> - depends on PC104 && X86 && ISA_BUS_API
> + depends on PC104 && X86
> + select ISA_BUS_API
>   help
> Say yes here to build support for the ACCES 104-QUAD-8 quadrature
> encoder counter/interface device family (104-QUAD-8, 104-QUAD-4).
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 965d5c0d2468..76db0768e454 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -195,7 +195,8 @@ config AD7303
>  
>  config CIO_DAC
>   tristate "Measurement Computing CIO-DAC IIO driver"
> - depends on X86 && ISA_BUS_API
> + depends on X86 && (ISA_BUS || PC104)
> + select ISA_BUS_API
>   help
> Say yes here to build support for the Measurement Computing CIO-DAC
> analog output device family (CIO-DAC16, CIO-DAC08, PC104-DAC06). The