Re: [PATCH v2 14/16] arm64: dts: mt7622: add thermal and related nodes

2018-02-12 Thread Matthias Brugger 


On 02/09/2018 04:51 AM, Sean Wang wrote:
> On Wed, 2018-02-07 at 12:43 +0100, Matthias Brugger wrote:
>>
>> On 02/06/2018 10:53 AM, sean.w...@mediatek.com wrote:
>>> From: Sean Wang 
>>>
>>> add nodes for the thermal controller and associated thermal zone using
>>> CPU as the cooling device for each trip point. In addition, add a fixup
>>> for thermal_calibration on nvmem should be 12 bytes as the minimal
>>> requirement.
>>>
>>> Signed-off-by: Sean Wang 
>>> ---
>>>  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 
>>> +++-
>>>  1 file changed, 71 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi 
>>> b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>>> index e6dd4f6..6cf67dd 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>>> @@ -12,6 +12,7 @@
>>>  #include 
>>>  #include 
>>>  #include 
>>> +#include 
>>>  
>>>  / {
>>> compatible = "mediatek,mt7622";
>>> @@ -75,6 +76,7 @@
>>>  < CLK_APMIXED_MAIN_CORE_EN>;
>>> clock-names = "cpu", "intermediate";
>>> operating-points-v2 = <_opp_table>;
>>> +   #cooling-cells = <2>;
>>> enable-method = "psci";
>>> clock-frequency = <13>;
>>> };
>>> @@ -119,6 +121,58 @@
>>> };
>>> };
>>>  
>>> +   thermal-zones {
>>> +   cpu_thermal: cpu-thermal {
>>> +   polling-delay-passive = <1000>;
>>> +   polling-delay = <1000>;
>>> +
>>> +   thermal-sensors = < 0>;
>>> +
>>> +   trips {
>>> +   cpu_passive: cpu-passive {
>>> +   temperature = <47000>;
>>> +   hysteresis = <2000>;
>>> +   type = "passive";
>>> +   };
>>> +
>>> +   cpu_active: cpu-active {
>>> +   temperature = <67000>;
>>> +   hysteresis = <2000>;
>>> +   type = "active";
>>> +   };
>>> +
>>> +   cpu_hot: cpu-hot {
>>> +   temperature = <87000>;
>>> +   hysteresis = <2000>;
>>> +   type = "hot";
>>> +   };
>>> +
>>> +   cpu-crit {
>>> +   temperature = <107000>;
>>> +   hysteresis = <2000>;
>>> +   type = "critical";
>>> +   };
>>> +   };
>>> +
>>> +   cooling-maps {
>>> +   map0 {
>>> +   trip = <_passive>;
>>> +   cooling-device = < 
>>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>>> +   };
>>> +
>>> +   map1 {
>>> +   trip = <_active>;
>>> +   cooling-device = < 
>>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>>> +   };
>>> +
>>> +   map2 {
>>> +   trip = <_hot>;
>>> +   cooling-device = < 
>>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>>> +   };
>>> +   };
>>> +   };
>>> +   };
>>> +
>>> timer {
>>> compatible = "arm,armv8-timer";
>>> interrupt-parent = <>;
>>> @@ -201,7 +255,7 @@
>>> #size-cells = <1>;
>>>  
>>> thermal_calibration: calib@198 {
>>> -   reg = <0x198 0x8>;
>>> +   reg = <0x198 0xc>;
>>
>> Any reason why this is not part of patch 8/16?
>>
> 
> There's no strong reason wanting me to do that. patch 8 has contained a
> lot of nodes and patch 16 is present just in v2. So, I felt it should be
> a little bit easy that people reviews those patches if they are put into
> separate patches. But, It's still fine to make them into one in the next
> version.
> 

Please add it to 8/16 as this is where you define the node in the first place.

Thanks!

Re: [PATCH v2 14/16] arm64: dts: mt7622: add thermal and related nodes

2018-02-12 Thread Matthias Brugger 


On 02/09/2018 04:51 AM, Sean Wang wrote:
> On Wed, 2018-02-07 at 12:43 +0100, Matthias Brugger wrote:
>>
>> On 02/06/2018 10:53 AM, sean.w...@mediatek.com wrote:
>>> From: Sean Wang 
>>>
>>> add nodes for the thermal controller and associated thermal zone using
>>> CPU as the cooling device for each trip point. In addition, add a fixup
>>> for thermal_calibration on nvmem should be 12 bytes as the minimal
>>> requirement.
>>>
>>> Signed-off-by: Sean Wang 
>>> ---
>>>  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 
>>> +++-
>>>  1 file changed, 71 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi 
>>> b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>>> index e6dd4f6..6cf67dd 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>>> @@ -12,6 +12,7 @@
>>>  #include 
>>>  #include 
>>>  #include 
>>> +#include 
>>>  
>>>  / {
>>> compatible = "mediatek,mt7622";
>>> @@ -75,6 +76,7 @@
>>>  < CLK_APMIXED_MAIN_CORE_EN>;
>>> clock-names = "cpu", "intermediate";
>>> operating-points-v2 = <_opp_table>;
>>> +   #cooling-cells = <2>;
>>> enable-method = "psci";
>>> clock-frequency = <13>;
>>> };
>>> @@ -119,6 +121,58 @@
>>> };
>>> };
>>>  
>>> +   thermal-zones {
>>> +   cpu_thermal: cpu-thermal {
>>> +   polling-delay-passive = <1000>;
>>> +   polling-delay = <1000>;
>>> +
>>> +   thermal-sensors = < 0>;
>>> +
>>> +   trips {
>>> +   cpu_passive: cpu-passive {
>>> +   temperature = <47000>;
>>> +   hysteresis = <2000>;
>>> +   type = "passive";
>>> +   };
>>> +
>>> +   cpu_active: cpu-active {
>>> +   temperature = <67000>;
>>> +   hysteresis = <2000>;
>>> +   type = "active";
>>> +   };
>>> +
>>> +   cpu_hot: cpu-hot {
>>> +   temperature = <87000>;
>>> +   hysteresis = <2000>;
>>> +   type = "hot";
>>> +   };
>>> +
>>> +   cpu-crit {
>>> +   temperature = <107000>;
>>> +   hysteresis = <2000>;
>>> +   type = "critical";
>>> +   };
>>> +   };
>>> +
>>> +   cooling-maps {
>>> +   map0 {
>>> +   trip = <_passive>;
>>> +   cooling-device = < 
>>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>>> +   };
>>> +
>>> +   map1 {
>>> +   trip = <_active>;
>>> +   cooling-device = < 
>>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>>> +   };
>>> +
>>> +   map2 {
>>> +   trip = <_hot>;
>>> +   cooling-device = < 
>>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>>> +   };
>>> +   };
>>> +   };
>>> +   };
>>> +
>>> timer {
>>> compatible = "arm,armv8-timer";
>>> interrupt-parent = <>;
>>> @@ -201,7 +255,7 @@
>>> #size-cells = <1>;
>>>  
>>> thermal_calibration: calib@198 {
>>> -   reg = <0x198 0x8>;
>>> +   reg = <0x198 0xc>;
>>
>> Any reason why this is not part of patch 8/16?
>>
> 
> There's no strong reason wanting me to do that. patch 8 has contained a
> lot of nodes and patch 16 is present just in v2. So, I felt it should be
> a little bit easy that people reviews those patches if they are put into
> separate patches. But, It's still fine to make them into one in the next
> version.
> 

Please add it to 8/16 as this is where you define the node in the first place.

Thanks!

Re: [PATCH v2 14/16] arm64: dts: mt7622: add thermal and related nodes

2018-02-08 Thread Sean Wang 
On Wed, 2018-02-07 at 12:43 +0100, Matthias Brugger wrote:
> 
> On 02/06/2018 10:53 AM, sean.w...@mediatek.com wrote:
> > From: Sean Wang 
> > 
> > add nodes for the thermal controller and associated thermal zone using
> > CPU as the cooling device for each trip point. In addition, add a fixup
> > for thermal_calibration on nvmem should be 12 bytes as the minimal
> > requirement.
> > 
> > Signed-off-by: Sean Wang 
> > ---
> >  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 
> > +++-
> >  1 file changed, 71 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi 
> > b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > index e6dd4f6..6cf67dd 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > @@ -12,6 +12,7 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> >  
> >  / {
> > compatible = "mediatek,mt7622";
> > @@ -75,6 +76,7 @@
> >  < CLK_APMIXED_MAIN_CORE_EN>;
> > clock-names = "cpu", "intermediate";
> > operating-points-v2 = <_opp_table>;
> > +   #cooling-cells = <2>;
> > enable-method = "psci";
> > clock-frequency = <13>;
> > };
> > @@ -119,6 +121,58 @@
> > };
> > };
> >  
> > +   thermal-zones {
> > +   cpu_thermal: cpu-thermal {
> > +   polling-delay-passive = <1000>;
> > +   polling-delay = <1000>;
> > +
> > +   thermal-sensors = < 0>;
> > +
> > +   trips {
> > +   cpu_passive: cpu-passive {
> > +   temperature = <47000>;
> > +   hysteresis = <2000>;
> > +   type = "passive";
> > +   };
> > +
> > +   cpu_active: cpu-active {
> > +   temperature = <67000>;
> > +   hysteresis = <2000>;
> > +   type = "active";
> > +   };
> > +
> > +   cpu_hot: cpu-hot {
> > +   temperature = <87000>;
> > +   hysteresis = <2000>;
> > +   type = "hot";
> > +   };
> > +
> > +   cpu-crit {
> > +   temperature = <107000>;
> > +   hysteresis = <2000>;
> > +   type = "critical";
> > +   };
> > +   };
> > +
> > +   cooling-maps {
> > +   map0 {
> > +   trip = <_passive>;
> > +   cooling-device = < 
> > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +   };
> > +
> > +   map1 {
> > +   trip = <_active>;
> > +   cooling-device = < 
> > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +   };
> > +
> > +   map2 {
> > +   trip = <_hot>;
> > +   cooling-device = < 
> > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +   };
> > +   };
> > +   };
> > +   };
> > +
> > timer {
> > compatible = "arm,armv8-timer";
> > interrupt-parent = <>;
> > @@ -201,7 +255,7 @@
> > #size-cells = <1>;
> >  
> > thermal_calibration: calib@198 {
> > -   reg = <0x198 0x8>;
> > +   reg = <0x198 0xc>;
> 
> Any reason why this is not part of patch 8/16?
> 

There's no strong reason wanting me to do that. patch 8 has contained a
lot of nodes and patch 16 is present just in v2. So, I felt it should be
a little bit easy that people reviews those patches if they are put into
separate patches. But, It's still fine to make them into one in the next
version.

> Regards,
> Matthias
>

Re: [PATCH v2 14/16] arm64: dts: mt7622: add thermal and related nodes

2018-02-08 Thread Sean Wang 
On Wed, 2018-02-07 at 12:43 +0100, Matthias Brugger wrote:
> 
> On 02/06/2018 10:53 AM, sean.w...@mediatek.com wrote:
> > From: Sean Wang 
> > 
> > add nodes for the thermal controller and associated thermal zone using
> > CPU as the cooling device for each trip point. In addition, add a fixup
> > for thermal_calibration on nvmem should be 12 bytes as the minimal
> > requirement.
> > 
> > Signed-off-by: Sean Wang 
> > ---
> >  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 
> > +++-
> >  1 file changed, 71 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi 
> > b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > index e6dd4f6..6cf67dd 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > @@ -12,6 +12,7 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> >  
> >  / {
> > compatible = "mediatek,mt7622";
> > @@ -75,6 +76,7 @@
> >  < CLK_APMIXED_MAIN_CORE_EN>;
> > clock-names = "cpu", "intermediate";
> > operating-points-v2 = <_opp_table>;
> > +   #cooling-cells = <2>;
> > enable-method = "psci";
> > clock-frequency = <13>;
> > };
> > @@ -119,6 +121,58 @@
> > };
> > };
> >  
> > +   thermal-zones {
> > +   cpu_thermal: cpu-thermal {
> > +   polling-delay-passive = <1000>;
> > +   polling-delay = <1000>;
> > +
> > +   thermal-sensors = < 0>;
> > +
> > +   trips {
> > +   cpu_passive: cpu-passive {
> > +   temperature = <47000>;
> > +   hysteresis = <2000>;
> > +   type = "passive";
> > +   };
> > +
> > +   cpu_active: cpu-active {
> > +   temperature = <67000>;
> > +   hysteresis = <2000>;
> > +   type = "active";
> > +   };
> > +
> > +   cpu_hot: cpu-hot {
> > +   temperature = <87000>;
> > +   hysteresis = <2000>;
> > +   type = "hot";
> > +   };
> > +
> > +   cpu-crit {
> > +   temperature = <107000>;
> > +   hysteresis = <2000>;
> > +   type = "critical";
> > +   };
> > +   };
> > +
> > +   cooling-maps {
> > +   map0 {
> > +   trip = <_passive>;
> > +   cooling-device = < 
> > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +   };
> > +
> > +   map1 {
> > +   trip = <_active>;
> > +   cooling-device = < 
> > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +   };
> > +
> > +   map2 {
> > +   trip = <_hot>;
> > +   cooling-device = < 
> > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +   };
> > +   };
> > +   };
> > +   };
> > +
> > timer {
> > compatible = "arm,armv8-timer";
> > interrupt-parent = <>;
> > @@ -201,7 +255,7 @@
> > #size-cells = <1>;
> >  
> > thermal_calibration: calib@198 {
> > -   reg = <0x198 0x8>;
> > +   reg = <0x198 0xc>;
> 
> Any reason why this is not part of patch 8/16?
> 

There's no strong reason wanting me to do that. patch 8 has contained a
lot of nodes and patch 16 is present just in v2. So, I felt it should be
a little bit easy that people reviews those patches if they are put into
separate patches. But, It's still fine to make them into one in the next
version.

> Regards,
> Matthias
>

Re: [PATCH v2 14/16] arm64: dts: mt7622: add thermal and related nodes

2018-02-07 Thread Matthias Brugger 


On 02/06/2018 10:53 AM, sean.w...@mediatek.com wrote:
> From: Sean Wang 
> 
> add nodes for the thermal controller and associated thermal zone using
> CPU as the cooling device for each trip point. In addition, add a fixup
> for thermal_calibration on nvmem should be 12 bytes as the minimal
> requirement.
> 
> Signed-off-by: Sean Wang 
> ---
>  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 
> +++-
>  1 file changed, 71 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index e6dd4f6..6cf67dd 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -12,6 +12,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  / {
>   compatible = "mediatek,mt7622";
> @@ -75,6 +76,7 @@
>< CLK_APMIXED_MAIN_CORE_EN>;
>   clock-names = "cpu", "intermediate";
>   operating-points-v2 = <_opp_table>;
> + #cooling-cells = <2>;
>   enable-method = "psci";
>   clock-frequency = <13>;
>   };
> @@ -119,6 +121,58 @@
>   };
>   };
>  
> + thermal-zones {
> + cpu_thermal: cpu-thermal {
> + polling-delay-passive = <1000>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 0>;
> +
> + trips {
> + cpu_passive: cpu-passive {
> + temperature = <47000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_active: cpu-active {
> + temperature = <67000>;
> + hysteresis = <2000>;
> + type = "active";
> + };
> +
> + cpu_hot: cpu-hot {
> + temperature = <87000>;
> + hysteresis = <2000>;
> + type = "hot";
> + };
> +
> + cpu-crit {
> + temperature = <107000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <_passive>;
> + cooling-device = < 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> +
> + map1 {
> + trip = <_active>;
> + cooling-device = < 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> +
> + map2 {
> + trip = <_hot>;
> + cooling-device = < 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> + };
> +
>   timer {
>   compatible = "arm,armv8-timer";
>   interrupt-parent = <>;
> @@ -201,7 +255,7 @@
>   #size-cells = <1>;
>  
>   thermal_calibration: calib@198 {
> - reg = <0x198 0x8>;
> + reg = <0x198 0xc>;

Any reason why this is not part of patch 8/16?

Regards,
Matthias

Re: [PATCH v2 14/16] arm64: dts: mt7622: add thermal and related nodes

2018-02-07 Thread Matthias Brugger 


On 02/06/2018 10:53 AM, sean.w...@mediatek.com wrote:
> From: Sean Wang 
> 
> add nodes for the thermal controller and associated thermal zone using
> CPU as the cooling device for each trip point. In addition, add a fixup
> for thermal_calibration on nvmem should be 12 bytes as the minimal
> requirement.
> 
> Signed-off-by: Sean Wang 
> ---
>  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72 
> +++-
>  1 file changed, 71 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index e6dd4f6..6cf67dd 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -12,6 +12,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  / {
>   compatible = "mediatek,mt7622";
> @@ -75,6 +76,7 @@
>< CLK_APMIXED_MAIN_CORE_EN>;
>   clock-names = "cpu", "intermediate";
>   operating-points-v2 = <_opp_table>;
> + #cooling-cells = <2>;
>   enable-method = "psci";
>   clock-frequency = <13>;
>   };
> @@ -119,6 +121,58 @@
>   };
>   };
>  
> + thermal-zones {
> + cpu_thermal: cpu-thermal {
> + polling-delay-passive = <1000>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 0>;
> +
> + trips {
> + cpu_passive: cpu-passive {
> + temperature = <47000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_active: cpu-active {
> + temperature = <67000>;
> + hysteresis = <2000>;
> + type = "active";
> + };
> +
> + cpu_hot: cpu-hot {
> + temperature = <87000>;
> + hysteresis = <2000>;
> + type = "hot";
> + };
> +
> + cpu-crit {
> + temperature = <107000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <_passive>;
> + cooling-device = < 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> +
> + map1 {
> + trip = <_active>;
> + cooling-device = < 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> +
> + map2 {
> + trip = <_hot>;
> + cooling-device = < 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> + };
> +
>   timer {
>   compatible = "arm,armv8-timer";
>   interrupt-parent = <>;
> @@ -201,7 +255,7 @@
>   #size-cells = <1>;
>  
>   thermal_calibration: calib@198 {
> - reg = <0x198 0x8>;
> + reg = <0x198 0xc>;

Any reason why this is not part of patch 8/16?

Regards,
Matthias