Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Simon Horman]

On Fri, Feb 23, 2018 at 08:06:11AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Feb 22, 2018 at 4:54 PM, Simon Horman  wrote:
> > On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote:
> >> On 02/21/2018 09:23 PM, Simon Horman wrote:
> >>
> >> > ...
> >> >
> >>  +clocks = < CPG_MOD 812>;
> >>  +power-domains = < 32>;
> >>  +resets = < 812>;
> >>  +phy-mode = "rgmii-txid";
> >> >>>
> >> >>>Why not just "rgmii"? TX delay is a board specific detail, no?
> >> >>>
> >> >> I admit I took this one straight from r8a7796 dtsi.
> >> >> Would you like to me resend and change this?
> >> >
> >> >Yes, unless Simon would fix it while merging...
> >> 
> >>  Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> >> >>>
> >> >>>Yes.
> >> >>
> >> >>Apparently that means that this prop should be overridden in the 
> >> >> board file
> >> >> (which may not be an easy task given the board is Salvator-XS again).
> >> >>
> >> >> [...]
> >> >
> >> > Can we override it in r8a77965-salvator-x.dts or 
> >> > r8a77965-salvator-xs.dts?
> >>
> >>In salvator-common.dtsi most probably -- it has the PHY data for Ether 
> >> AVB.
> >>
> >> > I feel that I'm missing an important point here.
> >>
> >>Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
> >>unjustified in my current understanding). Thus such board override
> >>wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
> >>in htis series, so I'm now thinking a respin of this series is needed
> >>anyway... sorry for being unclear. :-)
> >
> > While I've applied other patches in this series I have
> > not applied this one - mainly to allow this discussion to conclude.
> >
> > Is an appropriate solution to do the following?
> >
> > 1) Atomically update
> >a) r8a779{5|6}.dtsi to use "rgmii" and
> >b) salvator-common.dtsi to use "rgmii-txid"
> > 2) Update this patch to use "rgmii"
> 
> No need for atomics.
> It can all be done by patches touching single files only:
>   1) Add "rgmii-txid" to board .dts(i) files,
>   2) Change s/rgmii-txid/rgmii/ in SoC .dtsi files.

Sounds good.

Jacopo would you care to:

a) Implement the above rgmii-txid / rgmii update.
b) Rebase this patch on top of that update and [PATCH v2 0/7] R-Car M3-N
   DTS fixes

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Simon Horman]

On Fri, Feb 23, 2018 at 08:06:11AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Feb 22, 2018 at 4:54 PM, Simon Horman  wrote:
> > On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote:
> >> On 02/21/2018 09:23 PM, Simon Horman wrote:
> >>
> >> > ...
> >> >
> >>  +clocks = < CPG_MOD 812>;
> >>  +power-domains = < 32>;
> >>  +resets = < 812>;
> >>  +phy-mode = "rgmii-txid";
> >> >>>
> >> >>>Why not just "rgmii"? TX delay is a board specific detail, no?
> >> >>>
> >> >> I admit I took this one straight from r8a7796 dtsi.
> >> >> Would you like to me resend and change this?
> >> >
> >> >Yes, unless Simon would fix it while merging...
> >> 
> >>  Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> >> >>>
> >> >>>Yes.
> >> >>
> >> >>Apparently that means that this prop should be overridden in the 
> >> >> board file
> >> >> (which may not be an easy task given the board is Salvator-XS again).
> >> >>
> >> >> [...]
> >> >
> >> > Can we override it in r8a77965-salvator-x.dts or 
> >> > r8a77965-salvator-xs.dts?
> >>
> >>In salvator-common.dtsi most probably -- it has the PHY data for Ether 
> >> AVB.
> >>
> >> > I feel that I'm missing an important point here.
> >>
> >>Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
> >>unjustified in my current understanding). Thus such board override
> >>wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
> >>in htis series, so I'm now thinking a respin of this series is needed
> >>anyway... sorry for being unclear. :-)
> >
> > While I've applied other patches in this series I have
> > not applied this one - mainly to allow this discussion to conclude.
> >
> > Is an appropriate solution to do the following?
> >
> > 1) Atomically update
> >a) r8a779{5|6}.dtsi to use "rgmii" and
> >b) salvator-common.dtsi to use "rgmii-txid"
> > 2) Update this patch to use "rgmii"
> 
> No need for atomics.
> It can all be done by patches touching single files only:
>   1) Add "rgmii-txid" to board .dts(i) files,
>   2) Change s/rgmii-txid/rgmii/ in SoC .dtsi files.

Sounds good.

Jacopo would you care to:

a) Implement the above rgmii-txid / rgmii update.
b) Rebase this patch on top of that update and [PATCH v2 0/7] R-Car M3-N
   DTS fixes

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Geert Uytterhoeven]

Hi Simon,

On Thu, Feb 22, 2018 at 4:54 PM, Simon Horman  wrote:
> On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote:
>> On 02/21/2018 09:23 PM, Simon Horman wrote:
>>
>> > ...
>> >
>>  +clocks = < CPG_MOD 812>;
>>  +power-domains = < 32>;
>>  +resets = < 812>;
>>  +phy-mode = "rgmii-txid";
>> >>>
>> >>>Why not just "rgmii"? TX delay is a board specific detail, no?
>> >>>
>> >> I admit I took this one straight from r8a7796 dtsi.
>> >> Would you like to me resend and change this?
>> >
>> >Yes, unless Simon would fix it while merging...
>> 
>>  Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
>> >>>
>> >>>Yes.
>> >>
>> >>Apparently that means that this prop should be overridden in the board 
>> >> file
>> >> (which may not be an easy task given the board is Salvator-XS again).
>> >>
>> >> [...]
>> >
>> > Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
>>
>>In salvator-common.dtsi most probably -- it has the PHY data for Ether 
>> AVB.
>>
>> > I feel that I'm missing an important point here.
>>
>>Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
>>unjustified in my current understanding). Thus such board override
>>wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
>>in htis series, so I'm now thinking a respin of this series is needed
>>anyway... sorry for being unclear. :-)
>
> While I've applied other patches in this series I have
> not applied this one - mainly to allow this discussion to conclude.
>
> Is an appropriate solution to do the following?
>
> 1) Atomically update
>a) r8a779{5|6}.dtsi to use "rgmii" and
>b) salvator-common.dtsi to use "rgmii-txid"
> 2) Update this patch to use "rgmii"

No need for atomics.
It can all be done by patches touching single files only:
  1) Add "rgmii-txid" to board .dts(i) files,
  2) Change s/rgmii-txid/rgmii/ in SoC .dtsi files.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Geert Uytterhoeven]

Hi Simon,

On Thu, Feb 22, 2018 at 4:54 PM, Simon Horman  wrote:
> On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote:
>> On 02/21/2018 09:23 PM, Simon Horman wrote:
>>
>> > ...
>> >
>>  +clocks = < CPG_MOD 812>;
>>  +power-domains = < 32>;
>>  +resets = < 812>;
>>  +phy-mode = "rgmii-txid";
>> >>>
>> >>>Why not just "rgmii"? TX delay is a board specific detail, no?
>> >>>
>> >> I admit I took this one straight from r8a7796 dtsi.
>> >> Would you like to me resend and change this?
>> >
>> >Yes, unless Simon would fix it while merging...
>> 
>>  Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
>> >>>
>> >>>Yes.
>> >>
>> >>Apparently that means that this prop should be overridden in the board 
>> >> file
>> >> (which may not be an easy task given the board is Salvator-XS again).
>> >>
>> >> [...]
>> >
>> > Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
>>
>>In salvator-common.dtsi most probably -- it has the PHY data for Ether 
>> AVB.
>>
>> > I feel that I'm missing an important point here.
>>
>>Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
>>unjustified in my current understanding). Thus such board override
>>wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
>>in htis series, so I'm now thinking a respin of this series is needed
>>anyway... sorry for being unclear. :-)
>
> While I've applied other patches in this series I have
> not applied this one - mainly to allow this discussion to conclude.
>
> Is an appropriate solution to do the following?
>
> 1) Atomically update
>a) r8a779{5|6}.dtsi to use "rgmii" and
>b) salvator-common.dtsi to use "rgmii-txid"
> 2) Update this patch to use "rgmii"

No need for atomics.
It can all be done by patches touching single files only:
  1) Add "rgmii-txid" to board .dts(i) files,
  2) Change s/rgmii-txid/rgmii/ in SoC .dtsi files.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

Hello!

On 02/22/2018 06:54 PM, Simon Horman wrote:

>>> ...
>>>
>> +clocks = < CPG_MOD 812>;
>> +power-domains = < 32>;
>> +resets = < 812>;
>> +phy-mode = "rgmii-txid";
>
>Why not just "rgmii"? TX delay is a board specific detail, no?
>
 I admit I took this one straight from r8a7796 dtsi.
 Would you like to me resend and change this?
>>>
>>>Yes, unless Simon would fix it while merging...
>>
>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
>
>Yes.

Apparently that means that this prop should be overridden in the board 
 file
 (which may not be an easy task given the board is Salvator-XS again).

 [...]
>>>
>>> Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
>>
>>In salvator-common.dtsi most probably -- it has the PHY data for Ether 
>> AVB.
>>
>>> I feel that I'm missing an important point here.
>>
>>Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
>>unjustified in my current understanding). Thus such board override
>>wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
>>in htis series, so I'm now thinking a respin of this series is needed
>>anyway... sorry for being unclear. :-)
> 
> While I've applied other patches in this series I have
> not applied this one - mainly to allow this discussion to conclude.
> 
> Is an appropriate solution to do the following?
> 
> 1) Atomically update
>a) r8a779{5|6}.dtsi to use "rgmii" and
>b) salvator-common.dtsi to use "rgmii-txid"
> 2) Update this patch to use "rgmii"

   Yeah, I was thinking about doing exactly this...

> Sorry if I'm still missing the point.

   I was referring to what the 2nd paragraph of [1] said about the internal 
delays
(perhaps I just misunderstood it)...

[1] 
https://en.wikipedia.org/wiki/Media-independent_interface#Reduced_gigabit_media-independent_interface

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

Hello!

On 02/22/2018 06:54 PM, Simon Horman wrote:

>>> ...
>>>
>> +clocks = < CPG_MOD 812>;
>> +power-domains = < 32>;
>> +resets = < 812>;
>> +phy-mode = "rgmii-txid";
>
>Why not just "rgmii"? TX delay is a board specific detail, no?
>
 I admit I took this one straight from r8a7796 dtsi.
 Would you like to me resend and change this?
>>>
>>>Yes, unless Simon would fix it while merging...
>>
>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
>
>Yes.

Apparently that means that this prop should be overridden in the board 
 file
 (which may not be an easy task given the board is Salvator-XS again).

 [...]
>>>
>>> Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
>>
>>In salvator-common.dtsi most probably -- it has the PHY data for Ether 
>> AVB.
>>
>>> I feel that I'm missing an important point here.
>>
>>Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
>>unjustified in my current understanding). Thus such board override
>>wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
>>in htis series, so I'm now thinking a respin of this series is needed
>>anyway... sorry for being unclear. :-)
> 
> While I've applied other patches in this series I have
> not applied this one - mainly to allow this discussion to conclude.
> 
> Is an appropriate solution to do the following?
> 
> 1) Atomically update
>a) r8a779{5|6}.dtsi to use "rgmii" and
>b) salvator-common.dtsi to use "rgmii-txid"
> 2) Update this patch to use "rgmii"

   Yeah, I was thinking about doing exactly this...

> Sorry if I'm still missing the point.

   I was referring to what the 2nd paragraph of [1] said about the internal 
delays
(perhaps I just misunderstood it)...

[1] 
https://en.wikipedia.org/wiki/Media-independent_interface#Reduced_gigabit_media-independent_interface

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Simon Horman]

On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote:
> On 02/21/2018 09:23 PM, Simon Horman wrote:
> 
> > ...
> > 
>  +clocks = < CPG_MOD 812>;
>  +power-domains = < 32>;
>  +resets = < 812>;
>  +phy-mode = "rgmii-txid";
> >>>
> >>>Why not just "rgmii"? TX delay is a board specific detail, no?
> >>>
> >> I admit I took this one straight from r8a7796 dtsi.
> >> Would you like to me resend and change this?
> >
> >Yes, unless Simon would fix it while merging...
> 
>  Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> >>>
> >>>Yes.
> >>
> >>Apparently that means that this prop should be overridden in the board 
> >> file
> >> (which may not be an easy task given the board is Salvator-XS again).
> >>
> >> [...]
> > 
> > Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
> 
>In salvator-common.dtsi most probably -- it has the PHY data for Ether AVB.
> 
> > I feel that I'm missing an important point here.
> 
>Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
>unjustified in my current understanding). Thus such board override
>wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
>in htis series, so I'm now thinking a respin of this series is needed
>anyway... sorry for being unclear. :-)

While I've applied other patches in this series I have
not applied this one - mainly to allow this discussion to conclude.

Is an appropriate solution to do the following?

1) Atomically update
   a) r8a779{5|6}.dtsi to use "rgmii" and
   b) salvator-common.dtsi to use "rgmii-txid"
2) Update this patch to use "rgmii"

Sorry if I'm still missing the point.

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Simon Horman]

On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote:
> On 02/21/2018 09:23 PM, Simon Horman wrote:
> 
> > ...
> > 
>  +clocks = < CPG_MOD 812>;
>  +power-domains = < 32>;
>  +resets = < 812>;
>  +phy-mode = "rgmii-txid";
> >>>
> >>>Why not just "rgmii"? TX delay is a board specific detail, no?
> >>>
> >> I admit I took this one straight from r8a7796 dtsi.
> >> Would you like to me resend and change this?
> >
> >Yes, unless Simon would fix it while merging...
> 
>  Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> >>>
> >>>Yes.
> >>
> >>Apparently that means that this prop should be overridden in the board 
> >> file
> >> (which may not be an easy task given the board is Salvator-XS again).
> >>
> >> [...]
> > 
> > Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
> 
>In salvator-common.dtsi most probably -- it has the PHY data for Ether AVB.
> 
> > I feel that I'm missing an important point here.
> 
>Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
>unjustified in my current understanding). Thus such board override
>wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
>in htis series, so I'm now thinking a respin of this series is needed
>anyway... sorry for being unclear. :-)

While I've applied other patches in this series I have
not applied this one - mainly to allow this discussion to conclude.

Is an appropriate solution to do the following?

1) Atomically update
   a) r8a779{5|6}.dtsi to use "rgmii" and
   b) salvator-common.dtsi to use "rgmii-txid"
2) Update this patch to use "rgmii"

Sorry if I'm still missing the point.

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Simon Horman]

On Wed, Feb 21, 2018 at 08:53:53PM +0300, Sergei Shtylyov wrote:
> On 02/21/2018 08:38 PM, Sergei Shtylyov wrote:

...

> >> +  clocks = < CPG_MOD 812>;
> >> +  power-domains = < 32>;
> >> +  resets = < 812>;
> >> +  phy-mode = "rgmii-txid";
> >
> >Why not just "rgmii"? TX delay is a board specific detail, no?
> >
>  I admit I took this one straight from r8a7796 dtsi.
>  Would you like to me resend and change this?
> >>>
> >>>Yes, unless Simon would fix it while merging...
> >>
> >> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> > 
> >Yes.
> 
>Apparently that means that this prop should be overridden in the board file
> (which may not be an easy task given the board is Salvator-XS again).
> 
> [...]

Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?

I feel that I'm missing an important point here.

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Simon Horman]

On Wed, Feb 21, 2018 at 08:53:53PM +0300, Sergei Shtylyov wrote:
> On 02/21/2018 08:38 PM, Sergei Shtylyov wrote:

...

> >> +  clocks = < CPG_MOD 812>;
> >> +  power-domains = < 32>;
> >> +  resets = < 812>;
> >> +  phy-mode = "rgmii-txid";
> >
> >Why not just "rgmii"? TX delay is a board specific detail, no?
> >
>  I admit I took this one straight from r8a7796 dtsi.
>  Would you like to me resend and change this?
> >>>
> >>>Yes, unless Simon would fix it while merging...
> >>
> >> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> > 
> >Yes.
> 
>Apparently that means that this prop should be overridden in the board file
> (which may not be an easy task given the board is Salvator-XS again).
> 
> [...]

Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?

I feel that I'm missing an important point here.

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

On 02/21/2018 09:23 PM, Simon Horman wrote:

> ...
> 
 +  clocks = < CPG_MOD 812>;
 +  power-domains = < 32>;
 +  resets = < 812>;
 +  phy-mode = "rgmii-txid";
>>>
>>>Why not just "rgmii"? TX delay is a board specific detail, no?
>>>
>> I admit I took this one straight from r8a7796 dtsi.
>> Would you like to me resend and change this?
>
>Yes, unless Simon would fix it while merging...

 Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
>>>
>>>Yes.
>>
>>Apparently that means that this prop should be overridden in the board 
>> file
>> (which may not be an easy task given the board is Salvator-XS again).
>>
>> [...]
> 
> Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?

   In salvator-common.dtsi most probably -- it has the PHY data for Ether AVB.

> I feel that I'm missing an important point here.

   Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was 
unjustified
in my current understanding). Thus such board override wouldn't hurt them. But 
we lack
a patch modifying salvator-common.dtsi in htis series, so I'm now thinking a 
respin of
this series is needed anyway... sorry for being unclear. :-)

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

On 02/21/2018 09:23 PM, Simon Horman wrote:

> ...
> 
 +  clocks = < CPG_MOD 812>;
 +  power-domains = < 32>;
 +  resets = < 812>;
 +  phy-mode = "rgmii-txid";
>>>
>>>Why not just "rgmii"? TX delay is a board specific detail, no?
>>>
>> I admit I took this one straight from r8a7796 dtsi.
>> Would you like to me resend and change this?
>
>Yes, unless Simon would fix it while merging...

 Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
>>>
>>>Yes.
>>
>>Apparently that means that this prop should be overridden in the board 
>> file
>> (which may not be an easy task given the board is Salvator-XS again).
>>
>> [...]
> 
> Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?

   In salvator-common.dtsi most probably -- it has the PHY data for Ether AVB.

> I feel that I'm missing an important point here.

   Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was 
unjustified
in my current understanding). Thus such board override wouldn't hurt them. But 
we lack
a patch modifying salvator-common.dtsi in htis series, so I'm now thinking a 
respin of
this series is needed anyway... sorry for being unclear. :-)

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

On 02/21/2018 08:38 PM, Sergei Shtylyov wrote:

>> Populate the ethernet@e680 device node to enable Ethernet interface
>> for R-Car M3-N (r8a77965) SoC.
>>
>> Signed-off-by: Jacopo Mondi 
>> Reviewed-by: Geert Uytterhoeven 
>>
>> ---
>> v1 -> v2:
>> - Replace ALWAYS_ON power area identifier with numeric constant
>> ---
>>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
>> ++-
>>  1 file changed, 42 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> index 55f05f7..c249895 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -520,7 +520,48 @@
>>  };
>>
>>  avb: ethernet@e680 {
>> -/* placeholder */
>> +compatible = "renesas,etheravb-r8a77965",
>> + "renesas,etheravb-rcar-gen3";
>> +reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 
>> 0x1>;
>> +interrupts = ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ;
>> +interrupt-names = "ch0", "ch1", "ch2", "ch3",
>> +  "ch4", "ch5", "ch6", "ch7",
>> +  "ch8", "ch9", "ch10", "ch11",
>> +  "ch12", "ch13", "ch14", 
>> "ch15",
>> +  "ch16", "ch17", "ch18", 
>> "ch19",
>> +  "ch20", "ch21", "ch22", 
>> "ch23",
>> +  "ch24";
>> +clocks = < CPG_MOD 812>;
>> +power-domains = < 32>;
>> +resets = < 812>;
>> +phy-mode = "rgmii-txid";
>
>Why not just "rgmii"? TX delay is a board specific detail, no?
>
 I admit I took this one straight from r8a7796 dtsi.
 Would you like to me resend and change this?
>>>
>>>Yes, unless Simon would fix it while merging...
>>
>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> 
>Yes.

   Apparently that means that this prop should be overridden in the board file
(which may not be an easy task given the board is Salvator-XS again).

[...]

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

On 02/21/2018 08:38 PM, Sergei Shtylyov wrote:

>> Populate the ethernet@e680 device node to enable Ethernet interface
>> for R-Car M3-N (r8a77965) SoC.
>>
>> Signed-off-by: Jacopo Mondi 
>> Reviewed-by: Geert Uytterhoeven 
>>
>> ---
>> v1 -> v2:
>> - Replace ALWAYS_ON power area identifier with numeric constant
>> ---
>>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
>> ++-
>>  1 file changed, 42 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> index 55f05f7..c249895 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -520,7 +520,48 @@
>>  };
>>
>>  avb: ethernet@e680 {
>> -/* placeholder */
>> +compatible = "renesas,etheravb-r8a77965",
>> + "renesas,etheravb-rcar-gen3";
>> +reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 
>> 0x1>;
>> +interrupts = ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ,
>> + ;
>> +interrupt-names = "ch0", "ch1", "ch2", "ch3",
>> +  "ch4", "ch5", "ch6", "ch7",
>> +  "ch8", "ch9", "ch10", "ch11",
>> +  "ch12", "ch13", "ch14", 
>> "ch15",
>> +  "ch16", "ch17", "ch18", 
>> "ch19",
>> +  "ch20", "ch21", "ch22", 
>> "ch23",
>> +  "ch24";
>> +clocks = < CPG_MOD 812>;
>> +power-domains = < 32>;
>> +resets = < 812>;
>> +phy-mode = "rgmii-txid";
>
>Why not just "rgmii"? TX delay is a board specific detail, no?
>
 I admit I took this one straight from r8a7796 dtsi.
 Would you like to me resend and change this?
>>>
>>>Yes, unless Simon would fix it while merging...
>>
>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> 
>Yes.

   Apparently that means that this prop should be overridden in the board file
(which may not be an easy task given the board is Salvator-XS again).

[...]

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

On 02/21/2018 08:31 PM, Simon Horman wrote:

> Populate the ethernet@e680 device node to enable Ethernet interface
> for R-Car M3-N (r8a77965) SoC.
>
> Signed-off-by: Jacopo Mondi 
> Reviewed-by: Geert Uytterhoeven 
>
> ---
> v1 -> v2:
> - Replace ALWAYS_ON power area identifier with numeric constant
> ---
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
> ++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 55f05f7..c249895 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -520,7 +520,48 @@
>   };
>
>   avb: ethernet@e680 {
> - /* placeholder */
> + compatible = "renesas,etheravb-r8a77965",
> +  "renesas,etheravb-rcar-gen3";
> + reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
> + interrupts = ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ;
> + interrupt-names = "ch0", "ch1", "ch2", "ch3",
> +   "ch4", "ch5", "ch6", "ch7",
> +   "ch8", "ch9", "ch10", "ch11",
> +   "ch12", "ch13", "ch14", "ch15",
> +   "ch16", "ch17", "ch18", "ch19",
> +   "ch20", "ch21", "ch22", "ch23",
> +   "ch24";
> + clocks = < CPG_MOD 812>;
> + power-domains = < 32>;
> + resets = < 812>;
> + phy-mode = "rgmii-txid";

Why not just "rgmii"? TX delay is a board specific detail, no?

>>> I admit I took this one straight from r8a7796 dtsi.
>>> Would you like to me resend and change this?
>>
>>Yes, unless Simon would fix it while merging...
> 
> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?

   Yes.

> If so I can fix that up.
 
   Thank you!

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

On 02/21/2018 08:31 PM, Simon Horman wrote:

> Populate the ethernet@e680 device node to enable Ethernet interface
> for R-Car M3-N (r8a77965) SoC.
>
> Signed-off-by: Jacopo Mondi 
> Reviewed-by: Geert Uytterhoeven 
>
> ---
> v1 -> v2:
> - Replace ALWAYS_ON power area identifier with numeric constant
> ---
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
> ++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 55f05f7..c249895 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -520,7 +520,48 @@
>   };
>
>   avb: ethernet@e680 {
> - /* placeholder */
> + compatible = "renesas,etheravb-r8a77965",
> +  "renesas,etheravb-rcar-gen3";
> + reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
> + interrupts = ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ;
> + interrupt-names = "ch0", "ch1", "ch2", "ch3",
> +   "ch4", "ch5", "ch6", "ch7",
> +   "ch8", "ch9", "ch10", "ch11",
> +   "ch12", "ch13", "ch14", "ch15",
> +   "ch16", "ch17", "ch18", "ch19",
> +   "ch20", "ch21", "ch22", "ch23",
> +   "ch24";
> + clocks = < CPG_MOD 812>;
> + power-domains = < 32>;
> + resets = < 812>;
> + phy-mode = "rgmii-txid";

Why not just "rgmii"? TX delay is a board specific detail, no?

>>> I admit I took this one straight from r8a7796 dtsi.
>>> Would you like to me resend and change this?
>>
>>Yes, unless Simon would fix it while merging...
> 
> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?

   Yes.

> If so I can fix that up.
 
   Thank you!

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Simon Horman]

On Wed, Feb 21, 2018 at 06:48:59PM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 02/21/2018 01:07 PM, jacopo mondi wrote:
> 
> >>> Populate the ethernet@e680 device node to enable Ethernet interface
> >>> for R-Car M3-N (r8a77965) SoC.
> >>>
> >>> Signed-off-by: Jacopo Mondi 
> >>> Reviewed-by: Geert Uytterhoeven 
> >>>
> >>> ---
> >>> v1 -> v2:
> >>> - Replace ALWAYS_ON power area identifier with numeric constant
> >>> ---
> >>>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
> >>> ++-
> >>>  1 file changed, 42 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> >>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> >>> index 55f05f7..c249895 100644
> >>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> >>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> >>> @@ -520,7 +520,48 @@
> >>>   };
> >>>
> >>>   avb: ethernet@e680 {
> >>> - /* placeholder */
> >>> + compatible = "renesas,etheravb-r8a77965",
> >>> +  "renesas,etheravb-rcar-gen3";
> >>> + reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
> >>> + interrupts = ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ;
> >>> + interrupt-names = "ch0", "ch1", "ch2", "ch3",
> >>> +   "ch4", "ch5", "ch6", "ch7",
> >>> +   "ch8", "ch9", "ch10", "ch11",
> >>> +   "ch12", "ch13", "ch14", "ch15",
> >>> +   "ch16", "ch17", "ch18", "ch19",
> >>> +   "ch20", "ch21", "ch22", "ch23",
> >>> +   "ch24";
> >>> + clocks = < CPG_MOD 812>;
> >>> + power-domains = < 32>;
> >>> + resets = < 812>;
> >>> + phy-mode = "rgmii-txid";
> >>
> >>Why not just "rgmii"? TX delay is a board specific detail, no?
> >>
> > 
> > I admit I took this one straight from r8a7796 dtsi.
> > Would you like to me resend and change this?
> 
>Yes, unless Simon would fix it while merging...

Can I confirm the desired change is s/rgmii-txid/rgmii/ ?

If so I can fix that up.

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Simon Horman]

On Wed, Feb 21, 2018 at 06:48:59PM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 02/21/2018 01:07 PM, jacopo mondi wrote:
> 
> >>> Populate the ethernet@e680 device node to enable Ethernet interface
> >>> for R-Car M3-N (r8a77965) SoC.
> >>>
> >>> Signed-off-by: Jacopo Mondi 
> >>> Reviewed-by: Geert Uytterhoeven 
> >>>
> >>> ---
> >>> v1 -> v2:
> >>> - Replace ALWAYS_ON power area identifier with numeric constant
> >>> ---
> >>>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
> >>> ++-
> >>>  1 file changed, 42 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> >>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> >>> index 55f05f7..c249895 100644
> >>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> >>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> >>> @@ -520,7 +520,48 @@
> >>>   };
> >>>
> >>>   avb: ethernet@e680 {
> >>> - /* placeholder */
> >>> + compatible = "renesas,etheravb-r8a77965",
> >>> +  "renesas,etheravb-rcar-gen3";
> >>> + reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
> >>> + interrupts = ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ,
> >>> +  ;
> >>> + interrupt-names = "ch0", "ch1", "ch2", "ch3",
> >>> +   "ch4", "ch5", "ch6", "ch7",
> >>> +   "ch8", "ch9", "ch10", "ch11",
> >>> +   "ch12", "ch13", "ch14", "ch15",
> >>> +   "ch16", "ch17", "ch18", "ch19",
> >>> +   "ch20", "ch21", "ch22", "ch23",
> >>> +   "ch24";
> >>> + clocks = < CPG_MOD 812>;
> >>> + power-domains = < 32>;
> >>> + resets = < 812>;
> >>> + phy-mode = "rgmii-txid";
> >>
> >>Why not just "rgmii"? TX delay is a board specific detail, no?
> >>
> > 
> > I admit I took this one straight from r8a7796 dtsi.
> > Would you like to me resend and change this?
> 
>Yes, unless Simon would fix it while merging...

Can I confirm the desired change is s/rgmii-txid/rgmii/ ?

If so I can fix that up.

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

Hello!

On 02/21/2018 01:07 PM, jacopo mondi wrote:

>>> Populate the ethernet@e680 device node to enable Ethernet interface
>>> for R-Car M3-N (r8a77965) SoC.
>>>
>>> Signed-off-by: Jacopo Mondi 
>>> Reviewed-by: Geert Uytterhoeven 
>>>
>>> ---
>>> v1 -> v2:
>>> - Replace ALWAYS_ON power area identifier with numeric constant
>>> ---
>>>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
>>> ++-
>>>  1 file changed, 42 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
>>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>> index 55f05f7..c249895 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>> @@ -520,7 +520,48 @@
>>> };
>>>
>>> avb: ethernet@e680 {
>>> -   /* placeholder */
>>> +   compatible = "renesas,etheravb-r8a77965",
>>> +"renesas,etheravb-rcar-gen3";
>>> +   reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
>>> +   interrupts = ,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +;
>>> +   interrupt-names = "ch0", "ch1", "ch2", "ch3",
>>> + "ch4", "ch5", "ch6", "ch7",
>>> + "ch8", "ch9", "ch10", "ch11",
>>> + "ch12", "ch13", "ch14", "ch15",
>>> + "ch16", "ch17", "ch18", "ch19",
>>> + "ch20", "ch21", "ch22", "ch23",
>>> + "ch24";
>>> +   clocks = < CPG_MOD 812>;
>>> +   power-domains = < 32>;
>>> +   resets = < 812>;
>>> +   phy-mode = "rgmii-txid";
>>
>>Why not just "rgmii"? TX delay is a board specific detail, no?
>>
> 
> I admit I took this one straight from r8a7796 dtsi.
> Would you like to me resend and change this?

   Yes, unless Simon would fix it while merging...

> Thanks
>j
> 
>>> +   #address-cells = <1>;
>>> +   #size-cells = <0>;
>>> +   status = "disabled";
>>> };
>>>
>>> csi20: csi2@fea8 {

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

Hello!

On 02/21/2018 01:07 PM, jacopo mondi wrote:

>>> Populate the ethernet@e680 device node to enable Ethernet interface
>>> for R-Car M3-N (r8a77965) SoC.
>>>
>>> Signed-off-by: Jacopo Mondi 
>>> Reviewed-by: Geert Uytterhoeven 
>>>
>>> ---
>>> v1 -> v2:
>>> - Replace ALWAYS_ON power area identifier with numeric constant
>>> ---
>>>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
>>> ++-
>>>  1 file changed, 42 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
>>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>> index 55f05f7..c249895 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>> @@ -520,7 +520,48 @@
>>> };
>>>
>>> avb: ethernet@e680 {
>>> -   /* placeholder */
>>> +   compatible = "renesas,etheravb-r8a77965",
>>> +"renesas,etheravb-rcar-gen3";
>>> +   reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
>>> +   interrupts = ,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +,
>>> +;
>>> +   interrupt-names = "ch0", "ch1", "ch2", "ch3",
>>> + "ch4", "ch5", "ch6", "ch7",
>>> + "ch8", "ch9", "ch10", "ch11",
>>> + "ch12", "ch13", "ch14", "ch15",
>>> + "ch16", "ch17", "ch18", "ch19",
>>> + "ch20", "ch21", "ch22", "ch23",
>>> + "ch24";
>>> +   clocks = < CPG_MOD 812>;
>>> +   power-domains = < 32>;
>>> +   resets = < 812>;
>>> +   phy-mode = "rgmii-txid";
>>
>>Why not just "rgmii"? TX delay is a board specific detail, no?
>>
> 
> I admit I took this one straight from r8a7796 dtsi.
> Would you like to me resend and change this?

   Yes, unless Simon would fix it while merging...

> Thanks
>j
> 
>>> +   #address-cells = <1>;
>>> +   #size-cells = <0>;
>>> +   status = "disabled";
>>> };
>>>
>>> csi20: csi2@fea8 {

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[jacopo mondi]

Hi Sergei,

On Tue, Feb 20, 2018 at 06:30:56PM +0300, Sergei Shtylyov wrote:
> On 02/20/2018 06:12 PM, Jacopo Mondi wrote:
>
> > Populate the ethernet@e680 device node to enable Ethernet interface
> > for R-Car M3-N (r8a77965) SoC.
> >
> > Signed-off-by: Jacopo Mondi 
> > Reviewed-by: Geert Uytterhoeven 
> >
> > ---
> > v1 -> v2:
> > - Replace ALWAYS_ON power area identifier with numeric constant
> > ---
> >  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
> > ++-
> >  1 file changed, 42 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> > b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > index 55f05f7..c249895 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > @@ -520,7 +520,48 @@
> > };
> >
> > avb: ethernet@e680 {
> > -   /* placeholder */
> > +   compatible = "renesas,etheravb-r8a77965",
> > +"renesas,etheravb-rcar-gen3";
> > +   reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
> > +   interrupts = ,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +;
> > +   interrupt-names = "ch0", "ch1", "ch2", "ch3",
> > + "ch4", "ch5", "ch6", "ch7",
> > + "ch8", "ch9", "ch10", "ch11",
> > + "ch12", "ch13", "ch14", "ch15",
> > + "ch16", "ch17", "ch18", "ch19",
> > + "ch20", "ch21", "ch22", "ch23",
> > + "ch24";
> > +   clocks = < CPG_MOD 812>;
> > +   power-domains = < 32>;
> > +   resets = < 812>;
> > +   phy-mode = "rgmii-txid";
>
>Why not just "rgmii"? TX delay is a board specific detail, no?
>

I admit I took this one straight from r8a7796 dtsi.
Would you like to me resend and change this?

Thanks
   j

> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +   status = "disabled";
> > };
> >
> > csi20: csi2@fea8 {
> >
>
> MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[jacopo mondi]

Hi Sergei,

On Tue, Feb 20, 2018 at 06:30:56PM +0300, Sergei Shtylyov wrote:
> On 02/20/2018 06:12 PM, Jacopo Mondi wrote:
>
> > Populate the ethernet@e680 device node to enable Ethernet interface
> > for R-Car M3-N (r8a77965) SoC.
> >
> > Signed-off-by: Jacopo Mondi 
> > Reviewed-by: Geert Uytterhoeven 
> >
> > ---
> > v1 -> v2:
> > - Replace ALWAYS_ON power area identifier with numeric constant
> > ---
> >  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
> > ++-
> >  1 file changed, 42 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> > b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > index 55f05f7..c249895 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > @@ -520,7 +520,48 @@
> > };
> >
> > avb: ethernet@e680 {
> > -   /* placeholder */
> > +   compatible = "renesas,etheravb-r8a77965",
> > +"renesas,etheravb-rcar-gen3";
> > +   reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
> > +   interrupts = ,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +,
> > +;
> > +   interrupt-names = "ch0", "ch1", "ch2", "ch3",
> > + "ch4", "ch5", "ch6", "ch7",
> > + "ch8", "ch9", "ch10", "ch11",
> > + "ch12", "ch13", "ch14", "ch15",
> > + "ch16", "ch17", "ch18", "ch19",
> > + "ch20", "ch21", "ch22", "ch23",
> > + "ch24";
> > +   clocks = < CPG_MOD 812>;
> > +   power-domains = < 32>;
> > +   resets = < 812>;
> > +   phy-mode = "rgmii-txid";
>
>Why not just "rgmii"? TX delay is a board specific detail, no?
>

I admit I took this one straight from r8a7796 dtsi.
Would you like to me resend and change this?

Thanks
   j

> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +   status = "disabled";
> > };
> >
> > csi20: csi2@fea8 {
> >
>
> MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

On 02/20/2018 06:12 PM, Jacopo Mondi wrote:

> Populate the ethernet@e680 device node to enable Ethernet interface
> for R-Car M3-N (r8a77965) SoC.
> 
> Signed-off-by: Jacopo Mondi 
> Reviewed-by: Geert Uytterhoeven 
> 
> ---
> v1 -> v2:
> - Replace ALWAYS_ON power area identifier with numeric constant
> ---
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
> ++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 55f05f7..c249895 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -520,7 +520,48 @@
>   };
>  
>   avb: ethernet@e680 {
> - /* placeholder */
> + compatible = "renesas,etheravb-r8a77965",
> +  "renesas,etheravb-rcar-gen3";
> + reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
> + interrupts = ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ;
> + interrupt-names = "ch0", "ch1", "ch2", "ch3",
> +   "ch4", "ch5", "ch6", "ch7",
> +   "ch8", "ch9", "ch10", "ch11",
> +   "ch12", "ch13", "ch14", "ch15",
> +   "ch16", "ch17", "ch18", "ch19",
> +   "ch20", "ch21", "ch22", "ch23",
> +   "ch24";
> + clocks = < CPG_MOD 812>;
> + power-domains = < 32>;
> + resets = < 812>;
> + phy-mode = "rgmii-txid";

   Why not just "rgmii"? TX delay is a board specific detail, no?

> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
>   };
>  
>   csi20: csi2@fea8 {
> 

MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Sergei Shtylyov]

On 02/20/2018 06:12 PM, Jacopo Mondi wrote:

> Populate the ethernet@e680 device node to enable Ethernet interface
> for R-Car M3-N (r8a77965) SoC.
> 
> Signed-off-by: Jacopo Mondi 
> Reviewed-by: Geert Uytterhoeven 
> 
> ---
> v1 -> v2:
> - Replace ALWAYS_ON power area identifier with numeric constant
> ---
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 
> ++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 55f05f7..c249895 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -520,7 +520,48 @@
>   };
>  
>   avb: ethernet@e680 {
> - /* placeholder */
> + compatible = "renesas,etheravb-r8a77965",
> +  "renesas,etheravb-rcar-gen3";
> + reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
> + interrupts = ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ,
> +  ;
> + interrupt-names = "ch0", "ch1", "ch2", "ch3",
> +   "ch4", "ch5", "ch6", "ch7",
> +   "ch8", "ch9", "ch10", "ch11",
> +   "ch12", "ch13", "ch14", "ch15",
> +   "ch16", "ch17", "ch18", "ch19",
> +   "ch20", "ch21", "ch22", "ch23",
> +   "ch24";
> + clocks = < CPG_MOD 812>;
> + power-domains = < 32>;
> + resets = < 812>;
> + phy-mode = "rgmii-txid";

   Why not just "rgmii"? TX delay is a board specific detail, no?

> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
>   };
>  
>   csi20: csi2@fea8 {
> 

MBR, Sergei