Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2018-04-17 Thread Benjamin Tissoires
FYI, these are the two patches I mentioned earlier. checkpatch.pl still complains about them so do not merge them right away, but this should give you a better idea. Also, this is the tip of my local tree, so there is a high chance it doesn't apply cleanly on your for-next branch. Cheers,

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2018-04-17 Thread Benjamin Tissoires
FYI, these are the two patches I mentioned earlier. checkpatch.pl still complains about them so do not merge them right away, but this should give you a better idea. Also, this is the tip of my local tree, so there is a high chance it doesn't apply cleanly on your for-next branch. Cheers,

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2018-04-17 Thread Benjamin Tissoires
On Tue, Apr 17, 2018 at 2:11 PM, Jiri Kosina wrote: > On Mon, 16 Apr 2018, Dmitry Torokhov wrote: > >> So what is happening with this series? I think we should get it them >> in; there is really no reason for bumping ABS_MISC till it gets into >> ABS_MT_* range on some devices

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2018-04-17 Thread Benjamin Tissoires
On Tue, Apr 17, 2018 at 2:11 PM, Jiri Kosina wrote: > On Mon, 16 Apr 2018, Dmitry Torokhov wrote: > >> So what is happening with this series? I think we should get it them >> in; there is really no reason for bumping ABS_MISC till it gets into >> ABS_MT_* range on some devices that are out there.

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2018-04-17 Thread Jiri Kosina
On Mon, 16 Apr 2018, Dmitry Torokhov wrote: > So what is happening with this series? I think we should get it them > in; there is really no reason for bumping ABS_MISC till it gets into > ABS_MT_* range on some devices that are out there. > > FWIW > > Acked-by: Dmitry Torokhov

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2018-04-17 Thread Jiri Kosina
On Mon, 16 Apr 2018, Dmitry Torokhov wrote: > So what is happening with this series? I think we should get it them > in; there is really no reason for bumping ABS_MISC till it gets into > ABS_MT_* range on some devices that are out there. > > FWIW > > Acked-by: Dmitry Torokhov Sorry, I

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2018-04-16 Thread Dmitry Torokhov
On Mon, Dec 11, 2017 at 08:29:26AM +1000, Peter Hutterer wrote: > On Fri, Dec 08, 2017 at 03:28:18PM +0100, Benjamin Tissoires wrote: > > This is something that bothered us from a long time. When hid-input > > doesn't know how to map a usage, it uses *_MISC. But there is something > > else which

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2018-04-16 Thread Dmitry Torokhov
On Mon, Dec 11, 2017 at 08:29:26AM +1000, Peter Hutterer wrote: > On Fri, Dec 08, 2017 at 03:28:18PM +0100, Benjamin Tissoires wrote: > > This is something that bothered us from a long time. When hid-input > > doesn't know how to map a usage, it uses *_MISC. But there is something > > else which

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2017-12-10 Thread Peter Hutterer
On Fri, Dec 08, 2017 at 03:28:18PM +0100, Benjamin Tissoires wrote: > This is something that bothered us from a long time. When hid-input > doesn't know how to map a usage, it uses *_MISC. But there is something > else which increments the usage if the evdev code is already used. > > This leads

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2017-12-10 Thread Peter Hutterer
On Fri, Dec 08, 2017 at 03:28:18PM +0100, Benjamin Tissoires wrote: > This is something that bothered us from a long time. When hid-input > doesn't know how to map a usage, it uses *_MISC. But there is something > else which increments the usage if the evdev code is already used. > > This leads

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2017-12-08 Thread Dmitry Torokhov
On Fri, Dec 08, 2017 at 03:28:18PM +0100, Benjamin Tissoires wrote: > This is something that bothered us from a long time. When hid-input > doesn't know how to map a usage, it uses *_MISC. But there is something > else which increments the usage if the evdev code is already used. > > This leads

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2017-12-08 Thread Dmitry Torokhov
On Fri, Dec 08, 2017 at 03:28:18PM +0100, Benjamin Tissoires wrote: > This is something that bothered us from a long time. When hid-input > doesn't know how to map a usage, it uses *_MISC. But there is something > else which increments the usage if the evdev code is already used. > > This leads