Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 7:51 PM, Ard Biesheuvel wrote: > On 26 February 2018 at 17:16, Ard Biesheuvel > wrote: > Perhaps we could agree on the binding first? Currently, I have the following > > Device (I2C0) { > Name (_HID,

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 7:51 PM, Ard Biesheuvel wrote: > On 26 February 2018 at 17:16, Ard Biesheuvel > wrote: > Perhaps we could agree on the binding first? Currently, I have the following > > Device (I2C0) { > Name (_HID, "SCX0003") > Name (_UID, Zero) > Name (_CRS,

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Ard Biesheuvel
On 26 February 2018 at 17:16, Ard Biesheuvel wrote: > On 26 February 2018 at 17:05, Andy Shevchenko > wrote: >> On Mon, Feb 26, 2018 at 4:58 PM, Ard Biesheuvel >> wrote: >>> On 26 February 2018 at 11:35, Andy

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Ard Biesheuvel
On 26 February 2018 at 17:16, Ard Biesheuvel wrote: > On 26 February 2018 at 17:05, Andy Shevchenko > wrote: >> On Mon, Feb 26, 2018 at 4:58 PM, Ard Biesheuvel >> wrote: >>> On 26 February 2018 at 11:35, Andy Shevchenko >>> wrote: On Mon, Feb 26, 2018 at 11:59 AM, Ard Biesheuvel

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Ard Biesheuvel
On 26 February 2018 at 17:05, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 4:58 PM, Ard Biesheuvel > wrote: >> On 26 February 2018 at 11:35, Andy Shevchenko >> wrote: >>> On Mon, Feb 26, 2018 at 11:59 AM, Ard

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Ard Biesheuvel
On 26 February 2018 at 17:05, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 4:58 PM, Ard Biesheuvel > wrote: >> On 26 February 2018 at 11:35, Andy Shevchenko >> wrote: >>> On Mon, Feb 26, 2018 at 11:59 AM, Ard Biesheuvel >>> wrote: On 23 February 2018 at 13:12, Andy Shevchenko

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 4:58 PM, Ard Biesheuvel wrote: > On 26 February 2018 at 11:35, Andy Shevchenko > wrote: >> On Mon, Feb 26, 2018 at 11:59 AM, Ard Biesheuvel >> wrote: >>> On 23 February 2018 at 13:12, Andy

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 4:58 PM, Ard Biesheuvel wrote: > On 26 February 2018 at 11:35, Andy Shevchenko > wrote: >> On Mon, Feb 26, 2018 at 11:59 AM, Ard Biesheuvel >> wrote: >>> On 23 February 2018 at 13:12, Andy Shevchenko >>> wrote: On Fri, Feb 23, 2018 at 2:40 PM, Ard Biesheuvel

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Ard Biesheuvel
On 26 February 2018 at 11:35, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 11:59 AM, Ard Biesheuvel > wrote: >> On 23 February 2018 at 13:12, Andy Shevchenko >> wrote: >>> On Fri, Feb 23, 2018 at 2:40 PM, Ard

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Ard Biesheuvel
On 26 February 2018 at 11:35, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 11:59 AM, Ard Biesheuvel > wrote: >> On 23 February 2018 at 13:12, Andy Shevchenko >> wrote: >>> On Fri, Feb 23, 2018 at 2:40 PM, Ard Biesheuvel >>> wrote: On 23 February 2018 at 12:27, Andy Shevchenko

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 11:59 AM, Ard Biesheuvel wrote: > On 23 February 2018 at 13:12, Andy Shevchenko > wrote: >> On Fri, Feb 23, 2018 at 2:40 PM, Ard Biesheuvel >> wrote: >>> On 23 February 2018 at 12:27, Andy

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 11:59 AM, Ard Biesheuvel wrote: > On 23 February 2018 at 13:12, Andy Shevchenko > wrote: >> On Fri, Feb 23, 2018 at 2:40 PM, Ard Biesheuvel >> wrote: >>> On 23 February 2018 at 12:27, Andy Shevchenko >>> wrote: On Thu, Feb 22, 2018 at 9:16 PM, Ard Biesheuvel

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Ard Biesheuvel
On 23 February 2018 at 13:12, Andy Shevchenko wrote: > On Fri, Feb 23, 2018 at 2:40 PM, Ard Biesheuvel > wrote: >> On 23 February 2018 at 12:27, Andy Shevchenko >> wrote: >>> On Thu, Feb 22, 2018 at 9:16 PM, Ard

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-26 Thread Ard Biesheuvel
On 23 February 2018 at 13:12, Andy Shevchenko wrote: > On Fri, Feb 23, 2018 at 2:40 PM, Ard Biesheuvel > wrote: >> On 23 February 2018 at 12:27, Andy Shevchenko >> wrote: >>> On Thu, Feb 22, 2018 at 9:16 PM, Ard Biesheuvel >>> wrote: ... + ret = device_property_read_u32(>dev,

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-23 Thread Andy Shevchenko
On Fri, Feb 23, 2018 at 2:40 PM, Ard Biesheuvel wrote: > On 23 February 2018 at 12:27, Andy Shevchenko > wrote: >> On Thu, Feb 22, 2018 at 9:16 PM, Ard Biesheuvel >> wrote: >>> This is a cleaned up version of the

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-23 Thread Andy Shevchenko
On Fri, Feb 23, 2018 at 2:40 PM, Ard Biesheuvel wrote: > On 23 February 2018 at 12:27, Andy Shevchenko > wrote: >> On Thu, Feb 22, 2018 at 9:16 PM, Ard Biesheuvel >> wrote: >>> This is a cleaned up version of the I2C controller driver for >>> the Fujitsu F_I2C IP, which was never supported

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-23 Thread Ard Biesheuvel
On 23 February 2018 at 12:27, Andy Shevchenko wrote: > On Thu, Feb 22, 2018 at 9:16 PM, Ard Biesheuvel > wrote: >> This is a cleaned up version of the I2C controller driver for >> the Fujitsu F_I2C IP, which was never supported upstream, and

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-23 Thread Ard Biesheuvel
On 23 February 2018 at 12:27, Andy Shevchenko wrote: > On Thu, Feb 22, 2018 at 9:16 PM, Ard Biesheuvel > wrote: >> This is a cleaned up version of the I2C controller driver for >> the Fujitsu F_I2C IP, which was never supported upstream, and >> has now been incorporated into the Socionext

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-23 Thread Andy Shevchenko
On Thu, Feb 22, 2018 at 9:16 PM, Ard Biesheuvel wrote: > This is a cleaned up version of the I2C controller driver for > the Fujitsu F_I2C IP, which was never supported upstream, and > has now been incorporated into the Socionext SynQuacer SoC. > Thanks for an update.

Re: [PATCH v2 2/2] i2c: add support for Socionext SynQuacer I2C controller

2018-02-23 Thread Andy Shevchenko
On Thu, Feb 22, 2018 at 9:16 PM, Ard Biesheuvel wrote: > This is a cleaned up version of the I2C controller driver for > the Fujitsu F_I2C IP, which was never supported upstream, and > has now been incorporated into the Socionext SynQuacer SoC. > Thanks for an update. My comments below. In case