Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-24 Thread Willy Tarreau
On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote: > On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: > > Btw, this whole function is terrible. It should be reading larger > > chunks at once instead of get_user() for each character. Just for the record, very small

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-24 Thread Willy Tarreau
On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote: On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: Btw, this whole function is terrible. It should be reading larger chunks at once instead of get_user() for each character. Just for the record, very small character

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-23 Thread Dan Carpenter
On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote: > On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: > The aim of my patch was basically to add __user annotation. I tried to > keep the change minimal to lessen the risk of regression Yes. That's the right approach.

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-23 Thread Bastien Armand
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: > Out of curiosity, have you tested this patch? > > On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote: > > This patch fixes two sparse warnings related to lcd_write : > > warning: incorrect type in argument 1 (different

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-23 Thread Bastien Armand
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: Out of curiosity, have you tested this patch? On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote: This patch fixes two sparse warnings related to lcd_write : warning: incorrect type in argument 1 (different address

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-23 Thread Dan Carpenter
On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote: On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote: The aim of my patch was basically to add __user annotation. I tried to keep the change minimal to lessen the risk of regression Yes. That's the right approach. These

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-22 Thread Dan Carpenter
Out of curiosity, have you tested this patch? On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote: > This patch fixes two sparse warnings related to lcd_write : > warning: incorrect type in argument 1 (different address spaces) > warning: incorrect type in initializer (incompatible

Re: [PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-22 Thread Dan Carpenter
Out of curiosity, have you tested this patch? On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote: This patch fixes two sparse warnings related to lcd_write : warning: incorrect type in argument 1 (different address spaces) warning: incorrect type in initializer (incompatible