Re: [PATCH v2 2/3] ALSA: hda: fix front speakers on Huawei MBXP.

2018-11-02 Thread Andy Shevchenko 
On Fri, Nov 2, 2018 at 6:11 AM Ayman Bagabas  wrote:
>
> This patch solves bug 200501 'Only 2 of 4 speakers playing sound.'
> https://bugzilla.kernel.org/show_bug.cgi?id=200501
> It enables the front speakers on Huawei Matebook X Pro laptops.
> These laptops come with Dolby Atmos sound system and these pins
> configuration enables the front speakers.

> +   [ALC256_FIXUP_HUAWEI_MBXP_PINS] = {
> +   .type = HDA_FIXUP_PINS,
> +   .v.pins = (const struct hda_pintbl[]) {
> +   {0x12, 0x90a60130},
> +   {0x13, 0x4000},
> +   {0x14, 0x90170110},
> +   {0x18, 0x41f0},
> +   {0x19, 0x04a11040},
> +   {0x1a, 0x41f0},
> +   {0x1b, 0x90170112},
> +   {0x1d, 0x40759a05},
> +   {0x1e, 0x41f0},
> +   {0x21, 0x04211020},


> +   { },

Terminators better w/o comma.

> +   },
> +   },

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 2/3] ALSA: hda: fix front speakers on Huawei MBXP.

2018-11-02 Thread Andy Shevchenko 
On Fri, Nov 2, 2018 at 6:11 AM Ayman Bagabas  wrote:
>
> This patch solves bug 200501 'Only 2 of 4 speakers playing sound.'
> https://bugzilla.kernel.org/show_bug.cgi?id=200501
> It enables the front speakers on Huawei Matebook X Pro laptops.
> These laptops come with Dolby Atmos sound system and these pins
> configuration enables the front speakers.

> +   [ALC256_FIXUP_HUAWEI_MBXP_PINS] = {
> +   .type = HDA_FIXUP_PINS,
> +   .v.pins = (const struct hda_pintbl[]) {
> +   {0x12, 0x90a60130},
> +   {0x13, 0x4000},
> +   {0x14, 0x90170110},
> +   {0x18, 0x41f0},
> +   {0x19, 0x04a11040},
> +   {0x1a, 0x41f0},
> +   {0x1b, 0x90170112},
> +   {0x1d, 0x40759a05},
> +   {0x1e, 0x41f0},
> +   {0x21, 0x04211020},


> +   { },

Terminators better w/o comma.

> +   },
> +   },

-- 
With Best Regards,
Andy Shevchenko