Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-08-15 Thread Peter Rosin
On 2017-08-12 00:26, Stephen Boyd wrote: > Quoting Peter Rosin (2017-08-08 05:46:30) >> On 2017-08-08 03:51, Stephen Boyd wrote: >> >>> It looked like we paired the start/stop ops with >>> each other so that the mux is properly managed across these ops. >> >> Yes, it *looks*

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-08-15 Thread Peter Rosin
On 2017-08-12 00:26, Stephen Boyd wrote: > Quoting Peter Rosin (2017-08-08 05:46:30) >> On 2017-08-08 03:51, Stephen Boyd wrote: >> >>> It looked like we paired the start/stop ops with >>> each other so that the mux is properly managed across these ops. >> >> Yes, it *looks*

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-08-11 Thread Stephen Boyd
Quoting Peter Rosin (2017-08-08 05:46:30) > On 2017-08-08 03:51, Stephen Boyd wrote: > > > It looked like we paired the start/stop ops with > > each other so that the mux is properly managed across these ops. > > Yes, it *looks* ok... > > >

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-08-11 Thread Stephen Boyd
Quoting Peter Rosin (2017-08-08 05:46:30) > On 2017-08-08 03:51, Stephen Boyd wrote: > > > It looked like we paired the start/stop ops with > > each other so that the mux is properly managed across these ops. > > Yes, it *looks* ok... > > >

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-08-08 Thread Peter Rosin
On 2017-08-08 03:51, Stephen Boyd wrote: > Quoting Peter Rosin (2017-07-31 03:33:22) >> On 2017-07-14 23:40, Stephen Boyd wrote: >>> @@ -1964,16 +1965,26 @@ void ci_hdrc_gadget_destroy(struct ci_hdrc *ci) >>> >>> static int udc_id_switch_for_device(struct ci_hdrc *ci) >>> { >>> + int ret =

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-08-08 Thread Peter Rosin
On 2017-08-08 03:51, Stephen Boyd wrote: > Quoting Peter Rosin (2017-07-31 03:33:22) >> On 2017-07-14 23:40, Stephen Boyd wrote: >>> @@ -1964,16 +1965,26 @@ void ci_hdrc_gadget_destroy(struct ci_hdrc *ci) >>> >>> static int udc_id_switch_for_device(struct ci_hdrc *ci) >>> { >>> + int ret =

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-08-07 Thread Stephen Boyd
Quoting Peter Rosin (2017-07-31 03:33:22) > On 2017-07-14 23:40, Stephen Boyd wrote: > > @@ -1964,16 +1965,26 @@ void ci_hdrc_gadget_destroy(struct ci_hdrc *ci) > > > > static int udc_id_switch_for_device(struct ci_hdrc *ci) > > { > > + int ret = 0; > > + > > if (ci->is_otg) > >

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-08-07 Thread Stephen Boyd
Quoting Peter Rosin (2017-07-31 03:33:22) > On 2017-07-14 23:40, Stephen Boyd wrote: > > @@ -1964,16 +1965,26 @@ void ci_hdrc_gadget_destroy(struct ci_hdrc *ci) > > > > static int udc_id_switch_for_device(struct ci_hdrc *ci) > > { > > + int ret = 0; > > + > > if (ci->is_otg) > >

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-07-31 Thread Peter Rosin
On 2017-07-14 23:40, Stephen Boyd wrote: > On the db410c 96boards platform we have a TC7USB40MU on the board > to mux the D+/D- lines coming from the controller between a micro > usb "device" port and a USB hub for "host" roles[1]. During a > role switch, we need to toggle this mux to forward the

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-07-31 Thread Peter Rosin
On 2017-07-14 23:40, Stephen Boyd wrote: > On the db410c 96boards platform we have a TC7USB40MU on the board > to mux the D+/D- lines coming from the controller between a micro > usb "device" port and a USB hub for "host" roles[1]. During a > role switch, we need to toggle this mux to forward the

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-07-18 Thread Peter Chen
On Tue, Jul 18, 2017 at 06:47:02PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2017-07-17 21:41:11) > > On Fri, Jul 14, 2017 at 02:40:04PM -0700, Stephen Boyd wrote: > > > > > > @@ -175,6 +176,10 @@ static int host_start(struct ci_hdrc *ci) > > > if (ci_otg_is_fsm_mode(ci)) {

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-07-18 Thread Peter Chen
On Tue, Jul 18, 2017 at 06:47:02PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2017-07-17 21:41:11) > > On Fri, Jul 14, 2017 at 02:40:04PM -0700, Stephen Boyd wrote: > > > > > > @@ -175,6 +176,10 @@ static int host_start(struct ci_hdrc *ci) > > > if (ci_otg_is_fsm_mode(ci)) {

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-07-18 Thread Stephen Boyd
Quoting Peter Chen (2017-07-17 21:41:11) > On Fri, Jul 14, 2017 at 02:40:04PM -0700, Stephen Boyd wrote: > > > > @@ -175,6 +176,10 @@ static int host_start(struct ci_hdrc *ci) > > if (ci_otg_is_fsm_mode(ci)) { > > otg->host = >self; > >

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-07-18 Thread Stephen Boyd
Quoting Peter Chen (2017-07-17 21:41:11) > On Fri, Jul 14, 2017 at 02:40:04PM -0700, Stephen Boyd wrote: > > > > @@ -175,6 +176,10 @@ static int host_start(struct ci_hdrc *ci) > > if (ci_otg_is_fsm_mode(ci)) { > > otg->host = >self; > >

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-07-17 Thread Peter Chen
On Fri, Jul 14, 2017 at 02:40:04PM -0700, Stephen Boyd wrote: > > @@ -175,6 +176,10 @@ static int host_start(struct ci_hdrc *ci) > if (ci_otg_is_fsm_mode(ci)) { > otg->host = >self; > hcd->self.otg_port = 1; > + } else { > +

Re: [PATCH v2 2/3] usb: chipidea: Hook into mux framework to toggle usb switch

2017-07-17 Thread Peter Chen
On Fri, Jul 14, 2017 at 02:40:04PM -0700, Stephen Boyd wrote: > > @@ -175,6 +176,10 @@ static int host_start(struct ci_hdrc *ci) > if (ci_otg_is_fsm_mode(ci)) { > otg->host = >self; > hcd->self.otg_port = 1; > + } else { > +