Re: [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC)

2016-09-21 Thread Arnd Bergmann
On Wednesday, September 21, 2016 2:07:22 PM CEST Peter Ujfalusi wrote: > > > > I tend to use 'uintptr_t' for the cast instead. > > What about keeping the defines and: > > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index 3e9606b08340..493fdf30e8b8 100644 > --- a/drivers/dma/edma.c >

Re: [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC)

2016-09-21 Thread Arnd Bergmann
On Wednesday, September 21, 2016 2:07:22 PM CEST Peter Ujfalusi wrote: > > > > I tend to use 'uintptr_t' for the cast instead. > > What about keeping the defines and: > > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index 3e9606b08340..493fdf30e8b8 100644 > --- a/drivers/dma/edma.c >

Re: [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC)

2016-09-21 Thread Peter Ujfalusi
On 09/21/16 13:31, Arnd Bergmann wrote: > On Wednesday, September 21, 2016 1:26:30 PM CEST Peter Ujfalusi wrote: >> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c >> index c2098a4b4dcf..4c8818278fcc 100644 >> --- a/drivers/dma/edma.c >> +++ b/drivers/dma/edma.c >> @@ -261,8 +261,11 @@ static

Re: [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC)

2016-09-21 Thread Peter Ujfalusi
On 09/21/16 13:31, Arnd Bergmann wrote: > On Wednesday, September 21, 2016 1:26:30 PM CEST Peter Ujfalusi wrote: >> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c >> index c2098a4b4dcf..4c8818278fcc 100644 >> --- a/drivers/dma/edma.c >> +++ b/drivers/dma/edma.c >> @@ -261,8 +261,11 @@ static

Re: [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC)

2016-09-21 Thread Arnd Bergmann
On Wednesday, September 21, 2016 1:26:30 PM CEST Peter Ujfalusi wrote: > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index c2098a4b4dcf..4c8818278fcc 100644 > --- a/drivers/dma/edma.c > +++ b/drivers/dma/edma.c > @@ -261,8 +261,11 @@ static const struct edmacc_param dummy_paramset = { >

Re: [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC)

2016-09-21 Thread Arnd Bergmann
On Wednesday, September 21, 2016 1:26:30 PM CEST Peter Ujfalusi wrote: > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index c2098a4b4dcf..4c8818278fcc 100644 > --- a/drivers/dma/edma.c > +++ b/drivers/dma/edma.c > @@ -261,8 +261,11 @@ static const struct edmacc_param dummy_paramset = { >