Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-21 Thread Reza Arbab
On Wed, Sep 21, 2016 at 08:13:37PM +0530, Aneesh Kumar K.V wrote: So we are looking at two step online process here. The above explained the details nicely. Can you capture these details in the commit message. ie, to say that when using 'echo online-movable > state' we allow the move from normal

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-21 Thread Reza Arbab
On Wed, Sep 21, 2016 at 08:13:37PM +0530, Aneesh Kumar K.V wrote: So we are looking at two step online process here. The above explained the details nicely. Can you capture these details in the commit message. ie, to say that when using 'echo online-movable > state' we allow the move from normal

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-21 Thread Aneesh Kumar K.V
Reza Arbab writes: > On Wed, Sep 21, 2016 at 12:39:51PM +0530, Aneesh Kumar K.V wrote: >>What I was checking was how will one mark a node movable in ppc64 ? I >>don't see ppc64 code doing the equivalent of memblock_mark_hotplug(). > > Post boot, the marking mechanism is

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-21 Thread Aneesh Kumar K.V
Reza Arbab writes: > On Wed, Sep 21, 2016 at 12:39:51PM +0530, Aneesh Kumar K.V wrote: >>What I was checking was how will one mark a node movable in ppc64 ? I >>don't see ppc64 code doing the equivalent of memblock_mark_hotplug(). > > Post boot, the marking mechanism is not necessary. You can

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-21 Thread Reza Arbab
On Wed, Sep 21, 2016 at 12:39:51PM +0530, Aneesh Kumar K.V wrote: What I was checking was how will one mark a node movable in ppc64 ? I don't see ppc64 code doing the equivalent of memblock_mark_hotplug(). Post boot, the marking mechanism is not necessary. You can create a movable node by

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-21 Thread Reza Arbab
On Wed, Sep 21, 2016 at 12:39:51PM +0530, Aneesh Kumar K.V wrote: What I was checking was how will one mark a node movable in ppc64 ? I don't see ppc64 code doing the equivalent of memblock_mark_hotplug(). Post boot, the marking mechanism is not necessary. You can create a movable node by

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-21 Thread Aneesh Kumar K.V
Reza Arbab writes: > On Mon, Sep 19, 2016 at 11:59:35AM +0530, Aneesh Kumar K.V wrote: >>Movable node also does. >> memblock_set_bottom_up(true); >>What is the impact of that. Do we need changes equivalent to that ? Also >>where are we marking the nodes which can

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-21 Thread Aneesh Kumar K.V
Reza Arbab writes: > On Mon, Sep 19, 2016 at 11:59:35AM +0530, Aneesh Kumar K.V wrote: >>Movable node also does. >> memblock_set_bottom_up(true); >>What is the impact of that. Do we need changes equivalent to that ? Also >>where are we marking the nodes which can be hotplugged, ie where do

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-20 Thread Reza Arbab
On Mon, Sep 19, 2016 at 11:59:35AM +0530, Aneesh Kumar K.V wrote: Movable node also does. memblock_set_bottom_up(true); What is the impact of that. Do we need changes equivalent to that ? Also where are we marking the nodes which can be hotplugged, ie where do we do

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-20 Thread Reza Arbab
On Mon, Sep 19, 2016 at 11:59:35AM +0530, Aneesh Kumar K.V wrote: Movable node also does. memblock_set_bottom_up(true); What is the impact of that. Do we need changes equivalent to that ? Also where are we marking the nodes which can be hotplugged, ie where do we do

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-19 Thread Aneesh Kumar K.V
Reza Arbab writes: > Onlining memory into ZONE_MOVABLE requires CONFIG_MOVABLE_NODE. Enable > the use of this config option on PPC64 platforms. > > Signed-off-by: Reza Arbab > --- > Documentation/kernel-parameters.txt | 2 +- > mm/Kconfig

Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc

2016-09-19 Thread Aneesh Kumar K.V
Reza Arbab writes: > Onlining memory into ZONE_MOVABLE requires CONFIG_MOVABLE_NODE. Enable > the use of this config option on PPC64 platforms. > > Signed-off-by: Reza Arbab > --- > Documentation/kernel-parameters.txt | 2 +- > mm/Kconfig | 2 +- > 2 files changed, 2