Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()
On 12/07/18 08:52, Aapo Vienamo wrote: > On Wed, 11 Jul 2018 16:26:42 +0100 > Jon Hunter wrote: > >> On 11/07/18 16:23, Jon Hunter wrote: >>> >>> On 11/07/18 15:01, Aapo Vienamo wrote: Implement a function to query whether a pad is in deep power down mode. >>> Can you elaborate on why this public function is needed and who will be >>> using this? >> >> Or I should say does this need to be public? > > It's only called from the pinconf callbacks and exposing it doesn't > indeed make much sense if we intend to replace direct calls to pmc.c > with pinctrl anyway. I'll make it private on the next iteration of the > series. Yes let's make it private. Cheers Jon -- nvpublic
Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()
On 12/07/18 08:52, Aapo Vienamo wrote: > On Wed, 11 Jul 2018 16:26:42 +0100 > Jon Hunter wrote: > >> On 11/07/18 16:23, Jon Hunter wrote: >>> >>> On 11/07/18 15:01, Aapo Vienamo wrote: Implement a function to query whether a pad is in deep power down mode. >>> Can you elaborate on why this public function is needed and who will be >>> using this? >> >> Or I should say does this need to be public? > > It's only called from the pinconf callbacks and exposing it doesn't > indeed make much sense if we intend to replace direct calls to pmc.c > with pinctrl anyway. I'll make it private on the next iteration of the > series. Yes let's make it private. Cheers Jon -- nvpublic
Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()
On Wed, 11 Jul 2018 16:26:42 +0100 Jon Hunter wrote: > On 11/07/18 16:23, Jon Hunter wrote: > > > > On 11/07/18 15:01, Aapo Vienamo wrote: > >> Implement a function to query whether a pad is in deep power down mode. > > Can you elaborate on why this public function is needed and who will be > > using this? > > Or I should say does this need to be public? It's only called from the pinconf callbacks and exposing it doesn't indeed make much sense if we intend to replace direct calls to pmc.c with pinctrl anyway. I'll make it private on the next iteration of the series. -Aapo
Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()
On Wed, 11 Jul 2018 16:26:42 +0100 Jon Hunter wrote: > On 11/07/18 16:23, Jon Hunter wrote: > > > > On 11/07/18 15:01, Aapo Vienamo wrote: > >> Implement a function to query whether a pad is in deep power down mode. > > Can you elaborate on why this public function is needed and who will be > > using this? > > Or I should say does this need to be public? It's only called from the pinconf callbacks and exposing it doesn't indeed make much sense if we intend to replace direct calls to pmc.c with pinctrl anyway. I'll make it private on the next iteration of the series. -Aapo
Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()
On 11/07/18 16:23, Jon Hunter wrote: > > On 11/07/18 15:01, Aapo Vienamo wrote: >> Implement a function to query whether a pad is in deep power down mode. > Can you elaborate on why this public function is needed and who will be > using this? Or I should say does this need to be public? Jon -- nvpublic
Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()
On 11/07/18 16:23, Jon Hunter wrote: > > On 11/07/18 15:01, Aapo Vienamo wrote: >> Implement a function to query whether a pad is in deep power down mode. > Can you elaborate on why this public function is needed and who will be > using this? Or I should say does this need to be public? Jon -- nvpublic
Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()
On 11/07/18 15:01, Aapo Vienamo wrote: > Implement a function to query whether a pad is in deep power down mode. Can you elaborate on why this public function is needed and who will be using this? Cheers Jon -- nvpublic
Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()
On 11/07/18 15:01, Aapo Vienamo wrote: > Implement a function to query whether a pad is in deep power down mode. Can you elaborate on why this public function is needed and who will be using this? Cheers Jon -- nvpublic
