Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style
On Wed, Jul 11, 2018 at 05:29:43PM +0300, Dan Carpenter wrote: > On Wed, Jul 11, 2018 at 03:27:11PM +0100, John Whitmore wrote: > > On Wed, Jul 11, 2018 at 04:22:50PM +0200, Greg KH wrote: > > > On Wed, Jul 11, 2018 at 03:09:37PM +0100, John Whitmore wrote: > > > > On Wed, Jul 11, 2018 at 01:13:49PM +0200, Greg KH wrote: > > > > > On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote: > > > > > > Corrected coding style issues aroung opening and closed > > > > > > parenthesis. Spaces, or blank line, removed from after '(' or > > > > > > before ')' > > > > > > > > > > Wrap your changelog text at 72 columns like your editor asked you to > > > > > :( > > > > > > > > > > I'll fix it up this time... > > > > > > > > Oops sorry and thanks. I thought the magic number was 75 which I got > > > > from: > > > > > > > > https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html > > > > > > 75 works as well :) > > > > > > > Well if I went over 75, which I knew about I'm very sorry I messed up. I'll > > keep an eye out in future. Might be using the wrong editor but let's not go > > there. > > Here is the line: > > Corrected coding style issues aroung opening and closed parenthesis. Spaces, > or blank line, removed from after '(' or before ')' > > It's 128 characters. > > regards, > dan carpenter > Scissors I really messed that up. Sorry again, editor must have dropped out of auto-fill-mode for some reason. :(
Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style
On Wed, Jul 11, 2018 at 03:27:11PM +0100, John Whitmore wrote: > On Wed, Jul 11, 2018 at 04:22:50PM +0200, Greg KH wrote: > > On Wed, Jul 11, 2018 at 03:09:37PM +0100, John Whitmore wrote: > > > On Wed, Jul 11, 2018 at 01:13:49PM +0200, Greg KH wrote: > > > > On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote: > > > > > Corrected coding style issues aroung opening and closed parenthesis. > > > > > Spaces, or blank line, removed from after '(' or before ')' > > > > > > > > Wrap your changelog text at 72 columns like your editor asked you to :( > > > > > > > > I'll fix it up this time... > > > > > > Oops sorry and thanks. I thought the magic number was 75 which I got from: > > > > > > https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html > > > > 75 works as well :) > > > > Well if I went over 75, which I knew about I'm very sorry I messed up. I'll > keep an eye out in future. Might be using the wrong editor but let's not go > there. Here is the line: Corrected coding style issues aroung opening and closed parenthesis. Spaces, or blank line, removed from after '(' or before ')' It's 128 characters. regards, dan carpenter
Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style
On Wed, Jul 11, 2018 at 04:22:50PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:09:37PM +0100, John Whitmore wrote: > > On Wed, Jul 11, 2018 at 01:13:49PM +0200, Greg KH wrote: > > > On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote: > > > > Corrected coding style issues aroung opening and closed parenthesis. > > > > Spaces, or blank line, removed from after '(' or before ')' > > > > > > Wrap your changelog text at 72 columns like your editor asked you to :( > > > > > > I'll fix it up this time... > > > > Oops sorry and thanks. I thought the magic number was 75 which I got from: > > > > https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html > > 75 works as well :) > Well if I went over 75, which I knew about I'm very sorry I messed up. I'll keep an eye out in future. Might be using the wrong editor but let's not go there.
Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style
On Wed, Jul 11, 2018 at 03:09:37PM +0100, John Whitmore wrote: > On Wed, Jul 11, 2018 at 01:13:49PM +0200, Greg KH wrote: > > On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote: > > > Corrected coding style issues aroung opening and closed parenthesis. > > > Spaces, or blank line, removed from after '(' or before ')' > > > > Wrap your changelog text at 72 columns like your editor asked you to :( > > > > I'll fix it up this time... > > Oops sorry and thanks. I thought the magic number was 75 which I got from: > > https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html 75 works as well :)
Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style
On Wed, Jul 11, 2018 at 01:13:49PM +0200, Greg KH wrote: > On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote: > > Corrected coding style issues aroung opening and closed parenthesis. > > Spaces, or blank line, removed from after '(' or before ')' > > Wrap your changelog text at 72 columns like your editor asked you to :( > > I'll fix it up this time... Oops sorry and thanks. I thought the magic number was 75 which I got from: https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html jwhitmore
Re: [PATCH v2 3/8] staging:rtl8192u: Correct spacing before and after parenthesis - Style
On Tue, Jul 10, 2018 at 04:05:18PM +0100, John Whitmore wrote: > Corrected coding style issues aroung opening and closed parenthesis. Spaces, > or blank line, removed from after '(' or before ')' Wrap your changelog text at 72 columns like your editor asked you to :( I'll fix it up this time... greg k-h