Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-09 Thread Paul Burton
Hi Honghui & Bjorn, On Tuesday, 8 August 2017 23:49:52 PDT Honghui Zhang wrote: > On Tue, 2017-08-08 at 15:19 -0500, Bjorn Helgaas wrote: > > On Fri, Aug 04, 2017 at 08:18:09AM -0500, Bjorn Helgaas wrote: > > > On Fri, Aug 04, 2017 at 04:39:36PM +0800, Honghui Zhang wrote: > > > > On Thu, 2017-08-

Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-08 Thread Honghui Zhang
On Tue, 2017-08-08 at 15:19 -0500, Bjorn Helgaas wrote: > On Fri, Aug 04, 2017 at 08:18:09AM -0500, Bjorn Helgaas wrote: > > On Fri, Aug 04, 2017 at 04:39:36PM +0800, Honghui Zhang wrote: > > > On Thu, 2017-08-03 at 17:42 -0500, Bjorn Helgaas wrote: > > > > > > + port->irq_domain = irq_domain_

Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-08 Thread Bjorn Helgaas
On Fri, Aug 04, 2017 at 08:18:09AM -0500, Bjorn Helgaas wrote: > On Fri, Aug 04, 2017 at 04:39:36PM +0800, Honghui Zhang wrote: > > On Thu, 2017-08-03 at 17:42 -0500, Bjorn Helgaas wrote: > > > > + port->irq_domain = irq_domain_add_linear(pcie_intc_node, > > > > INTX_NUM, > > > > +

Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-08 Thread Bjorn Helgaas
On Sat, Aug 05, 2017 at 12:52:43PM +0800, Ryder Lee wrote: > Hi Honghui, Bjorn, > > On Fri, 2017-08-04 at 08:18 -0500, Bjorn Helgaas wrote: > > On Fri, Aug 04, 2017 at 04:39:36PM +0800, Honghui Zhang wrote: > > > On Thu, 2017-08-03 at 17:42 -0500, Bjorn Helgaas wrote: > > > > > + > > > > > +static

Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-06 Thread Honghui Zhang
On Sat, 2017-08-05 at 14:16 +0800, Ryder Lee wrote: > On Sat, 2017-08-05 at 12:52 +0800, Ryder Lee wrote: > > Hi Honghui, Bjorn, > > > > On Fri, 2017-08-04 at 08:18 -0500, Bjorn Helgaas wrote: > > > On Fri, Aug 04, 2017 at 04:39:36PM +0800, Honghui Zhang wrote: > > > > On Thu, 2017-08-03 at 17:42

Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-04 Thread Ryder Lee
On Sat, 2017-08-05 at 12:52 +0800, Ryder Lee wrote: > Hi Honghui, Bjorn, > > On Fri, 2017-08-04 at 08:18 -0500, Bjorn Helgaas wrote: > > On Fri, Aug 04, 2017 at 04:39:36PM +0800, Honghui Zhang wrote: > > > On Thu, 2017-08-03 at 17:42 -0500, Bjorn Helgaas wrote: > > > > > + > > > > > +static struct

Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-04 Thread Ryder Lee
Hi Honghui, Bjorn, On Fri, 2017-08-04 at 08:18 -0500, Bjorn Helgaas wrote: > On Fri, Aug 04, 2017 at 04:39:36PM +0800, Honghui Zhang wrote: > > On Thu, 2017-08-03 at 17:42 -0500, Bjorn Helgaas wrote: > > > > + > > > > +static struct mtk_pcie_port *mtk_pcie_find_port(struct mtk_pcie *pcie, > > > >

Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-04 Thread Bjorn Helgaas
On Fri, Aug 04, 2017 at 04:39:36PM +0800, Honghui Zhang wrote: > On Thu, 2017-08-03 at 17:42 -0500, Bjorn Helgaas wrote: > > > .. > > > +} > > > + > > > +static struct mtk_pcie_port *mtk_pcie_find_port(struct mtk_pcie *pcie, > > > + struct pci_bus *bus,

Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-04 Thread Honghui Zhang
Hi, Bjorn, Thanks very much for your reviews. The mis-spells will be fixed in next version. On Thu, 2017-08-03 at 17:42 -0500, Bjorn Helgaas wrote: .. > > +} > > + > > +static struct mtk_pcie_port *mtk_pcie_find_port(struct mtk_pcie *pcie, > > +

Re: [PATCH v2 4/5] PCI: mediatek: Add new generation controller support

2017-08-03 Thread Bjorn Helgaas
On Thu, Jul 27, 2017 at 10:58:38AM +0800, honghui.zh...@mediatek.com wrote: > From: Ryder Lee > > Add support for new Gen2 controller which has two root ports and shares > the probing flow with legacy controller. Currently this IP block can be > found on MT7622/MT2712. > > Signed-off-by: Ryder L