Re: [PATCH v2 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-20 Thread Maxime Ripard
Hi Linus, On Thu, Oct 20, 2016 at 02:52:54PM +0200, Linus Walleij wrote: > On Wed, Oct 19, 2016 at 2:16 PM, Maxime Ripard > wrote: > > On Tue, Oct 18, 2016 at 03:47:03PM +0800, Chen-Yu Tsai wrote: > >> > @@ -342,6 +365,8 @@ static void

Re: [PATCH v2 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-20 Thread Maxime Ripard
Hi Linus, On Thu, Oct 20, 2016 at 02:52:54PM +0200, Linus Walleij wrote: > On Wed, Oct 19, 2016 at 2:16 PM, Maxime Ripard > wrote: > > On Tue, Oct 18, 2016 at 03:47:03PM +0800, Chen-Yu Tsai wrote: > >> > @@ -342,6 +365,8 @@ static void sunxi_pctrl_dt_free_map(struct > >> > pinctrl_dev *pctldev,

Re: [PATCH v2 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-20 Thread Linus Walleij
On Wed, Oct 19, 2016 at 2:16 PM, Maxime Ripard wrote: > On Tue, Oct 18, 2016 at 03:47:03PM +0800, Chen-Yu Tsai wrote: >> > @@ -342,6 +365,8 @@ static void sunxi_pctrl_dt_free_map(struct pinctrl_dev >> > *pctldev, >> > struct

Re: [PATCH v2 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-20 Thread Linus Walleij
On Wed, Oct 19, 2016 at 2:16 PM, Maxime Ripard wrote: > On Tue, Oct 18, 2016 at 03:47:03PM +0800, Chen-Yu Tsai wrote: >> > @@ -342,6 +365,8 @@ static void sunxi_pctrl_dt_free_map(struct pinctrl_dev >> > *pctldev, >> > struct pinctrl_map *map, >> >

Re: [PATCH v2 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-19 Thread Maxime Ripard
On Tue, Oct 18, 2016 at 03:47:03PM +0800, Chen-Yu Tsai wrote: > > @@ -342,6 +365,8 @@ static void sunxi_pctrl_dt_free_map(struct pinctrl_dev > > *pctldev, > > struct pinctrl_map *map, > > unsigned num_maps) > > { > > +

Re: [PATCH v2 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-19 Thread Maxime Ripard
On Tue, Oct 18, 2016 at 03:47:03PM +0800, Chen-Yu Tsai wrote: > > @@ -342,6 +365,8 @@ static void sunxi_pctrl_dt_free_map(struct pinctrl_dev > > *pctldev, > > struct pinctrl_map *map, > > unsigned num_maps) > > { > > +

Re: [PATCH v2 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-18 Thread Chen-Yu Tsai
On Tue, Oct 11, 2016 at 11:46 PM, Maxime Ripard wrote: > Even though the our binding had the assumption that the allwinner,pull and > allwinner,drive properties were optional, the code never took that into > account. > > Fix that. > > Signed-off-by: Maxime Ripard

Re: [PATCH v2 4/9] pinctrl: sunxi: Deal with configless pins

2016-10-18 Thread Chen-Yu Tsai
On Tue, Oct 11, 2016 at 11:46 PM, Maxime Ripard wrote: > Even though the our binding had the assumption that the allwinner,pull and > allwinner,drive properties were optional, the code never took that into > account. > > Fix that. > > Signed-off-by: Maxime Ripard > --- >