Re: [PATCH v2 43/62] x86/alternative: Define ELF section entry size for alternatives
On Fri, May 09, 2025 at 02:54:00PM -0700, Josh Poimboeuf wrote: > On Fri, May 09, 2025 at 11:36:35PM +0200, Borislav Petkov wrote: > > On Fri, May 09, 2025 at 01:17:07PM -0700, Josh Poimboeuf wrote: > > > +#define ALTINSTR_SIZE14 > > > > We have sizeof(struct alt_instr) to offer... > > Right, but IIRC, sizeof(struct alt_instr) isn't available at macro > expansion time so it would have to be provided as an input constraint. > > That doesn't really work for the ALTERNATIVE macro, where the asm > constraints are out of our control because they're set by the caller. Bah, that doesn't work. And you're enforcing it with BUILD_BUG_ON(). Oh well, ignore the noise. :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
Re: [PATCH v2 43/62] x86/alternative: Define ELF section entry size for alternatives
On Fri, May 09, 2025 at 11:36:35PM +0200, Borislav Petkov wrote: > On Fri, May 09, 2025 at 01:17:07PM -0700, Josh Poimboeuf wrote: > > +#define ALTINSTR_SIZE 14 > > We have sizeof(struct alt_instr) to offer... Right, but IIRC, sizeof(struct alt_instr) isn't available at macro expansion time so it would have to be provided as an input constraint. That doesn't really work for the ALTERNATIVE macro, where the asm constraints are out of our control because they're set by the caller. -- Josh
Re: [PATCH v2 43/62] x86/alternative: Define ELF section entry size for alternatives
On Fri, May 09, 2025 at 01:17:07PM -0700, Josh Poimboeuf wrote: > +#define ALTINSTR_SIZE14 We have sizeof(struct alt_instr) to offer... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
