Re: [PATCH v2 6/6] iio:dac:ad5686: Add AD5671R/75R/94/94R/95R/96/96R support

2018-04-10 Thread Randy Dunlap 
On 04/10/18 08:58, Stefan Popa wrote:
> The AD5694/AD5694R/AD5695R/AD5696/AD5696R are a family of 4 channel DACs
> with 12-bit, 14-bit and 16-bit precision respectively. The devices have
> either no built-in reference, or built-in 2.5V reference.
> 
> The AD5671R/AD5675R are similar, except that they have 8 instead of 4
> channels.
> 
> These devices are similar to AD5672R/AD5676/AD5676R and
> AD5684/AD5684R/AD5684/AD5685R/AD5686/AD5686R, except that they use i2c
> instead of spi.
> 
> Datasheets:
> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5671R_5675R.pdf
> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5696R_5695R_5694R.pdf
> 
> Signed-off-by: Stefan Popa 
> ---
> Changes in v2:
>   - Refactored the patch
> 
>  MAINTAINERS  |  1 +
>  drivers/iio/dac/Kconfig  | 10 +
>  drivers/iio/dac/Makefile |  1 +
>  drivers/iio/dac/ad5686.c | 28 +
>  drivers/iio/dac/ad5686.h |  7 
>  drivers/iio/dac/ad5696-i2c.c | 98 
> 
>  6 files changed, 145 insertions(+)
>  create mode 100644 drivers/iio/dac/ad5696-i2c.c
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index a00fc45..dab0b8a 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -145,6 +145,16 @@ config AD5686_SPI
>   To compile this driver as a module, choose M here: the
>   module will be called ad5686.
>  
> +config AD5696_I2C
> + tristate "Analog Devices AD5696 and similar multi-channel DACs (I2C)"
> + depends on I2C
> + select AD5686
> + help
> + Say yes here to build support for Analog Devices AD5671R, AD5675R,
> + AD5694, AD5694R, AD5695R, AD5696, AD5696R Voltage Output Digital to
> + Analog Converter.
> + To compile this driver as a module, choose M here: the module will be
> + called ad5696.

The help text (following the "help" line) should be indented 2 additional 
spaces,
according to Documentation/process/coding-style.rst.

(for patches 5 & 6)

>  config AD5755
>   tristate "Analog Devices AD5755/AD5755-1/AD5757/AD5735/AD5737 DAC 
> driver"


-- 
~Randy

Re: [PATCH v2 6/6] iio:dac:ad5686: Add AD5671R/75R/94/94R/95R/96/96R support

2018-04-10 Thread Randy Dunlap 
On 04/10/18 08:58, Stefan Popa wrote:
> The AD5694/AD5694R/AD5695R/AD5696/AD5696R are a family of 4 channel DACs
> with 12-bit, 14-bit and 16-bit precision respectively. The devices have
> either no built-in reference, or built-in 2.5V reference.
> 
> The AD5671R/AD5675R are similar, except that they have 8 instead of 4
> channels.
> 
> These devices are similar to AD5672R/AD5676/AD5676R and
> AD5684/AD5684R/AD5684/AD5685R/AD5686/AD5686R, except that they use i2c
> instead of spi.
> 
> Datasheets:
> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5671R_5675R.pdf
> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5696R_5695R_5694R.pdf
> 
> Signed-off-by: Stefan Popa 
> ---
> Changes in v2:
>   - Refactored the patch
> 
>  MAINTAINERS  |  1 +
>  drivers/iio/dac/Kconfig  | 10 +
>  drivers/iio/dac/Makefile |  1 +
>  drivers/iio/dac/ad5686.c | 28 +
>  drivers/iio/dac/ad5686.h |  7 
>  drivers/iio/dac/ad5696-i2c.c | 98 
> 
>  6 files changed, 145 insertions(+)
>  create mode 100644 drivers/iio/dac/ad5696-i2c.c
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index a00fc45..dab0b8a 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -145,6 +145,16 @@ config AD5686_SPI
>   To compile this driver as a module, choose M here: the
>   module will be called ad5686.
>  
> +config AD5696_I2C
> + tristate "Analog Devices AD5696 and similar multi-channel DACs (I2C)"
> + depends on I2C
> + select AD5686
> + help
> + Say yes here to build support for Analog Devices AD5671R, AD5675R,
> + AD5694, AD5694R, AD5695R, AD5696, AD5696R Voltage Output Digital to
> + Analog Converter.
> + To compile this driver as a module, choose M here: the module will be
> + called ad5696.

The help text (following the "help" line) should be indented 2 additional 
spaces,
according to Documentation/process/coding-style.rst.

(for patches 5 & 6)

>  config AD5755
>   tristate "Analog Devices AD5755/AD5755-1/AD5757/AD5735/AD5737 DAC 
> driver"


-- 
~Randy