Re: [PATCH v2 6/7] vmw_balloon: update copyright message
On Fri, Jun 15, 2018 at 08:38:57PM +, Nadav Amit wrote: > at 1:35 PM, valdis.kletni...@vt.edu wrote: > > > On Thu, 14 Jun 2018 05:33:46 -, Nadav Amit said: > > > In addition, updating the year and adding a license tag. > > > +// SPDX-License-Identifier: GPL-2.0 > > > >>> You still have a lot of boiler-plate text in here that can be removed. > >>> Please do so. > > > >> But what else do you want me to remove? This is a standard GPL license. If > >> I > >> am required to remove the GPL license, I will have to run checks to ensure > >> it is appropriate. > > > > You mean the checks that you should have done when you stuck the SPDX > > tag on the file? > > > > (Hint: Think of the SPDX tag as a '#include gplv2.license.blurb" :) > > I matched the SPDX to the license we have, tut I don’t know whether my > company regards an SPDX tag as a sufficient means to protect copyrights, > which allows to remove all the rest of the text. Copyrights have nothing to do with SPDX lines, please don't get copyrights and licenses confused, they are two totally different things. Removing the license boilerplate and only using a SPDX line for the license marking does not change the copyright of a file at all. And if you use the correct SPDX line, it will not change the license of the file at all either. If your company's lawyers have any questions about this, I am glad to discuss this with them and point them at the lawyers that created the SPDX group. But really, your company lawyers already know all about this, you should not have any problems at all. If you are worried about this, please contact your open source group and they will be glad to help out. I have names if you want me to send them to you off-list :) thanks, greg k-h
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
On Fri, Jun 15, 2018 at 08:38:57PM +, Nadav Amit wrote: > at 1:35 PM, valdis.kletni...@vt.edu wrote: > > > On Thu, 14 Jun 2018 05:33:46 -, Nadav Amit said: > > > In addition, updating the year and adding a license tag. > > > +// SPDX-License-Identifier: GPL-2.0 > > > >>> You still have a lot of boiler-plate text in here that can be removed. > >>> Please do so. > > > >> But what else do you want me to remove? This is a standard GPL license. If > >> I > >> am required to remove the GPL license, I will have to run checks to ensure > >> it is appropriate. > > > > You mean the checks that you should have done when you stuck the SPDX > > tag on the file? > > > > (Hint: Think of the SPDX tag as a '#include gplv2.license.blurb" :) > > I matched the SPDX to the license we have, tut I don’t know whether my > company regards an SPDX tag as a sufficient means to protect copyrights, > which allows to remove all the rest of the text. Copyrights have nothing to do with SPDX lines, please don't get copyrights and licenses confused, they are two totally different things. Removing the license boilerplate and only using a SPDX line for the license marking does not change the copyright of a file at all. And if you use the correct SPDX line, it will not change the license of the file at all either. If your company's lawyers have any questions about this, I am glad to discuss this with them and point them at the lawyers that created the SPDX group. But really, your company lawyers already know all about this, you should not have any problems at all. If you are worried about this, please contact your open source group and they will be glad to help out. I have names if you want me to send them to you off-list :) thanks, greg k-h
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
at 1:35 PM, valdis.kletni...@vt.edu wrote: > On Thu, 14 Jun 2018 05:33:46 -, Nadav Amit said: > In addition, updating the year and adding a license tag. > +// SPDX-License-Identifier: GPL-2.0 > >>> You still have a lot of boiler-plate text in here that can be removed. >>> Please do so. > >> But what else do you want me to remove? This is a standard GPL license. If I >> am required to remove the GPL license, I will have to run checks to ensure >> it is appropriate. > > You mean the checks that you should have done when you stuck the SPDX > tag on the file? > > (Hint: Think of the SPDX tag as a '#include gplv2.license.blurb" :) I matched the SPDX to the license we have, tut I don’t know whether my company regards an SPDX tag as a sufficient means to protect copyrights, which allows to remove all the rest of the text. Just trying not to get fired for a stupid reason ;)
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
at 1:35 PM, valdis.kletni...@vt.edu wrote: > On Thu, 14 Jun 2018 05:33:46 -, Nadav Amit said: > In addition, updating the year and adding a license tag. > +// SPDX-License-Identifier: GPL-2.0 > >>> You still have a lot of boiler-plate text in here that can be removed. >>> Please do so. > >> But what else do you want me to remove? This is a standard GPL license. If I >> am required to remove the GPL license, I will have to run checks to ensure >> it is appropriate. > > You mean the checks that you should have done when you stuck the SPDX > tag on the file? > > (Hint: Think of the SPDX tag as a '#include gplv2.license.blurb" :) I matched the SPDX to the license we have, tut I don’t know whether my company regards an SPDX tag as a sufficient means to protect copyrights, which allows to remove all the rest of the text. Just trying not to get fired for a stupid reason ;)
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
On Thu, 14 Jun 2018 05:33:46 -, Nadav Amit said: > >> In addition, updating the year and adding a license tag. > >> +// SPDX-License-Identifier: GPL-2.0 > > You still have a lot of boiler-plate text in here that can be removed. > > Please do so. > But what else do you want me to remove? This is a standard GPL license. If I > am required to remove the GPL license, I will have to run checks to ensure > it is appropriate. You mean the checks that you should have done when you stuck the SPDX tag on the file? (Hint: Think of the SPDX tag as a '#include gplv2.license.blurb" :) pgpTbI8AAoIqV.pgp Description: PGP signature
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
On Thu, 14 Jun 2018 05:33:46 -, Nadav Amit said: > >> In addition, updating the year and adding a license tag. > >> +// SPDX-License-Identifier: GPL-2.0 > > You still have a lot of boiler-plate text in here that can be removed. > > Please do so. > But what else do you want me to remove? This is a standard GPL license. If I > am required to remove the GPL license, I will have to run checks to ensure > it is appropriate. You mean the checks that you should have done when you stuck the SPDX tag on the file? (Hint: Think of the SPDX tag as a '#include gplv2.license.blurb" :) pgpTbI8AAoIqV.pgp Description: PGP signature
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
On Thu, Jun 14, 2018 at 05:33:46AM +, Nadav Amit wrote:
> at 10:24 PM, Greg Kroah-Hartman wrote:
>
> > On Wed, Jun 13, 2018 at 06:54:11AM -0700, Nadav Amit wrote:
> >> Removing the paragraph about writing to the Free Software Foundation's
> >> mailing address from the sample GPL notice according to checkpatch
> >> request.
> >>
> >> In addition, updating the year and adding a license tag.
> >>
> >> Reviewed-by: Xavier Deguillard
> >> Signed-off-by: Nadav Amit
> >> ---
> >> drivers/misc/vmw_balloon.c | 7 ++-
> >> 1 file changed, 2 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> >> index 400a1ccefc8e..b982059ce7b7 100644
> >> --- a/drivers/misc/vmw_balloon.c
> >> +++ b/drivers/misc/vmw_balloon.c
> >> @@ -1,7 +1,8 @@
> >> +// SPDX-License-Identifier: GPL-2.0
> >> /*
> >> * VMware Balloon driver.
> >> *
> >> - * Copyright (C) 2000-2014, VMware, Inc. All Rights Reserved.
> >> + * Copyright (C) 2000-2018, VMware, Inc. All Rights Reserved.
> >> *
> >> * This program is free software; you can redistribute it and/or modify it
> >> * under the terms of the GNU General Public License as published by the
> >> @@ -13,10 +14,6 @@
> >> * NON INFRINGEMENT. See the GNU General Public License for more
> >> * details.
> >
> > You still have a lot of boiler-plate text in here that can be removed.
> > Please do so.
>
> I will remove the maintainers, since it is really unsuitable.
>
> But what else do you want me to remove? This is a standard GPL license. If I
> am required to remove the GPL license, I will have to run checks to ensure
> it is appropriate.
Yes, all of the license text should be removed. Right now we have 700+
differnt wordings of "This file is released under the GPL" in the kernel
tree, and we need to clean that up. Look at all of the other SPDX
cleanups we have done already to get an idea of what is needed here.
As one example, look at 0c3b34a569f8 ("USB: typec: Remove remaining
redundant license text") which can be done after the correct SPDX line
is in the file. That's the end-goal for all kernel files.
thanks,
greg k-h
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
On Thu, Jun 14, 2018 at 05:33:46AM +, Nadav Amit wrote:
> at 10:24 PM, Greg Kroah-Hartman wrote:
>
> > On Wed, Jun 13, 2018 at 06:54:11AM -0700, Nadav Amit wrote:
> >> Removing the paragraph about writing to the Free Software Foundation's
> >> mailing address from the sample GPL notice according to checkpatch
> >> request.
> >>
> >> In addition, updating the year and adding a license tag.
> >>
> >> Reviewed-by: Xavier Deguillard
> >> Signed-off-by: Nadav Amit
> >> ---
> >> drivers/misc/vmw_balloon.c | 7 ++-
> >> 1 file changed, 2 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> >> index 400a1ccefc8e..b982059ce7b7 100644
> >> --- a/drivers/misc/vmw_balloon.c
> >> +++ b/drivers/misc/vmw_balloon.c
> >> @@ -1,7 +1,8 @@
> >> +// SPDX-License-Identifier: GPL-2.0
> >> /*
> >> * VMware Balloon driver.
> >> *
> >> - * Copyright (C) 2000-2014, VMware, Inc. All Rights Reserved.
> >> + * Copyright (C) 2000-2018, VMware, Inc. All Rights Reserved.
> >> *
> >> * This program is free software; you can redistribute it and/or modify it
> >> * under the terms of the GNU General Public License as published by the
> >> @@ -13,10 +14,6 @@
> >> * NON INFRINGEMENT. See the GNU General Public License for more
> >> * details.
> >
> > You still have a lot of boiler-plate text in here that can be removed.
> > Please do so.
>
> I will remove the maintainers, since it is really unsuitable.
>
> But what else do you want me to remove? This is a standard GPL license. If I
> am required to remove the GPL license, I will have to run checks to ensure
> it is appropriate.
Yes, all of the license text should be removed. Right now we have 700+
differnt wordings of "This file is released under the GPL" in the kernel
tree, and we need to clean that up. Look at all of the other SPDX
cleanups we have done already to get an idea of what is needed here.
As one example, look at 0c3b34a569f8 ("USB: typec: Remove remaining
redundant license text") which can be done after the correct SPDX line
is in the file. That's the end-goal for all kernel files.
thanks,
greg k-h
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
at 10:24 PM, Greg Kroah-Hartman wrote: > On Wed, Jun 13, 2018 at 06:54:11AM -0700, Nadav Amit wrote: >> Removing the paragraph about writing to the Free Software Foundation's >> mailing address from the sample GPL notice according to checkpatch >> request. >> >> In addition, updating the year and adding a license tag. >> >> Reviewed-by: Xavier Deguillard >> Signed-off-by: Nadav Amit >> --- >> drivers/misc/vmw_balloon.c | 7 ++- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c >> index 400a1ccefc8e..b982059ce7b7 100644 >> --- a/drivers/misc/vmw_balloon.c >> +++ b/drivers/misc/vmw_balloon.c >> @@ -1,7 +1,8 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> /* >> * VMware Balloon driver. >> * >> - * Copyright (C) 2000-2014, VMware, Inc. All Rights Reserved. >> + * Copyright (C) 2000-2018, VMware, Inc. All Rights Reserved. >> * >> * This program is free software; you can redistribute it and/or modify it >> * under the terms of the GNU General Public License as published by the >> @@ -13,10 +14,6 @@ >> * NON INFRINGEMENT. See the GNU General Public License for more >> * details. > > You still have a lot of boiler-plate text in here that can be removed. > Please do so. I will remove the maintainers, since it is really unsuitable. But what else do you want me to remove? This is a standard GPL license. If I am required to remove the GPL license, I will have to run checks to ensure it is appropriate. Thanks, Nadav
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
at 10:24 PM, Greg Kroah-Hartman wrote: > On Wed, Jun 13, 2018 at 06:54:11AM -0700, Nadav Amit wrote: >> Removing the paragraph about writing to the Free Software Foundation's >> mailing address from the sample GPL notice according to checkpatch >> request. >> >> In addition, updating the year and adding a license tag. >> >> Reviewed-by: Xavier Deguillard >> Signed-off-by: Nadav Amit >> --- >> drivers/misc/vmw_balloon.c | 7 ++- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c >> index 400a1ccefc8e..b982059ce7b7 100644 >> --- a/drivers/misc/vmw_balloon.c >> +++ b/drivers/misc/vmw_balloon.c >> @@ -1,7 +1,8 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> /* >> * VMware Balloon driver. >> * >> - * Copyright (C) 2000-2014, VMware, Inc. All Rights Reserved. >> + * Copyright (C) 2000-2018, VMware, Inc. All Rights Reserved. >> * >> * This program is free software; you can redistribute it and/or modify it >> * under the terms of the GNU General Public License as published by the >> @@ -13,10 +14,6 @@ >> * NON INFRINGEMENT. See the GNU General Public License for more >> * details. > > You still have a lot of boiler-plate text in here that can be removed. > Please do so. I will remove the maintainers, since it is really unsuitable. But what else do you want me to remove? This is a standard GPL license. If I am required to remove the GPL license, I will have to run checks to ensure it is appropriate. Thanks, Nadav
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
On Wed, Jun 13, 2018 at 06:54:11AM -0700, Nadav Amit wrote: > Removing the paragraph about writing to the Free Software Foundation's > mailing address from the sample GPL notice according to checkpatch > request. > > In addition, updating the year and adding a license tag. > > Reviewed-by: Xavier Deguillard > Signed-off-by: Nadav Amit > --- > drivers/misc/vmw_balloon.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c > index 400a1ccefc8e..b982059ce7b7 100644 > --- a/drivers/misc/vmw_balloon.c > +++ b/drivers/misc/vmw_balloon.c > @@ -1,7 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * VMware Balloon driver. > * > - * Copyright (C) 2000-2014, VMware, Inc. All Rights Reserved. > + * Copyright (C) 2000-2018, VMware, Inc. All Rights Reserved. > * > * This program is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License as published by the > @@ -13,10 +14,6 @@ > * NON INFRINGEMENT. See the GNU General Public License for more > * details. You still have a lot of boiler-plate text in here that can be removed. Please do so. thanks, greg k-h
Re: [PATCH v2 6/7] vmw_balloon: update copyright message
On Wed, Jun 13, 2018 at 06:54:11AM -0700, Nadav Amit wrote: > Removing the paragraph about writing to the Free Software Foundation's > mailing address from the sample GPL notice according to checkpatch > request. > > In addition, updating the year and adding a license tag. > > Reviewed-by: Xavier Deguillard > Signed-off-by: Nadav Amit > --- > drivers/misc/vmw_balloon.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c > index 400a1ccefc8e..b982059ce7b7 100644 > --- a/drivers/misc/vmw_balloon.c > +++ b/drivers/misc/vmw_balloon.c > @@ -1,7 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * VMware Balloon driver. > * > - * Copyright (C) 2000-2014, VMware, Inc. All Rights Reserved. > + * Copyright (C) 2000-2018, VMware, Inc. All Rights Reserved. > * > * This program is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License as published by the > @@ -13,10 +14,6 @@ > * NON INFRINGEMENT. See the GNU General Public License for more > * details. You still have a lot of boiler-plate text in here that can be removed. Please do so. thanks, greg k-h
