Re: [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant

[Matthias Brugger]

On 19/05/17 08:53, Corentin Labbe wrote:

This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
define.

Signed-off-by: Corentin Labbe 
---


Reviewed-by: Matthias Brugger 


  drivers/crypto/mediatek/mtk-sha.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/mediatek/mtk-sha.c 
b/drivers/crypto/mediatek/mtk-sha.c
index 2226f12d1c7a..5f4f845adbb8 100644
--- a/drivers/crypto/mediatek/mtk-sha.c
+++ b/drivers/crypto/mediatek/mtk-sha.c
@@ -12,6 +12,7 @@
   * Some ideas are from atmel-sha.c and omap-sham.c drivers.
   */
  
+#include 

  #include 
  #include "mtk-platform.h"
  
@@ -825,8 +826,8 @@ static int mtk_sha_setkey(struct crypto_ahash *tfm, const u8 *key,

memcpy(bctx->opad, bctx->ipad, bs);
  
  	for (i = 0; i < bs; i++) {

-   bctx->ipad[i] ^= 0x36;
-   bctx->opad[i] ^= 0x5c;
+   bctx->ipad[i] ^= HMAC_IPAD_VALUE;
+   bctx->opad[i] ^= HMAC_OPAD_VALUE;
}
  
  	return 0;

Re: [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant

[Matthias Brugger]

On 19/05/17 08:53, Corentin Labbe wrote:

This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
define.

Signed-off-by: Corentin Labbe 
---


Reviewed-by: Matthias Brugger 


  drivers/crypto/mediatek/mtk-sha.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/mediatek/mtk-sha.c 
b/drivers/crypto/mediatek/mtk-sha.c
index 2226f12d1c7a..5f4f845adbb8 100644
--- a/drivers/crypto/mediatek/mtk-sha.c
+++ b/drivers/crypto/mediatek/mtk-sha.c
@@ -12,6 +12,7 @@
   * Some ideas are from atmel-sha.c and omap-sham.c drivers.
   */
  
+#include 

  #include 
  #include "mtk-platform.h"
  
@@ -825,8 +826,8 @@ static int mtk_sha_setkey(struct crypto_ahash *tfm, const u8 *key,

memcpy(bctx->opad, bctx->ipad, bs);
  
  	for (i = 0; i < bs; i++) {

-   bctx->ipad[i] ^= 0x36;
-   bctx->opad[i] ^= 0x5c;
+   bctx->ipad[i] ^= HMAC_IPAD_VALUE;
+   bctx->opad[i] ^= HMAC_OPAD_VALUE;
}
  
  	return 0;