Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-27 Thread houlong wei
On Thu, 2018-09-27 at 15:50 +0800, Matthias Brugger wrote: > > On 27/09/2018 03:57, houlong wei wrote: [...] > >>> + > >>> +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code > >>> code, > >>> +u32 arg_a, u32 arg_b) > >>> +{ > >>> + u64 *cmd_ptr;

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-27 Thread houlong wei
On Thu, 2018-09-27 at 15:50 +0800, Matthias Brugger wrote: > > On 27/09/2018 03:57, houlong wei wrote: [...] > >>> + > >>> +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code > >>> code, > >>> +u32 arg_a, u32 arg_b) > >>> +{ > >>> + u64 *cmd_ptr;

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-27 Thread Matthias Brugger
On 15/08/2018 03:46, houlong wei wrote: [...] >> + >> +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code >> code, >> + u32 arg_a, u32 arg_b) >> +{ >> +u64 *cmd_ptr; >> + >> +if (unlikely(pkt->cmd_buf_size + CMDQ_INST_SIZE >

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-27 Thread Matthias Brugger
On 15/08/2018 03:46, houlong wei wrote: [...] >> + >> +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code >> code, >> + u32 arg_a, u32 arg_b) >> +{ >> +u64 *cmd_ptr; >> + >> +if (unlikely(pkt->cmd_buf_size + CMDQ_INST_SIZE >

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-27 Thread Matthias Brugger
On 27/09/2018 03:57, houlong wei wrote: [...] >>> + } >>> + >>> + return client; >>> +} >>> +EXPORT_SYMBOL(cmdq_mbox_create); >>> + >>> +void cmdq_mbox_destroy(struct cmdq_client *client) >>> +{ >>> + if (client->timeout_ms != CMDQ_NO_TIMEOUT) { >>> + spin_lock(>lock); >>> +

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-27 Thread Matthias Brugger
On 27/09/2018 03:57, houlong wei wrote: [...] >>> + } >>> + >>> + return client; >>> +} >>> +EXPORT_SYMBOL(cmdq_mbox_create); >>> + >>> +void cmdq_mbox_destroy(struct cmdq_client *client) >>> +{ >>> + if (client->timeout_ms != CMDQ_NO_TIMEOUT) { >>> + spin_lock(>lock); >>> +

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-26 Thread houlong wei
On Wed, 2018-09-26 at 23:53 +0800, Matthias Brugger wrote: > > On 25/07/2018 03:26, Houlong Wei wrote: > > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > --- > > drivers/soc/mediatek/Kconfig

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-26 Thread houlong wei
On Wed, 2018-09-26 at 23:53 +0800, Matthias Brugger wrote: > > On 25/07/2018 03:26, Houlong Wei wrote: > > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > --- > > drivers/soc/mediatek/Kconfig

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-26 Thread Matthias Brugger
On 25/07/2018 03:26, Houlong Wei wrote: > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > drivers/soc/mediatek/Kconfig | 12 ++ > drivers/soc/mediatek/Makefile |1 + >

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-26 Thread Matthias Brugger
On 25/07/2018 03:26, Houlong Wei wrote: > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > drivers/soc/mediatek/Kconfig | 12 ++ > drivers/soc/mediatek/Makefile |1 + >

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-09 Thread houlong wei
On Wed, 2018-08-15 at 09:46 +0800, houlong wei wrote: > On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > >[...] Hello Matthias, Sorry to disturb you. Could you please review this patch and give your comment?

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-09 Thread houlong wei
On Wed, 2018-08-15 at 09:46 +0800, houlong wei wrote: > On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > >[...] Hello Matthias, Sorry to disturb you. Could you please review this patch and give your comment?

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-08-14 Thread houlong wei
On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > drivers/soc/mediatek/Kconfig | 12 ++ > drivers/soc/mediatek/Makefile |1 + >

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-08-14 Thread houlong wei
On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > drivers/soc/mediatek/Kconfig | 12 ++ > drivers/soc/mediatek/Makefile |1 + >