Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Benjamin Herrenschmidt
On Mon, 2019-08-05 at 13:07 -0700, Sagi Grimberg wrote: > > > > > > Ping ? I had another look today and I don't feel like mucking around > > > > > > with all the AQ size logic, AEN magic tag etc... just for that sake > > > > > > of > > > > > > that Apple gunk. I'm happy to have it give up IO

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Benjamin Herrenschmidt
On Mon, 2019-08-05 at 11:27 -0700, Sagi Grimberg wrote: > > > Ping ? I had another look today and I don't feel like mucking > > > around > > > with all the AQ size logic, AEN magic tag etc... just for that > > > sake of > > > that Apple gunk. I'm happy to have it give up IO tags, it doesn't > > >

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Benjamin Herrenschmidt
On Mon, 2019-08-05 at 07:49 -0600, Keith Busch wrote: > > Ping ? I had another look today and I don't feel like mucking around > > with all the AQ size logic, AEN magic tag etc... just for that sake of > > that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem > > to make much of a

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Sagi Grimberg
Ping ? I had another look today and I don't feel like mucking around with all the AQ size logic, AEN magic tag etc... just for that sake of that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem to make much of a difference in practice anyway. But if you feel strongly about

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Sagi Grimberg
Ping ? I had another look today and I don't feel like mucking around with all the AQ size logic, AEN magic tag etc... just for that sake of that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem to make much of a difference in practice anyway. But if you feel strongly about

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Jens Axboe
On 8/5/19 11:27 AM, Sagi Grimberg wrote: > >>> Ping ? I had another look today and I don't feel like mucking around >>> with all the AQ size logic, AEN magic tag etc... just for that sake of >>> that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem >>> to make much of a

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Keith Busch
On Mon, Aug 05, 2019 at 11:27:54AM -0700, Sagi Grimberg wrote: > > > > Ping ? I had another look today and I don't feel like mucking around > > > with all the AQ size logic, AEN magic tag etc... just for that sake of > > > that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem > >

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Sagi Grimberg
Ping ? I had another look today and I don't feel like mucking around with all the AQ size logic, AEN magic tag etc... just for that sake of that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem to make much of a difference in practice anyway. But if you feel strongly about

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Keith Busch
On Mon, Aug 05, 2019 at 04:49:23PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2019-07-30 at 13:28 -0700, Benjamin Herrenschmidt wrote: > > > One problem is that we've an nvme parameter, io_queue_depth, that a user > > > could set to something less than 32, and then you won't be able to do > >

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-08-05 Thread Benjamin Herrenschmidt
On Tue, 2019-07-30 at 13:28 -0700, Benjamin Herrenschmidt wrote: > > One problem is that we've an nvme parameter, io_queue_depth, that a user > > could set to something less than 32, and then you won't be able to do > > any IO. I'd recommend enforce the admin queue to QD1 for this device so > >

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-30 Thread Benjamin Herrenschmidt
On Tue, 2019-07-30 at 09:30 -0600, Keith Busch wrote: > On Fri, Jul 19, 2019 at 03:31:02PM +1000, Benjamin Herrenschmidt wrote: > > From 8dcba2ef5b1466b023b88b4eca463b30de78d9eb Mon Sep 17 00:00:00 2001 > > From: Benjamin Herrenschmidt > > Date: Fri, 19 Jul 2019 15:03:06 +1000 > > Subject: > >

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-30 Thread Benjamin Herrenschmidt
On Tue, 2019-07-30 at 09:30 -0600, Keith Busch wrote: > On Fri, Jul 19, 2019 at 03:31:02PM +1000, Benjamin Herrenschmidt wrote: > > From 8dcba2ef5b1466b023b88b4eca463b30de78d9eb Mon Sep 17 00:00:00 2001 > > From: Benjamin Herrenschmidt > > Date: Fri, 19 Jul 2019 15:03:06 +1000 > > Subject: > >

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-30 Thread Keith Busch
On Fri, Jul 19, 2019 at 03:31:02PM +1000, Benjamin Herrenschmidt wrote: > From 8dcba2ef5b1466b023b88b4eca463b30de78d9eb Mon Sep 17 00:00:00 2001 > From: Benjamin Herrenschmidt > Date: Fri, 19 Jul 2019 15:03:06 +1000 > Subject: > > Another issue with the Apple T2 based 2018 controllers seem to

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-22 Thread Ming Lei
On Fri, Jul 19, 2019 at 1:31 PM Benjamin Herrenschmidt wrote: > > From 8dcba2ef5b1466b023b88b4eca463b30de78d9eb Mon Sep 17 00:00:00 2001 > From: Benjamin Herrenschmidt > Date: Fri, 19 Jul 2019 15:03:06 +1000 > Subject: > > Another issue with the Apple T2 based 2018 controllers seem to be > that

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-22 Thread Benjamin Herrenschmidt
On Fri, 2019-07-19 at 23:51 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2019-07-19 at 14:28 +0200, Christoph Hellwig wrote: > > Yikes, that things looks worse and worse. I think at this point > > we'll > > have to defer the support to 5.4 unfortunately as it is getting more > > and more

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-19 Thread Benjamin Herrenschmidt
On Fri, 2019-07-19 at 14:28 +0200, Christoph Hellwig wrote: > Yikes, that things looks worse and worse. I think at this point > we'll > have to defer the support to 5.4 unfortunately as it is getting more > and more involved.. Well, at least v3 of that patch, thanks to Damien's idea, isn't

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-19 Thread Christoph Hellwig
Yikes, that things looks worse and worse. I think at this point we'll have to defer the support to 5.4 unfortunately as it is getting more and more involved..

Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-18 Thread Balbir Singh
On Fri, Jul 19, 2019 at 3:31 PM Benjamin Herrenschmidt wrote: > > From 8dcba2ef5b1466b023b88b4eca463b30de78d9eb Mon Sep 17 00:00:00 2001 > From: Benjamin Herrenschmidt > Date: Fri, 19 Jul 2019 15:03:06 +1000 > Subject: > > Another issue with the Apple T2 based 2018 controllers seem to be > that