Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Josh Poimboeuf
On Mon, Sep 19, 2016 at 02:02:18PM -0700, Linus Torvalds wrote: > On Mon, Sep 19, 2016 at 1:56 PM, Josh Poimboeuf wrote: > > On Mon, Sep 19, 2016 at 01:24:03PM -0700, Linus Torvalds wrote: > >> > >> because I certainly hope there is always a space there. > > > > No luck. The

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Josh Poimboeuf
On Mon, Sep 19, 2016 at 02:02:18PM -0700, Linus Torvalds wrote: > On Mon, Sep 19, 2016 at 1:56 PM, Josh Poimboeuf wrote: > > On Mon, Sep 19, 2016 at 01:24:03PM -0700, Linus Torvalds wrote: > >> > >> because I certainly hope there is always a space there. > > > > No luck. The Japanese translation

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Linus Torvalds
On Mon, Sep 19, 2016 at 1:56 PM, Josh Poimboeuf wrote: > On Mon, Sep 19, 2016 at 01:24:03PM -0700, Linus Torvalds wrote: >> >> because I certainly hope there is always a space there. > > No luck. The Japanese translation uses an empty string: Heh. Ok, we don't want to

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Linus Torvalds
On Mon, Sep 19, 2016 at 1:56 PM, Josh Poimboeuf wrote: > On Mon, Sep 19, 2016 at 01:24:03PM -0700, Linus Torvalds wrote: >> >> because I certainly hope there is always a space there. > > No luck. The Japanese translation uses an empty string: Heh. Ok, we don't want to *just* have the "./"

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Josh Poimboeuf
On Mon, Sep 19, 2016 at 01:24:03PM -0700, Linus Torvalds wrote: > On Mon, Sep 19, 2016 at 1:00 PM, Rabin Vincent wrote: > > > > Note that addr2line has localized strings, so the regex with the " at " > > won't match for everyone unless you invoke addr2line with LANG=C. > > Ok, I'll

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Josh Poimboeuf
On Mon, Sep 19, 2016 at 01:24:03PM -0700, Linus Torvalds wrote: > On Mon, Sep 19, 2016 at 1:00 PM, Rabin Vincent wrote: > > > > Note that addr2line has localized strings, so the regex with the " at " > > won't match for everyone unless you invoke addr2line with LANG=C. > > Ok, I'll make it match

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Linus Torvalds
On Mon, Sep 19, 2016 at 1:00 PM, Rabin Vincent wrote: > > Note that addr2line has localized strings, so the regex with the " at " > won't match for everyone unless you invoke addr2line with LANG=C. Ok, I'll make it match just on the space instead. > __write_once_size på

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Linus Torvalds
On Mon, Sep 19, 2016 at 1:00 PM, Rabin Vincent wrote: > > Note that addr2line has localized strings, so the regex with the " at " > won't match for everyone unless you invoke addr2line with LANG=C. Ok, I'll make it match just on the space instead. > __write_once_size på

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Rabin Vincent
On Mon, Sep 19, 2016 at 12:15:42PM -0700, Linus Torvalds wrote: > Hmm. Would you mind if I change the > > addr2line -fpie $objfile $hexaddr | sed "s;$dir_prefix;;" > > into > > addr2line -fpie $objfile $hexaddr | > sed "s; at $dir_prefix\(\./\)*; at ;" > >

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Rabin Vincent
On Mon, Sep 19, 2016 at 12:15:42PM -0700, Linus Torvalds wrote: > Hmm. Would you mind if I change the > > addr2line -fpie $objfile $hexaddr | sed "s;$dir_prefix;;" > > into > > addr2line -fpie $objfile $hexaddr | > sed "s; at $dir_prefix\(\./\)*; at ;" > >

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Josh Poimboeuf
On Mon, Sep 19, 2016 at 12:15:42PM -0700, Linus Torvalds wrote: > On Mon, Sep 19, 2016 at 11:56 AM, Linus Torvalds > wrote: > >> > >> The only working (and fast) approach I could come up with was an ugly > >> hack. It assumes that start_kernel() is in init/main.c.

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Josh Poimboeuf
On Mon, Sep 19, 2016 at 12:15:42PM -0700, Linus Torvalds wrote: > On Mon, Sep 19, 2016 at 11:56 AM, Linus Torvalds > wrote: > >> > >> The only working (and fast) approach I could come up with was an ugly > >> hack. It assumes that start_kernel() is in init/main.c. > > > > That sounds entirely

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Linus Torvalds
On Mon, Sep 19, 2016 at 11:56 AM, Linus Torvalds wrote: >> >> The only working (and fast) approach I could come up with was an ugly >> hack. It assumes that start_kernel() is in init/main.c. > > That sounds entirely reasonable. Maybe somebody can come up with a >

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Linus Torvalds
On Mon, Sep 19, 2016 at 11:56 AM, Linus Torvalds wrote: >> >> The only working (and fast) approach I could come up with was an ugly >> hack. It assumes that start_kernel() is in init/main.c. > > That sounds entirely reasonable. Maybe somebody can come up with a > better and more general

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Linus Torvalds
On Mon, Sep 19, 2016 at 8:52 AM, Josh Poimboeuf wrote: > > One caveat with #5 (relative path names). Looking at DW_AT_comp_dir > wouldn't work, because that's the *object* directory, not the source > directory. > > The only working (and fast) approach I could come up with

Re: [PATCH v3] scripts: add script for translating stack dump function

2016-09-19 Thread Linus Torvalds
On Mon, Sep 19, 2016 at 8:52 AM, Josh Poimboeuf wrote: > > One caveat with #5 (relative path names). Looking at DW_AT_comp_dir > wouldn't work, because that's the *object* directory, not the source > directory. > > The only working (and fast) approach I could come up with was an ugly > hack. It