Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Kees Cook
On Wed, Dec 5, 2018 at 7:08 PM Christian Brauner wrote: > As a sidenote I'm switching the name from procfd_send_signal() to > taskfd_send_signal(). It seems to me the best way to handle Eric's > request to reflect that we can eventually both signal tgids and tids. Cool; sounds fine to me. --

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Kees Cook
On Wed, Dec 5, 2018 at 7:08 PM Christian Brauner wrote: > As a sidenote I'm switching the name from procfd_send_signal() to > taskfd_send_signal(). It seems to me the best way to handle Eric's > request to reflect that we can eventually both signal tgids and tids. Cool; sounds fine to me. --

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Christian Brauner
On Wed, Dec 05, 2018 at 03:24:08PM -0800, Kees Cook wrote: > On Wed, Dec 5, 2018 at 12:53 PM Christian Brauner > wrote: > > On Wed, Dec 05, 2018 at 12:20:43PM -0600, Eric W. Biederman wrote: > > > Christian Brauner writes: > > > > [1]: https://lkml.org/lkml/2018/11/18/130 > > > > [2]: > > >

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Christian Brauner
On Wed, Dec 05, 2018 at 03:24:08PM -0800, Kees Cook wrote: > On Wed, Dec 5, 2018 at 12:53 PM Christian Brauner > wrote: > > On Wed, Dec 05, 2018 at 12:20:43PM -0600, Eric W. Biederman wrote: > > > Christian Brauner writes: > > > > [1]: https://lkml.org/lkml/2018/11/18/130 > > > > [2]: > > >

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Kees Cook
On Wed, Dec 5, 2018 at 12:53 PM Christian Brauner wrote: > On Wed, Dec 05, 2018 at 12:20:43PM -0600, Eric W. Biederman wrote: > > Christian Brauner writes: > > > [1]: https://lkml.org/lkml/2018/11/18/130 > > > [2]: > > > https://lore.kernel.org/lkml/874lbtjvtd@oldenburg2.str.redhat.com/ >

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Kees Cook
On Wed, Dec 5, 2018 at 12:53 PM Christian Brauner wrote: > On Wed, Dec 05, 2018 at 12:20:43PM -0600, Eric W. Biederman wrote: > > Christian Brauner writes: > > > [1]: https://lkml.org/lkml/2018/11/18/130 > > > [2]: > > > https://lore.kernel.org/lkml/874lbtjvtd@oldenburg2.str.redhat.com/ >

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Christian Brauner
On Wed, Dec 05, 2018 at 12:20:43PM -0600, Eric W. Biederman wrote: > Christian Brauner writes: > > > The kill() syscall operates on process identifiers (pid). After a process > > has exited its pid can be reused by another process. If a caller sends a > > signal to a reused pid it will end up

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Christian Brauner
On Wed, Dec 05, 2018 at 12:20:43PM -0600, Eric W. Biederman wrote: > Christian Brauner writes: > > > The kill() syscall operates on process identifiers (pid). After a process > > has exited its pid can be reused by another process. If a caller sends a > > signal to a reused pid it will end up

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Eric W. Biederman
Christian Brauner writes: > The kill() syscall operates on process identifiers (pid). After a process > has exited its pid can be reused by another process. If a caller sends a > signal to a reused pid it will end up signaling the wrong process. This > issue has often surfaced and there has been

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Eric W. Biederman
Christian Brauner writes: > The kill() syscall operates on process identifiers (pid). After a process > has exited its pid can be reused by another process. If a caller sends a > signal to a reused pid it will end up signaling the wrong process. This > issue has often surfaced and there has been

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Eric W. Biederman
Christian Brauner writes: > The kill() syscall operates on process identifiers (pid). After a process > has exited its pid can be reused by another process. If a caller sends a > signal to a reused pid it will end up signaling the wrong process. This > issue has often surfaced and there has been

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread Eric W. Biederman
Christian Brauner writes: > The kill() syscall operates on process identifiers (pid). After a process > has exited its pid can be reused by another process. If a caller sends a > signal to a reused pid it will end up signaling the wrong process. This > issue has often surfaced and there has been

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread kbuild test robot
Hi Christian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.20-rc5] [cannot apply to next-20181205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3] signal: add procfd_send_signal() syscall

2018-12-05 Thread kbuild test robot
Hi Christian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.20-rc5] [cannot apply to next-20181205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: