Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
On 5 March 2018 at 10:34, Masahiro Yamada wrote: > Hi Ulf, Wolfram, > > 2018-03-05 18:22 GMT+09:00 Wolfram Sang : >> >>> I have added Wolframs tags to the already applied patches and applied >>> that last two, 15 and 16. >> >> Thanks. Please note that patch 14 misses my Rev tag. (I gave it >> yesterday but the patch was accidently applied before. One round too >> early, so to say). Added rev. tag. >> >>> They are all present in my next branch. The fix that Wolfram sent on >>> top, is added immediately after the commit it fixes. >> >> Could we also squash it, then? >> > > If Wolfram is fine with squashing, > that would be cleaner. > Done. > In that case, can you add Tested-by > to patch 12? Done. Kind regards Uffe
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
> >> They are all present in my next branch. The fix that Wolfram sent on > >> top, is added immediately after the commit it fixes. > > > > Could we also squash it, then? > > > > If Wolfram is fine with squashing, > that would be cleaner. > > In that case, can you add Tested-by > to patch 12? Yup, sounds best to me. signature.asc Description: PGP signature
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
Hi Ulf, Wolfram, 2018-03-05 18:22 GMT+09:00 Wolfram Sang : > >> I have added Wolframs tags to the already applied patches and applied >> that last two, 15 and 16. > > Thanks. Please note that patch 14 misses my Rev tag. (I gave it > yesterday but the patch was accidently applied before. One round too > early, so to say). > >> They are all present in my next branch. The fix that Wolfram sent on >> top, is added immediately after the commit it fixes. > > Could we also squash it, then? > If Wolfram is fine with squashing, that would be cleaner. In that case, can you add Tested-by to patch 12? -- Best Regards Masahiro Yamada
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
> I have added Wolframs tags to the already applied patches and applied > that last two, 15 and 16. Thanks. Please note that patch 14 misses my Rev tag. (I gave it yesterday but the patch was accidently applied before. One round too early, so to say). > They are all present in my next branch. The fix that Wolfram sent on > top, is added immediately after the commit it fixes. Could we also squash it, then? signature.asc Description: PGP signature
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
On 4 March 2018 at 23:42, Wolfram Sang wrote: > On Thu, Jan 18, 2018 at 01:28:00AM +0900, Masahiro Yamada wrote: >> >> In the previous batch (https://lkml.org/lkml/2017/11/24/428) >> I sent 22 patches for TMIO MMC. >> >> 14 patches were applied, the rest is under discussion. >> >> This series consists of 16 patches. > > Which I tested now, so we can add > > Tested-by: Wolfram Sang > > to the patches except for > >> Patch 12: updated per Wolfram > > this one which needs a fix. I will send it as an incremental patch. > Yamada-san, Wolfram, I have added Wolframs tags to the already applied patches and applied that last two, 15 and 16. They are all present in my next branch. The fix that Wolfram sent on top, is added immediately after the commit it fixes. Kind regards Uffe
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
On Thu, Jan 18, 2018 at 01:28:00AM +0900, Masahiro Yamada wrote: > > In the previous batch (https://lkml.org/lkml/2017/11/24/428) > I sent 22 patches for TMIO MMC. > > 14 patches were applied, the rest is under discussion. > > This series consists of 16 patches. Which I tested now, so we can add Tested-by: Wolfram Sang to the patches except for > Patch 12: updated per Wolfram this one which needs a fix. I will send it as an incremental patch. signature.asc Description: PGP signature
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
On 14 February 2018 at 11:23, Wolfram Sang wrote: > >> You need to check again. :-) > > Seems like it. Sorry for the noise. > >> I am eager to apply those patches you already have reviewed (to >> patch14), as those mostly seemed rather trivial and should be nice >> cleanups. >> >> Do you mind me going ahead, then you can continue and review/test the rest? > > Yes, we can work incremently from there. I'll send patches if I discover > something unexpected. > Great! So, applied patches 7->14. Thanks and kind regards Uffe
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
> You need to check again. :-) Seems like it. Sorry for the noise. > I am eager to apply those patches you already have reviewed (to > patch14), as those mostly seemed rather trivial and should be nice > cleanups. > > Do you mind me going ahead, then you can continue and review/test the rest? Yes, we can work incremently from there. I'll send patches if I discover something unexpected. signature.asc Description: PGP signature
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
On 14 February 2018 at 10:43, Masahiro Yamada wrote: > Hi Ulf, > > > 2018-02-14 18:36 GMT+09:00 Ulf Hansson : >> On 7 February 2018 at 20:11, Wolfram Sang wrote: >>> I picked patch5 and patch6, as those seemed trivial. Unless there is a rc9, let's aim for 4.17 for the rest. >>> >>> I can't find the branch where you picked these patches? I wanted to use >>> it to apply the rest of the patches. They don't seem to fit on v4.15 >>> or current linus/master. Can you share this branch? >> >> You need to check again. :-) >> >> Patches up and to patch6 is already in Linus' tree v.16rc1, those I >> carried for quite a while on my next branch before sending them in the >> PR to Linus. >> >>> >>> I will do reviewing now "visually". But please wait until I tested them >>> before applying. >> >> I am eager to apply those patches you already have reviewed (to >> patch14), as those mostly seemed rather trivial and should be nice >> cleanups. >> >> Do you mind me going ahead, then you can continue and review/test the rest? >> > > > If you move forward, please fix-up the commit log of the patch 11. > (https://patchwork.kernel.org/patch/10170007/) > > > Documentation/devicetree/bindings/mmc/tmio_mmc.txt > > -> > > Documentation/devicetree/bindings/mmc/mmc.txt Thanks for the reminder. Yes I can amend the patch, no worries. Kind regards Uffe
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
Hi Ulf, 2018-02-14 18:36 GMT+09:00 Ulf Hansson : > On 7 February 2018 at 20:11, Wolfram Sang wrote: >> >>> I picked patch5 and patch6, as those seemed trivial. Unless there is a >>> rc9, let's aim for 4.17 for the rest. >> >> I can't find the branch where you picked these patches? I wanted to use >> it to apply the rest of the patches. They don't seem to fit on v4.15 >> or current linus/master. Can you share this branch? > > You need to check again. :-) > > Patches up and to patch6 is already in Linus' tree v.16rc1, those I > carried for quite a while on my next branch before sending them in the > PR to Linus. > >> >> I will do reviewing now "visually". But please wait until I tested them >> before applying. > > I am eager to apply those patches you already have reviewed (to > patch14), as those mostly seemed rather trivial and should be nice > cleanups. > > Do you mind me going ahead, then you can continue and review/test the rest? > If you move forward, please fix-up the commit log of the patch 11. (https://patchwork.kernel.org/patch/10170007/) Documentation/devicetree/bindings/mmc/tmio_mmc.txt -> Documentation/devicetree/bindings/mmc/mmc.txt Thanks. -- Best Regards Masahiro Yamada
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
On 7 February 2018 at 20:11, Wolfram Sang wrote: > >> I picked patch5 and patch6, as those seemed trivial. Unless there is a >> rc9, let's aim for 4.17 for the rest. > > I can't find the branch where you picked these patches? I wanted to use > it to apply the rest of the patches. They don't seem to fit on v4.15 > or current linus/master. Can you share this branch? You need to check again. :-) Patches up and to patch6 is already in Linus' tree v.16rc1, those I carried for quite a while on my next branch before sending them in the PR to Linus. > > I will do reviewing now "visually". But please wait until I tested them > before applying. I am eager to apply those patches you already have reviewed (to patch14), as those mostly seemed rather trivial and should be nice cleanups. Do you mind me going ahead, then you can continue and review/test the rest? Kind regards Uffe
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
> I picked patch5 and patch6, as those seemed trivial. Unless there is a > rc9, let's aim for 4.17 for the rest. I can't find the branch where you picked these patches? I wanted to use it to apply the rest of the patches. They don't seem to fit on v4.15 or current linus/master. Can you share this branch? I will do reviewing now "visually". But please wait until I tested them before applying. Thanks, Wolfram signature.asc Description: PGP signature
Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups
On 17 January 2018 at 17:28, Masahiro Yamada wrote: > > In the previous batch (https://lkml.org/lkml/2017/11/24/428) > I sent 22 patches for TMIO MMC. > > 14 patches were applied, the rest is under discussion. > > This series consists of 16 patches. > > Patch 1-4: repost from v2. > (Wolfram gave Reviewed by, so I moved them to the head) Applied for next. > > Patch 5-11: new patches (cleanups of WP flag) I picked patch5 and patch6, as those seemed trivial. Unless there is a rc9, let's aim for 4.17 for the rest. [...] Kind regards Uffe
