Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[Steven Rostedt]

On Tue, 6 Mar 2018 15:05:42 -0700
Lina Iyer  wrote:

> Duh. FTRACE seems to have been disabled. Will fix and update.

Don't feel bad. You're not alone, I've done that too ;-)

-- Steve

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[Steven Rostedt]

On Tue, 6 Mar 2018 15:05:42 -0700
Lina Iyer  wrote:

> Duh. FTRACE seems to have been disabled. Will fix and update.

Don't feel bad. You're not alone, I've done that too ;-)

-- Steve

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[Lina Iyer]

On Tue, Mar 06 2018 at 14:56 -0700, Lina Iyer wrote:

On Tue, Mar 06 2018 at 14:47 -0700, Steven Rostedt wrote:

On Tue, 6 Mar 2018 13:38:06 +0800
kbuild test robot  wrote:


drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of function 
'__assign_string'; did you mean '__assign_str'? 
[-Werror=implicit-function-declaration]


Yes, you meant __assign_str(). I may have said __assign_string() in my
comments, but I was doing it from memory, not actually compiling code.

Please make sure you test the code and make sure it builds before
posting. And displays the tracepoint as you expect it to.


I compiled and checked for sparse. Didn't explictly test for this. Not
sure why it did not fail for me.


Duh. FTRACE seems to have been disabled. Will fix and update.

Thanks,
Lina

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[Lina Iyer]

On Tue, Mar 06 2018 at 14:56 -0700, Lina Iyer wrote:

On Tue, Mar 06 2018 at 14:47 -0700, Steven Rostedt wrote:

On Tue, 6 Mar 2018 13:38:06 +0800
kbuild test robot  wrote:


drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of function 
'__assign_string'; did you mean '__assign_str'? 
[-Werror=implicit-function-declaration]


Yes, you meant __assign_str(). I may have said __assign_string() in my
comments, but I was doing it from memory, not actually compiling code.

Please make sure you test the code and make sure it builds before
posting. And displays the tracepoint as you expect it to.


I compiled and checked for sparse. Didn't explictly test for this. Not
sure why it did not fail for me.


Duh. FTRACE seems to have been disabled. Will fix and update.

Thanks,
Lina

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[Lina Iyer]

On Tue, Mar 06 2018 at 14:47 -0700, Steven Rostedt wrote:

On Tue, 6 Mar 2018 13:38:06 +0800
kbuild test robot  wrote:


>> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of 
function '__assign_string'; did you mean '__assign_str'? 
[-Werror=implicit-function-declaration]


Yes, you meant __assign_str(). I may have said __assign_string() in my
comments, but I was doing it from memory, not actually compiling code.

Please make sure you test the code and make sure it builds before
posting. And displays the tracepoint as you expect it to.


I compiled and checked for sparse. Didn't explictly test for this. Not
sure why it did not fail for me.

-- Lina

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[Lina Iyer]

On Tue, Mar 06 2018 at 14:47 -0700, Steven Rostedt wrote:

On Tue, 6 Mar 2018 13:38:06 +0800
kbuild test robot  wrote:


>> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of 
function '__assign_string'; did you mean '__assign_str'? 
[-Werror=implicit-function-declaration]


Yes, you meant __assign_str(). I may have said __assign_string() in my
comments, but I was doing it from memory, not actually compiling code.

Please make sure you test the code and make sure it builds before
posting. And displays the tracepoint as you expect it to.


I compiled and checked for sparse. Didn't explictly test for this. Not
sure why it did not fail for me.

-- Lina

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[Steven Rostedt]

On Tue, 6 Mar 2018 13:38:06 +0800
kbuild test robot  wrote:

> >> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of 
> >> function '__assign_string'; did you mean '__assign_str'? 
> >> [-Werror=implicit-function-declaration]  

Yes, you meant __assign_str(). I may have said __assign_string() in my
comments, but I was doing it from memory, not actually compiling code.

Please make sure you test the code and make sure it builds before
posting. And displays the tracepoint as you expect it to.

Thanks,

-- Steve


>   __assign_string(name, d->name);
>   ^
>include/trace/trace_events.h:719:4: note: in definition of macro 
> 'DECLARE_EVENT_CLASS'

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[Steven Rostedt]

On Tue, 6 Mar 2018 13:38:06 +0800
kbuild test robot  wrote:

> >> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of 
> >> function '__assign_string'; did you mean '__assign_str'? 
> >> [-Werror=implicit-function-declaration]  

Yes, you meant __assign_str(). I may have said __assign_string() in my
comments, but I was doing it from memory, not actually compiling code.

Please make sure you test the code and make sure it builds before
posting. And displays the tracepoint as you expect it to.

Thanks,

-- Steve


>   __assign_string(name, d->name);
>   ^
>include/trace/trace_events.h:719:4: note: in definition of macro 
> 'DECLARE_EVENT_CLASS'

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[kbuild test robot]

Hi Lina,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.16-rc4 next-20180306]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Lina-Iyer/drivers-qcom-add-RPMH-communication-support/20180305-225623
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64 

All error/warnings (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:96:0,
from drivers/soc/qcom/trace-rpmh.h:89,
from drivers/soc/qcom/rpmh-rsc.c:28:
   drivers/soc/qcom/./trace-rpmh.h: In function 
'trace_event_raw_event_rpmh_notify':
>> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of 
>> function '__assign_string'; did you mean '__assign_str'? 
>> [-Werror=implicit-function-declaration]
  __assign_string(name, d->name);
  ^
   include/trace/trace_events.h:719:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 
>> 'TP_fast_assign'
 TP_fast_assign(
 ^~
>> drivers/soc/qcom/./trace-rpmh.h:29:19: error: 'name' undeclared (first use 
>> in this function); did you mean 'node'?
  __assign_string(name, d->name);
  ^
   include/trace/trace_events.h:719:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 
>> 'TP_fast_assign'
 TP_fast_assign(
 ^~
   drivers/soc/qcom/./trace-rpmh.h:29:19: note: each undeclared identifier is 
reported only once for each function it appears in
  __assign_string(name, d->name);
  ^
   include/trace/trace_events.h:719:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 
>> 'TP_fast_assign'
 TP_fast_assign(
 ^~
   drivers/soc/qcom/./trace-rpmh.h: In function 
'trace_event_raw_event_rpmh_send_msg':
   drivers/soc/qcom/./trace-rpmh.h:67:19: error: 'name' undeclared (first use 
in this function); did you mean 'node'?
  __assign_string(name, d->name);
  ^
   include/trace/trace_events.h:719:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
   include/trace/trace_events.h:78:9: note: in expansion of macro 'PARAMS'
PARAMS(assign), \
^~
>> drivers/soc/qcom/./trace-rpmh.h:50:1: note: in expansion of macro 
>> 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~
   drivers/soc/qcom/./trace-rpmh.h:66:2: note: in expansion of macro 
'TP_fast_assign'
 TP_fast_assign(
 ^~
   In file included from include/trace/define_trace.h:97:0,
from drivers/soc/qcom/trace-rpmh.h:89,
from drivers/soc/qcom/rpmh-rsc.c:28:
   drivers/soc/qcom/./trace-rpmh.h: In function 'perf_trace_rpmh_notify':
>> drivers/soc/qcom/./trace-rpmh.h:29:19: error: 'name' undeclared (first use 
>> in this function); did you mean 'node'?
  __assign_string(name, d->name);
  ^
   include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 
>> 'TP_fast_assign'
 TP_fast_assign(
 ^~
   drivers/soc/qcom/./trace-rpmh.h: In function 'perf_trace_rpmh_send_msg':
   drivers/soc/qcom/./trace-rpmh.h:67:19: error: 'name' undeclared (first use 
in this function); did you mean 'node'?
  __assign_string(name, d->name);
  ^
   include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
   include/trace/trace_events.h:78:9: note: in expansion of macro 'PARAMS'
PARAMS(assign), \
^~
>> drivers/soc/qcom/./trace-rpmh.h:50:1: note: in expansion of macro 
>> 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~
   drivers/soc/qcom/./trace-rpmh.h:66:2: note: in expansion of macro 
'TP_fast_assign'
 TP_fast_assign(
 ^~
   cc1: some warnings being treated as errors

vim +29 drivers/soc/qcom/./trace-rpmh.h

16  
17  TP_PROTO(struct rsc_drv *d, struct tcs_response *r),
18  
19  TP_ARGS(d, r),
20  
21  TP_STRUCT__entry(
22   

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

[kbuild test robot]

Hi Lina,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.16-rc4 next-20180306]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Lina-Iyer/drivers-qcom-add-RPMH-communication-support/20180305-225623
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64 

All error/warnings (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:96:0,
from drivers/soc/qcom/trace-rpmh.h:89,
from drivers/soc/qcom/rpmh-rsc.c:28:
   drivers/soc/qcom/./trace-rpmh.h: In function 
'trace_event_raw_event_rpmh_notify':
>> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of 
>> function '__assign_string'; did you mean '__assign_str'? 
>> [-Werror=implicit-function-declaration]
  __assign_string(name, d->name);
  ^
   include/trace/trace_events.h:719:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 
>> 'TP_fast_assign'
 TP_fast_assign(
 ^~
>> drivers/soc/qcom/./trace-rpmh.h:29:19: error: 'name' undeclared (first use 
>> in this function); did you mean 'node'?
  __assign_string(name, d->name);
  ^
   include/trace/trace_events.h:719:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 
>> 'TP_fast_assign'
 TP_fast_assign(
 ^~
   drivers/soc/qcom/./trace-rpmh.h:29:19: note: each undeclared identifier is 
reported only once for each function it appears in
  __assign_string(name, d->name);
  ^
   include/trace/trace_events.h:719:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 
>> 'TP_fast_assign'
 TP_fast_assign(
 ^~
   drivers/soc/qcom/./trace-rpmh.h: In function 
'trace_event_raw_event_rpmh_send_msg':
   drivers/soc/qcom/./trace-rpmh.h:67:19: error: 'name' undeclared (first use 
in this function); did you mean 'node'?
  __assign_string(name, d->name);
  ^
   include/trace/trace_events.h:719:4: note: in definition of macro 
'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
   include/trace/trace_events.h:78:9: note: in expansion of macro 'PARAMS'
PARAMS(assign), \
^~
>> drivers/soc/qcom/./trace-rpmh.h:50:1: note: in expansion of macro 
>> 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~
   drivers/soc/qcom/./trace-rpmh.h:66:2: note: in expansion of macro 
'TP_fast_assign'
 TP_fast_assign(
 ^~
   In file included from include/trace/define_trace.h:97:0,
from drivers/soc/qcom/trace-rpmh.h:89,
from drivers/soc/qcom/rpmh-rsc.c:28:
   drivers/soc/qcom/./trace-rpmh.h: In function 'perf_trace_rpmh_notify':
>> drivers/soc/qcom/./trace-rpmh.h:29:19: error: 'name' undeclared (first use 
>> in this function); did you mean 'node'?
  __assign_string(name, d->name);
  ^
   include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
>> drivers/soc/qcom/./trace-rpmh.h:28:2: note: in expansion of macro 
>> 'TP_fast_assign'
 TP_fast_assign(
 ^~
   drivers/soc/qcom/./trace-rpmh.h: In function 'perf_trace_rpmh_send_msg':
   drivers/soc/qcom/./trace-rpmh.h:67:19: error: 'name' undeclared (first use 
in this function); did you mean 'node'?
  __assign_string(name, d->name);
  ^
   include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
 { assign; }   \
   ^~
   include/trace/trace_events.h:78:9: note: in expansion of macro 'PARAMS'
PARAMS(assign), \
^~
>> drivers/soc/qcom/./trace-rpmh.h:50:1: note: in expansion of macro 
>> 'TRACE_EVENT'
TRACE_EVENT(rpmh_send_msg,
^~~
   drivers/soc/qcom/./trace-rpmh.h:66:2: note: in expansion of macro 
'TP_fast_assign'
 TP_fast_assign(
 ^~
   cc1: some warnings being treated as errors

vim +29 drivers/soc/qcom/./trace-rpmh.h

16  
17  TP_PROTO(struct rsc_drv *d, struct tcs_response *r),
18  
19  TP_ARGS(d, r),
20  
21  TP_STRUCT__entry(
22