Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/21/2018 05:39 PM, Farhan Ali wrote: > > > On 02/21/2018 07:11 AM, Christian Borntraeger wrote: >> >> >> On 02/21/2018 01:07 PM, Cornelia Huck wrote: >> [...] > But if you need to enable PCI to get IOMEM, I wonder why this patch here > is needed at all? The Graphics menu / VT dummy console should be > available in the config if IOMEM is enabled anyway? That is a good question. With CONFIG_PCI=y I can select virtio-gpu and dummy-console. IIRC the issue was that with patch 3 we can have the situation where we have CONFIG_VT = y and CONFIG_DUMMY_CONSOLE=n and this will crash early during boot as conswitchp is NULL. > > Yes, VT layer initializes very early in the boot process and looks for a > console. If it can't find any it will crash. I believe that was the whole > point of having the dummy console. > >>> >>> So in practice, CONFIG_VT depends on "there's a console available, even >>> if it's only the dummy one"? >> >> Yes. Maybe we should simple move dummy_console outside of >> drivers/video/console/Kconfig >> into something that is always available. >> > > I agree, but where should it go? consoles are kinda tightly tied to > video/Graphics Support. > >>> This patches goal was to always enable dummy console even without PCI, but it obviously fails to do so. >>> > This patch should enable the dummy console even without PCI but we won't have > DRM/Virtio GPU. All right. This patch then makes sure that VT does not crash since it guarantees that DUMMY_CONSOLE is available. If the user want to have virtio-gpu it needs to enable PCI due to the dependencies, but this is a different issue that we can fix later. So the patch is fine as long as you take care of these things - add missing HAS_IOMEM dependency to VGA_CONSOLE - extend "if HAS_IOMEM" in drivers/video/Kconfig to cover config items previously covered by this dependency (it should start before config HAVE_FB_ATMEL and end after config HDMI) as requested by Bartlomiej
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/21/2018 07:11 AM, Christian Borntraeger wrote: On 02/21/2018 01:07 PM, Cornelia Huck wrote: [...] But if you need to enable PCI to get IOMEM, I wonder why this patch here is needed at all? The Graphics menu / VT dummy console should be available in the config if IOMEM is enabled anyway? That is a good question. With CONFIG_PCI=y I can select virtio-gpu and dummy-console. IIRC the issue was that with patch 3 we can have the situation where we have CONFIG_VT = y and CONFIG_DUMMY_CONSOLE=n and this will crash early during boot as conswitchp is NULL. Yes, VT layer initializes very early in the boot process and looks for a console. If it can't find any it will crash. I believe that was the whole point of having the dummy console. So in practice, CONFIG_VT depends on "there's a console available, even if it's only the dummy one"? Yes. Maybe we should simple move dummy_console outside of drivers/video/console/Kconfig into something that is always available. I agree, but where should it go? consoles are kinda tightly tied to video/Graphics Support. This patches goal was to always enable dummy console even without PCI, but it obviously fails to do so. This patch should enable the dummy console even without PCI but we won't have DRM/Virtio GPU. OTOH, the dummy console really should not depend on anything, as it is only doing dummy things. So what about allowing CONFIG_VT on s390 only if we have PCI? diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig index 84810075a6a0..1c7fe09d6f90 100644 --- a/drivers/tty/Kconfig +++ b/drivers/tty/Kconfig @@ -11,7 +11,7 @@ if TTY config VT bool "Virtual terminal" if EXPERT - depends on !UML + depends on !UML && (!S390 || PCI) select INPUT default y ---help--- Would cover your use case, but feels wrong to me... config dependencies aren't fun :/
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/21/2018 01:07 PM, Cornelia Huck wrote: [...] >>> But if you need to enable PCI to get IOMEM, I wonder why this patch here >>> is needed at all? The Graphics menu / VT dummy console should be >>> available in the config if IOMEM is enabled anyway? >> >> That is a good question. With CONFIG_PCI=y I can select virtio-gpu and >> dummy-console. >> IIRC the issue was that with patch 3 we can have the situation where we have >> CONFIG_VT = y and CONFIG_DUMMY_CONSOLE=n and this will crash early during >> boot as >> conswitchp is NULL. > > So in practice, CONFIG_VT depends on "there's a console available, even > if it's only the dummy one"? Yes. Maybe we should simple move dummy_console outside of drivers/video/console/Kconfig into something that is always available. > >> This patches goal was to always enable dummy console even without >> PCI, but it obviously fails to do so. > > OTOH, the dummy console really should not depend on anything, as it is > only doing dummy things. > >> >> So what about allowing CONFIG_VT on s390 only if we have PCI? >> >> >> diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig >> index 84810075a6a0..1c7fe09d6f90 100644 >> --- a/drivers/tty/Kconfig >> +++ b/drivers/tty/Kconfig >> @@ -11,7 +11,7 @@ if TTY >> >> config VT >> bool "Virtual terminal" if EXPERT >> - depends on !UML >> + depends on !UML && (!S390 || PCI) >> select INPUT >> default y >> ---help--- >> > > Would cover your use case, but feels wrong to me... config dependencies > aren't fun :/ >
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On Wed, 21 Feb 2018 12:49:35 +0100 Christian Borntraeger wrote: > On 02/21/2018 12:29 PM, Thomas Huth wrote: > > On 21.02.2018 12:22, Christian Borntraeger wrote: > >> > >> > >> On 02/21/2018 12:14 PM, Thomas Huth wrote: > >>> On 21.02.2018 12:09, Christian Borntraeger wrote: > > > On 02/21/2018 11:32 AM, Cornelia Huck wrote: > > On Wed, 21 Feb 2018 11:22:38 +0100 > > Christian Borntraeger wrote: > > > >> On 02/21/2018 11:05 AM, Christian Borntraeger wrote: > >>> > >>> > >>> On 02/19/2018 05:38 PM, Farhan Ali wrote: > > > On 02/19/2018 11:25 AM, Thomas Huth wrote: > > On 19.02.2018 16:47, Farhan Ali wrote: > >> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on > >> HAS_IOMEM.")' > >> added the HAS_IOMEM dependecy for "Graphics support". This > >> disabled the > >> "Graphics support" menu for S390. But if we enable VT layer for > >> S390, > >> we would also need to enable the dummy console. So let's remove the > >> HAS_IOMEM dependency. > >> > >> Move this dependency to sub menu items and console drivers that use > >> io memory. > >> > >> Signed-off-by: Farhan Ali > >> --- > >> drivers/video/Kconfig | 21 +++-- > >> drivers/video/console/Kconfig | 4 ++-- > >> 2 files changed, 13 insertions(+), 12 deletions(-) > >> > >> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > >> index 3c20af9..8f10915 100644 > >> --- a/drivers/video/Kconfig > >> +++ b/drivers/video/Kconfig > >> @@ -3,7 +3,6 @@ > >> # > >> menu "Graphics support" > >> - depends on HAS_IOMEM > >> config HAVE_FB_ATMEL > >> bool > >> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL > >> config SH_LCD_MIPI_DSI > >> bool > >> -source "drivers/char/agp/Kconfig" > >> +if HAS_IOMEM > >> + source "drivers/char/agp/Kconfig" > >> -source "drivers/gpu/vga/Kconfig" > >> + source "drivers/gpu/vga/Kconfig" > >> -source "drivers/gpu/host1x/Kconfig" > >> -source "drivers/gpu/ipu-v3/Kconfig" > >> + source "drivers/gpu/host1x/Kconfig" > >> + source "drivers/gpu/ipu-v3/Kconfig" > >> -source "drivers/gpu/drm/Kconfig" > >> + source "drivers/gpu/drm/Kconfig" > >>> > >>> > >>> Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - > >>> need still more > >>> work. > >>> > >> Sorry my fault. I had CONFIG_PCI disabled. > > > > That smells like the s390 HAS_IOMEM stuff needs more work -- I guess > > that you want to enable a ccw virtio-gpu device, not a pci one, right? > > It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you > cannot > select VIRTIO_GPU, which needs DRM, which need IOMEM. > >>> > >>> So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside > >>> outside of the "if HAS_IOMEM" path? Or does it not compile anymore that > >>> way? > >> > >> virtio-gpu depends on drm. So in essence it boils down to if you want > >> virtio-gpu > >> you also need to enable PCI, even if the actual channel is ccw. > > > > But if you need to enable PCI to get IOMEM, I wonder why this patch here > > is needed at all? The Graphics menu / VT dummy console should be > > available in the config if IOMEM is enabled anyway? > > That is a good question. With CONFIG_PCI=y I can select virtio-gpu and > dummy-console. > IIRC the issue was that with patch 3 we can have the situation where we have > CONFIG_VT = y and CONFIG_DUMMY_CONSOLE=n and this will crash early during > boot as > conswitchp is NULL. So in practice, CONFIG_VT depends on "there's a console available, even if it's only the dummy one"? > This patches goal was to always enable dummy console even without > PCI, but it obviously fails to do so. OTOH, the dummy console really should not depend on anything, as it is only doing dummy things. > > So what about allowing CONFIG_VT on s390 only if we have PCI? > > > diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig > index 84810075a6a0..1c7fe09d6f90 100644 > --- a/drivers/tty/Kconfig > +++ b/drivers/tty/Kconfig > @@ -11,7 +11,7 @@ if TTY > > config VT > bool "Virtual terminal" if EXPERT > - depends on !UML > + depends on !UML && (!S390 || PCI) > select INPUT > default y > ---help--- > Would cover your use case, but feels wrong to me... config dependencies aren't fun :/
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On Wednesday, February 21, 2018 09:44:43 AM Christian Borntraeger wrote: > > On 02/19/2018 04:47 PM, Farhan Ali wrote: > > The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on > > HAS_IOMEM.")' > > added the HAS_IOMEM dependecy for "Graphics support". This disabled the > > "Graphics support" menu for S390. But if we enable VT layer for S390, > > we would also need to enable the dummy console. So let's remove the > > HAS_IOMEM dependency. > > > > Move this dependency to sub menu items and console drivers that use > > io memory. > > > > Signed-off-by: Farhan Ali > > This patch is part of todays linux-next and so far no fallout was reported. > Shall I take that patch via the s390kvm tree (then I would like to have > an ack. Bart?) or is anybody on cc willing to take this? I would like to see two things changed before acking this patch: - add missing HAS_IOMEM dependency to VGA_CONSOLE - extend "if HAS_IOMEM" in drivers/video/Kconfig to cover config items previously covered by this dependency (it should start before config HAVE_FB_ATMEL and end after config HDMI) > Christian > > > > > --- > > drivers/video/Kconfig | 21 +++-- > > drivers/video/console/Kconfig | 4 ++-- > > 2 files changed, 13 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > > index 3c20af9..8f10915 100644 > > --- a/drivers/video/Kconfig > > +++ b/drivers/video/Kconfig > > @@ -3,7 +3,6 @@ > > # > > > > menu "Graphics support" > > - depends on HAS_IOMEM > > > > config HAVE_FB_ATMEL > > bool > > @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL > > config SH_LCD_MIPI_DSI > > bool > > > > -source "drivers/char/agp/Kconfig" > > +if HAS_IOMEM > > + source "drivers/char/agp/Kconfig" > > > > -source "drivers/gpu/vga/Kconfig" > > + source "drivers/gpu/vga/Kconfig" > > > > -source "drivers/gpu/host1x/Kconfig" > > -source "drivers/gpu/ipu-v3/Kconfig" > > + source "drivers/gpu/host1x/Kconfig" > > + source "drivers/gpu/ipu-v3/Kconfig" > > > > -source "drivers/gpu/drm/Kconfig" > > + source "drivers/gpu/drm/Kconfig" > > > > -menu "Frame buffer Devices" > > -source "drivers/video/fbdev/Kconfig" > > -endmenu > > + menu "Frame buffer Devices" > > + source "drivers/video/fbdev/Kconfig" > > + endmenu > > > > -source "drivers/video/backlight/Kconfig" > > +source "drivers/video/backlight/Kconfig" > > +endif > > > > config VGASTATE > > tristate > > diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig > > index 7f1f1fb..0023b16 100644 > > --- a/drivers/video/console/Kconfig > > +++ b/drivers/video/console/Kconfig > > @@ -85,7 +85,7 @@ config MDA_CONSOLE > > > > config SGI_NEWPORT_CONSOLE > > tristate "SGI Newport Console support" > > -depends on SGI_IP22 > > +depends on SGI_IP22 && HAS_IOMEM > > select FONT_SUPPORT > > help > >Say Y here if you want the console on the Newport aka XL graphics > > @@ -153,7 +153,7 @@ config FRAMEBUFFER_CONSOLE_ROTATION > > > > config STI_CONSOLE > > bool "STI text console" > > -depends on PARISC > > +depends on PARISC && HAS_IOMEM > > select FONT_SUPPORT > > default y > > help Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/21/2018 12:29 PM, Thomas Huth wrote: > On 21.02.2018 12:22, Christian Borntraeger wrote: >> >> >> On 02/21/2018 12:14 PM, Thomas Huth wrote: >>> On 21.02.2018 12:09, Christian Borntraeger wrote: On 02/21/2018 11:32 AM, Cornelia Huck wrote: > On Wed, 21 Feb 2018 11:22:38 +0100 > Christian Borntraeger wrote: > >> On 02/21/2018 11:05 AM, Christian Borntraeger wrote: >>> >>> >>> On 02/19/2018 05:38 PM, Farhan Ali wrote: On 02/19/2018 11:25 AM, Thomas Huth wrote: > On 19.02.2018 16:47, Farhan Ali wrote: >> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on >> HAS_IOMEM.")' >> added the HAS_IOMEM dependecy for "Graphics support". This disabled >> the >> "Graphics support" menu for S390. But if we enable VT layer for S390, >> we would also need to enable the dummy console. So let's remove the >> HAS_IOMEM dependency. >> >> Move this dependency to sub menu items and console drivers that use >> io memory. >> >> Signed-off-by: Farhan Ali >> --- >> drivers/video/Kconfig | 21 +++-- >> drivers/video/console/Kconfig | 4 ++-- >> 2 files changed, 13 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >> index 3c20af9..8f10915 100644 >> --- a/drivers/video/Kconfig >> +++ b/drivers/video/Kconfig >> @@ -3,7 +3,6 @@ >> # >> menu "Graphics support" >> - depends on HAS_IOMEM >> config HAVE_FB_ATMEL >> bool >> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL >> config SH_LCD_MIPI_DSI >> bool >> -source "drivers/char/agp/Kconfig" >> +if HAS_IOMEM >> + source "drivers/char/agp/Kconfig" >> -source "drivers/gpu/vga/Kconfig" >> + source "drivers/gpu/vga/Kconfig" >> -source "drivers/gpu/host1x/Kconfig" >> -source "drivers/gpu/ipu-v3/Kconfig" >> + source "drivers/gpu/host1x/Kconfig" >> + source "drivers/gpu/ipu-v3/Kconfig" >> -source "drivers/gpu/drm/Kconfig" >> + source "drivers/gpu/drm/Kconfig" >>> >>> >>> Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - >>> need still more >>> work. >>> >> Sorry my fault. I had CONFIG_PCI disabled. > > That smells like the s390 HAS_IOMEM stuff needs more work -- I guess > that you want to enable a ccw virtio-gpu device, not a pci one, right? It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you cannot select VIRTIO_GPU, which needs DRM, which need IOMEM. >>> >>> So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside >>> outside of the "if HAS_IOMEM" path? Or does it not compile anymore that way? >> >> virtio-gpu depends on drm. So in essence it boils down to if you want >> virtio-gpu >> you also need to enable PCI, even if the actual channel is ccw. > > But if you need to enable PCI to get IOMEM, I wonder why this patch here > is needed at all? The Graphics menu / VT dummy console should be > available in the config if IOMEM is enabled anyway? That is a good question. With CONFIG_PCI=y I can select virtio-gpu and dummy-console. IIRC the issue was that with patch 3 we can have the situation where we have CONFIG_VT = y and CONFIG_DUMMY_CONSOLE=n and this will crash early during boot as conswitchp is NULL. This patches goal was to always enable dummy console even without PCI, but it obviously fails to do so. So what about allowing CONFIG_VT on s390 only if we have PCI? diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig index 84810075a6a0..1c7fe09d6f90 100644 --- a/drivers/tty/Kconfig +++ b/drivers/tty/Kconfig @@ -11,7 +11,7 @@ if TTY config VT bool "Virtual terminal" if EXPERT - depends on !UML + depends on !UML && (!S390 || PCI) select INPUT default y ---help---
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 21.02.2018 12:22, Christian Borntraeger wrote: > > > On 02/21/2018 12:14 PM, Thomas Huth wrote: >> On 21.02.2018 12:09, Christian Borntraeger wrote: >>> >>> >>> On 02/21/2018 11:32 AM, Cornelia Huck wrote: On Wed, 21 Feb 2018 11:22:38 +0100 Christian Borntraeger wrote: > On 02/21/2018 11:05 AM, Christian Borntraeger wrote: >> >> >> On 02/19/2018 05:38 PM, Farhan Ali wrote: >>> >>> >>> On 02/19/2018 11:25 AM, Thomas Huth wrote: On 19.02.2018 16:47, Farhan Ali wrote: > The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on > HAS_IOMEM.")' > added the HAS_IOMEM dependecy for "Graphics support". This disabled > the > "Graphics support" menu for S390. But if we enable VT layer for S390, > we would also need to enable the dummy console. So let's remove the > HAS_IOMEM dependency. > > Move this dependency to sub menu items and console drivers that use > io memory. > > Signed-off-by: Farhan Ali > --- > drivers/video/Kconfig | 21 +++-- > drivers/video/console/Kconfig | 4 ++-- > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 3c20af9..8f10915 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -3,7 +3,6 @@ > # > menu "Graphics support" > - depends on HAS_IOMEM > config HAVE_FB_ATMEL > bool > @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL > config SH_LCD_MIPI_DSI > bool > -source "drivers/char/agp/Kconfig" > +if HAS_IOMEM > + source "drivers/char/agp/Kconfig" > -source "drivers/gpu/vga/Kconfig" > + source "drivers/gpu/vga/Kconfig" > -source "drivers/gpu/host1x/Kconfig" > -source "drivers/gpu/ipu-v3/Kconfig" > + source "drivers/gpu/host1x/Kconfig" > + source "drivers/gpu/ipu-v3/Kconfig" > -source "drivers/gpu/drm/Kconfig" > + source "drivers/gpu/drm/Kconfig" >> >> >> Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - >> need still more >> work. >> > Sorry my fault. I had CONFIG_PCI disabled. That smells like the s390 HAS_IOMEM stuff needs more work -- I guess that you want to enable a ccw virtio-gpu device, not a pci one, right? >>> >>> It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you >>> cannot >>> select VIRTIO_GPU, which needs DRM, which need IOMEM. >> >> So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside >> outside of the "if HAS_IOMEM" path? Or does it not compile anymore that way? > > virtio-gpu depends on drm. So in essence it boils down to if you want > virtio-gpu > you also need to enable PCI, even if the actual channel is ccw. But if you need to enable PCI to get IOMEM, I wonder why this patch here is needed at all? The Graphics menu / VT dummy console should be available in the config if IOMEM is enabled anyway? Thomas
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On Wed, 21 Feb 2018 12:14:36 +0100 Thomas Huth wrote: > On 21.02.2018 12:09, Christian Borntraeger wrote: > > > > > > On 02/21/2018 11:32 AM, Cornelia Huck wrote: > >> On Wed, 21 Feb 2018 11:22:38 +0100 > >> Christian Borntraeger wrote: > >> > >>> On 02/21/2018 11:05 AM, Christian Borntraeger wrote: > > > On 02/19/2018 05:38 PM, Farhan Ali wrote: > > > > > > On 02/19/2018 11:25 AM, Thomas Huth wrote: > >> On 19.02.2018 16:47, Farhan Ali wrote: > >>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on > >>> HAS_IOMEM.")' > >>> added the HAS_IOMEM dependecy for "Graphics support". This disabled > >>> the > >>> "Graphics support" menu for S390. But if we enable VT layer for S390, > >>> we would also need to enable the dummy console. So let's remove the > >>> HAS_IOMEM dependency. > >>> > >>> Move this dependency to sub menu items and console drivers that use > >>> io memory. > >>> > >>> Signed-off-by: Farhan Ali > >>> --- > >>> drivers/video/Kconfig | 21 +++-- > >>> drivers/video/console/Kconfig | 4 ++-- > >>> 2 files changed, 13 insertions(+), 12 deletions(-) > >>> > >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > >>> index 3c20af9..8f10915 100644 > >>> --- a/drivers/video/Kconfig > >>> +++ b/drivers/video/Kconfig > >>> @@ -3,7 +3,6 @@ > >>> # > >>> menu "Graphics support" > >>> - depends on HAS_IOMEM > >>> config HAVE_FB_ATMEL > >>> bool > >>> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL > >>> config SH_LCD_MIPI_DSI > >>> bool > >>> -source "drivers/char/agp/Kconfig" > >>> +if HAS_IOMEM > >>> + source "drivers/char/agp/Kconfig" > >>> -source "drivers/gpu/vga/Kconfig" > >>> + source "drivers/gpu/vga/Kconfig" > >>> -source "drivers/gpu/host1x/Kconfig" > >>> -source "drivers/gpu/ipu-v3/Kconfig" > >>> + source "drivers/gpu/host1x/Kconfig" > >>> + source "drivers/gpu/ipu-v3/Kconfig" > >>> -source "drivers/gpu/drm/Kconfig" > >>> + source "drivers/gpu/drm/Kconfig" > > > Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - > need still more > work. > > >>> Sorry my fault. I had CONFIG_PCI disabled. > >> > >> That smells like the s390 HAS_IOMEM stuff needs more work -- I guess > >> that you want to enable a ccw virtio-gpu device, not a pci one, right? > > > > It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you > > cannot > > select VIRTIO_GPU, which needs DRM, which need IOMEM. > > So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside > outside of the "if HAS_IOMEM" path? Or does it not compile anymore that way? Alternatively, some of the IOMEM stuff could be moved out from under the pci dependency on s390 (not sure what is needed and what actually makes sense.) This is good enough for now, but it would be nice to get this sorted out later.
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/21/2018 12:14 PM, Thomas Huth wrote: > On 21.02.2018 12:09, Christian Borntraeger wrote: >> >> >> On 02/21/2018 11:32 AM, Cornelia Huck wrote: >>> On Wed, 21 Feb 2018 11:22:38 +0100 >>> Christian Borntraeger wrote: >>> On 02/21/2018 11:05 AM, Christian Borntraeger wrote: > > > On 02/19/2018 05:38 PM, Farhan Ali wrote: >> >> >> On 02/19/2018 11:25 AM, Thomas Huth wrote: >>> On 19.02.2018 16:47, Farhan Ali wrote: The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' added the HAS_IOMEM dependecy for "Graphics support". This disabled the "Graphics support" menu for S390. But if we enable VT layer for S390, we would also need to enable the dummy console. So let's remove the HAS_IOMEM dependency. Move this dependency to sub menu items and console drivers that use io memory. Signed-off-by: Farhan Ali --- drivers/video/Kconfig | 21 +++-- drivers/video/console/Kconfig | 4 ++-- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 3c20af9..8f10915 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -3,7 +3,6 @@ # menu "Graphics support" - depends on HAS_IOMEM config HAVE_FB_ATMEL bool @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL config SH_LCD_MIPI_DSI bool -source "drivers/char/agp/Kconfig" +if HAS_IOMEM + source "drivers/char/agp/Kconfig" -source "drivers/gpu/vga/Kconfig" + source "drivers/gpu/vga/Kconfig" -source "drivers/gpu/host1x/Kconfig" -source "drivers/gpu/ipu-v3/Kconfig" + source "drivers/gpu/host1x/Kconfig" + source "drivers/gpu/ipu-v3/Kconfig" -source "drivers/gpu/drm/Kconfig" + source "drivers/gpu/drm/Kconfig" > > > Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - > need still more > work. > Sorry my fault. I had CONFIG_PCI disabled. >>> >>> That smells like the s390 HAS_IOMEM stuff needs more work -- I guess >>> that you want to enable a ccw virtio-gpu device, not a pci one, right? >> >> It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you >> cannot >> select VIRTIO_GPU, which needs DRM, which need IOMEM. > > So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside > outside of the "if HAS_IOMEM" path? Or does it not compile anymore that way? virtio-gpu depends on drm. So in essence it boils down to if you want virtio-gpu you also need to enable PCI, even if the actual channel is ccw.
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 21.02.2018 12:09, Christian Borntraeger wrote: > > > On 02/21/2018 11:32 AM, Cornelia Huck wrote: >> On Wed, 21 Feb 2018 11:22:38 +0100 >> Christian Borntraeger wrote: >> >>> On 02/21/2018 11:05 AM, Christian Borntraeger wrote: On 02/19/2018 05:38 PM, Farhan Ali wrote: > > > On 02/19/2018 11:25 AM, Thomas Huth wrote: >> On 19.02.2018 16:47, Farhan Ali wrote: >>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on >>> HAS_IOMEM.")' >>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the >>> "Graphics support" menu for S390. But if we enable VT layer for S390, >>> we would also need to enable the dummy console. So let's remove the >>> HAS_IOMEM dependency. >>> >>> Move this dependency to sub menu items and console drivers that use >>> io memory. >>> >>> Signed-off-by: Farhan Ali >>> --- >>> drivers/video/Kconfig | 21 +++-- >>> drivers/video/console/Kconfig | 4 ++-- >>> 2 files changed, 13 insertions(+), 12 deletions(-) >>> >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>> index 3c20af9..8f10915 100644 >>> --- a/drivers/video/Kconfig >>> +++ b/drivers/video/Kconfig >>> @@ -3,7 +3,6 @@ >>> # >>> menu "Graphics support" >>> - depends on HAS_IOMEM >>> config HAVE_FB_ATMEL >>> bool >>> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL >>> config SH_LCD_MIPI_DSI >>> bool >>> -source "drivers/char/agp/Kconfig" >>> +if HAS_IOMEM >>> + source "drivers/char/agp/Kconfig" >>> -source "drivers/gpu/vga/Kconfig" >>> + source "drivers/gpu/vga/Kconfig" >>> -source "drivers/gpu/host1x/Kconfig" >>> -source "drivers/gpu/ipu-v3/Kconfig" >>> + source "drivers/gpu/host1x/Kconfig" >>> + source "drivers/gpu/ipu-v3/Kconfig" >>> -source "drivers/gpu/drm/Kconfig" >>> + source "drivers/gpu/drm/Kconfig" Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need still more work. >>> Sorry my fault. I had CONFIG_PCI disabled. >> >> That smells like the s390 HAS_IOMEM stuff needs more work -- I guess >> that you want to enable a ccw virtio-gpu device, not a pci one, right? > > It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you > cannot > select VIRTIO_GPU, which needs DRM, which need IOMEM. So the 'source "drivers/gpu/drm/Kconfig"' should maybe rather reside outside of the "if HAS_IOMEM" path? Or does it not compile anymore that way? Thomas
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/21/2018 11:32 AM, Cornelia Huck wrote: > On Wed, 21 Feb 2018 11:22:38 +0100 > Christian Borntraeger wrote: > >> On 02/21/2018 11:05 AM, Christian Borntraeger wrote: >>> >>> >>> On 02/19/2018 05:38 PM, Farhan Ali wrote: On 02/19/2018 11:25 AM, Thomas Huth wrote: > On 19.02.2018 16:47, Farhan Ali wrote: >> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on >> HAS_IOMEM.")' >> added the HAS_IOMEM dependecy for "Graphics support". This disabled the >> "Graphics support" menu for S390. But if we enable VT layer for S390, >> we would also need to enable the dummy console. So let's remove the >> HAS_IOMEM dependency. >> >> Move this dependency to sub menu items and console drivers that use >> io memory. >> >> Signed-off-by: Farhan Ali >> --- >> drivers/video/Kconfig | 21 +++-- >> drivers/video/console/Kconfig | 4 ++-- >> 2 files changed, 13 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >> index 3c20af9..8f10915 100644 >> --- a/drivers/video/Kconfig >> +++ b/drivers/video/Kconfig >> @@ -3,7 +3,6 @@ >> # >> menu "Graphics support" >> - depends on HAS_IOMEM >> config HAVE_FB_ATMEL >> bool >> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL >> config SH_LCD_MIPI_DSI >> bool >> -source "drivers/char/agp/Kconfig" >> +if HAS_IOMEM >> + source "drivers/char/agp/Kconfig" >> -source "drivers/gpu/vga/Kconfig" >> + source "drivers/gpu/vga/Kconfig" >> -source "drivers/gpu/host1x/Kconfig" >> -source "drivers/gpu/ipu-v3/Kconfig" >> + source "drivers/gpu/host1x/Kconfig" >> + source "drivers/gpu/ipu-v3/Kconfig" >> -source "drivers/gpu/drm/Kconfig" >> + source "drivers/gpu/drm/Kconfig" >>> >>> >>> Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need >>> still more >>> work. >>> >> Sorry my fault. I had CONFIG_PCI disabled. > > That smells like the s390 HAS_IOMEM stuff needs more work -- I guess > that you want to enable a ccw virtio-gpu device, not a pci one, right? It is a ccw virtio-gpu. But s390 has no IOMEM without CONFIG_PCI, so you cannot select VIRTIO_GPU, which needs DRM, which need IOMEM. In essence this patch is good enough to go forward and to build a sane .config (Usually any s390 distro kernel should enable CONFIG_PCI).
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On Wed, 21 Feb 2018 11:22:38 +0100 Christian Borntraeger wrote: > On 02/21/2018 11:05 AM, Christian Borntraeger wrote: > > > > > > On 02/19/2018 05:38 PM, Farhan Ali wrote: > >> > >> > >> On 02/19/2018 11:25 AM, Thomas Huth wrote: > >>> On 19.02.2018 16:47, Farhan Ali wrote: > The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on > HAS_IOMEM.")' > added the HAS_IOMEM dependecy for "Graphics support". This disabled the > "Graphics support" menu for S390. But if we enable VT layer for S390, > we would also need to enable the dummy console. So let's remove the > HAS_IOMEM dependency. > > Move this dependency to sub menu items and console drivers that use > io memory. > > Signed-off-by: Farhan Ali > --- > drivers/video/Kconfig | 21 +++-- > drivers/video/console/Kconfig | 4 ++-- > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 3c20af9..8f10915 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -3,7 +3,6 @@ > # > menu "Graphics support" > - depends on HAS_IOMEM > config HAVE_FB_ATMEL > bool > @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL > config SH_LCD_MIPI_DSI > bool > -source "drivers/char/agp/Kconfig" > +if HAS_IOMEM > + source "drivers/char/agp/Kconfig" > -source "drivers/gpu/vga/Kconfig" > + source "drivers/gpu/vga/Kconfig" > -source "drivers/gpu/host1x/Kconfig" > -source "drivers/gpu/ipu-v3/Kconfig" > + source "drivers/gpu/host1x/Kconfig" > + source "drivers/gpu/ipu-v3/Kconfig" > -source "drivers/gpu/drm/Kconfig" > + source "drivers/gpu/drm/Kconfig" > > > > > > Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need > > still more > > work. > > > Sorry my fault. I had CONFIG_PCI disabled. That smells like the s390 HAS_IOMEM stuff needs more work -- I guess that you want to enable a ccw virtio-gpu device, not a pci one, right?
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/21/2018 11:05 AM, Christian Borntraeger wrote: > > > On 02/19/2018 05:38 PM, Farhan Ali wrote: >> >> >> On 02/19/2018 11:25 AM, Thomas Huth wrote: >>> On 19.02.2018 16:47, Farhan Ali wrote: The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' added the HAS_IOMEM dependecy for "Graphics support". This disabled the "Graphics support" menu for S390. But if we enable VT layer for S390, we would also need to enable the dummy console. So let's remove the HAS_IOMEM dependency. Move this dependency to sub menu items and console drivers that use io memory. Signed-off-by: Farhan Ali --- drivers/video/Kconfig | 21 +++-- drivers/video/console/Kconfig | 4 ++-- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 3c20af9..8f10915 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -3,7 +3,6 @@ # menu "Graphics support" - depends on HAS_IOMEM config HAVE_FB_ATMEL bool @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL config SH_LCD_MIPI_DSI bool -source "drivers/char/agp/Kconfig" +if HAS_IOMEM + source "drivers/char/agp/Kconfig" -source "drivers/gpu/vga/Kconfig" + source "drivers/gpu/vga/Kconfig" -source "drivers/gpu/host1x/Kconfig" -source "drivers/gpu/ipu-v3/Kconfig" + source "drivers/gpu/host1x/Kconfig" + source "drivers/gpu/ipu-v3/Kconfig" -source "drivers/gpu/drm/Kconfig" + source "drivers/gpu/drm/Kconfig" > > > Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need > still more > work. > Sorry my fault. I had CONFIG_PCI disabled.
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/19/2018 05:38 PM, Farhan Ali wrote: > > > On 02/19/2018 11:25 AM, Thomas Huth wrote: >> On 19.02.2018 16:47, Farhan Ali wrote: >>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on >>> HAS_IOMEM.")' >>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the >>> "Graphics support" menu for S390. But if we enable VT layer for S390, >>> we would also need to enable the dummy console. So let's remove the >>> HAS_IOMEM dependency. >>> >>> Move this dependency to sub menu items and console drivers that use >>> io memory. >>> >>> Signed-off-by: Farhan Ali >>> --- >>> drivers/video/Kconfig | 21 +++-- >>> drivers/video/console/Kconfig | 4 ++-- >>> 2 files changed, 13 insertions(+), 12 deletions(-) >>> >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>> index 3c20af9..8f10915 100644 >>> --- a/drivers/video/Kconfig >>> +++ b/drivers/video/Kconfig >>> @@ -3,7 +3,6 @@ >>> # >>> menu "Graphics support" >>> - depends on HAS_IOMEM >>> config HAVE_FB_ATMEL >>> bool >>> @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL >>> config SH_LCD_MIPI_DSI >>> bool >>> -source "drivers/char/agp/Kconfig" >>> +if HAS_IOMEM >>> + source "drivers/char/agp/Kconfig" >>> -source "drivers/gpu/vga/Kconfig" >>> + source "drivers/gpu/vga/Kconfig" >>> -source "drivers/gpu/host1x/Kconfig" >>> -source "drivers/gpu/ipu-v3/Kconfig" >>> + source "drivers/gpu/host1x/Kconfig" >>> + source "drivers/gpu/ipu-v3/Kconfig" >>> -source "drivers/gpu/drm/Kconfig" >>> + source "drivers/gpu/drm/Kconfig" Hmmm, looks like that this makes it impossible to select VIRTIO_GPU - need still more work.
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/19/2018 04:47 PM, Farhan Ali wrote: > The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' > added the HAS_IOMEM dependecy for "Graphics support". This disabled the > "Graphics support" menu for S390. But if we enable VT layer for S390, > we would also need to enable the dummy console. So let's remove the > HAS_IOMEM dependency. > > Move this dependency to sub menu items and console drivers that use > io memory. > > Signed-off-by: Farhan Ali This patch is part of todays linux-next and so far no fallout was reported. Shall I take that patch via the s390kvm tree (then I would like to have an ack. Bart?) or is anybody on cc willing to take this? Christian > --- > drivers/video/Kconfig | 21 +++-- > drivers/video/console/Kconfig | 4 ++-- > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 3c20af9..8f10915 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -3,7 +3,6 @@ > # > > menu "Graphics support" > - depends on HAS_IOMEM > > config HAVE_FB_ATMEL > bool > @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL > config SH_LCD_MIPI_DSI > bool > > -source "drivers/char/agp/Kconfig" > +if HAS_IOMEM > + source "drivers/char/agp/Kconfig" > > -source "drivers/gpu/vga/Kconfig" > + source "drivers/gpu/vga/Kconfig" > > -source "drivers/gpu/host1x/Kconfig" > -source "drivers/gpu/ipu-v3/Kconfig" > + source "drivers/gpu/host1x/Kconfig" > + source "drivers/gpu/ipu-v3/Kconfig" > > -source "drivers/gpu/drm/Kconfig" > + source "drivers/gpu/drm/Kconfig" > > -menu "Frame buffer Devices" > -source "drivers/video/fbdev/Kconfig" > -endmenu > + menu "Frame buffer Devices" > + source "drivers/video/fbdev/Kconfig" > + endmenu > > -source "drivers/video/backlight/Kconfig" > +source "drivers/video/backlight/Kconfig" > +endif > > config VGASTATE > tristate > diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig > index 7f1f1fb..0023b16 100644 > --- a/drivers/video/console/Kconfig > +++ b/drivers/video/console/Kconfig > @@ -85,7 +85,7 @@ config MDA_CONSOLE > > config SGI_NEWPORT_CONSOLE > tristate "SGI Newport Console support" > -depends on SGI_IP22 > +depends on SGI_IP22 && HAS_IOMEM > select FONT_SUPPORT > help >Say Y here if you want the console on the Newport aka XL graphics > @@ -153,7 +153,7 @@ config FRAMEBUFFER_CONSOLE_ROTATION > > config STI_CONSOLE > bool "STI text console" > -depends on PARISC > +depends on PARISC && HAS_IOMEM > select FONT_SUPPORT > default y > help >
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 02/19/2018 11:25 AM, Thomas Huth wrote: On 19.02.2018 16:47, Farhan Ali wrote: The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' added the HAS_IOMEM dependecy for "Graphics support". This disabled the "Graphics support" menu for S390. But if we enable VT layer for S390, we would also need to enable the dummy console. So let's remove the HAS_IOMEM dependency. Move this dependency to sub menu items and console drivers that use io memory. Signed-off-by: Farhan Ali --- drivers/video/Kconfig | 21 +++-- drivers/video/console/Kconfig | 4 ++-- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 3c20af9..8f10915 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -3,7 +3,6 @@ # menu "Graphics support" - depends on HAS_IOMEM config HAVE_FB_ATMEL bool @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL config SH_LCD_MIPI_DSI bool -source "drivers/char/agp/Kconfig" +if HAS_IOMEM + source "drivers/char/agp/Kconfig" -source "drivers/gpu/vga/Kconfig" + source "drivers/gpu/vga/Kconfig" -source "drivers/gpu/host1x/Kconfig" -source "drivers/gpu/ipu-v3/Kconfig" + source "drivers/gpu/host1x/Kconfig" + source "drivers/gpu/ipu-v3/Kconfig" -source "drivers/gpu/drm/Kconfig" + source "drivers/gpu/drm/Kconfig" -menu "Frame buffer Devices" -source "drivers/video/fbdev/Kconfig" -endmenu + menu "Frame buffer Devices" + source "drivers/video/fbdev/Kconfig" + endmenu -source "drivers/video/backlight/Kconfig" +source "drivers/video/backlight/Kconfig" +endif config VGASTATE tristate diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig index 7f1f1fb..0023b16 100644 --- a/drivers/video/console/Kconfig +++ b/drivers/video/console/Kconfig @@ -85,7 +85,7 @@ config MDA_CONSOLE config SGI_NEWPORT_CONSOLE tristate "SGI Newport Console support" -depends on SGI_IP22 +depends on SGI_IP22 && HAS_IOMEM select FONT_SUPPORT help Say Y here if you want the console on the Newport aka XL graphics @@ -153,7 +153,7 @@ config FRAMEBUFFER_CONSOLE_ROTATION config STI_CONSOLE bool "STI text console" -depends on PARISC +depends on PARISC && HAS_IOMEM select FONT_SUPPORT default y help Maybe config VGA_CONSOLE should depend on HAS_IOMEM, too? I think you can hardly use a VGA card without IOMEM, can you? True, you can't. And I did think of adding the dependency for VGA, but VGA already is fenced off by many (almost all) architectures and I wasn't sure if it would be necessary. But I can add it. Anyway, this approach now looks reasonable to me, so either way, feel free to add my: Reviewed-by: Thomas Huth Thank you so much for reviewing. Appreciate your feedback :)
Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
On 19.02.2018 16:47, Farhan Ali wrote: > The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' > added the HAS_IOMEM dependecy for "Graphics support". This disabled the > "Graphics support" menu for S390. But if we enable VT layer for S390, > we would also need to enable the dummy console. So let's remove the > HAS_IOMEM dependency. > > Move this dependency to sub menu items and console drivers that use > io memory. > > Signed-off-by: Farhan Ali > --- > drivers/video/Kconfig | 21 +++-- > drivers/video/console/Kconfig | 4 ++-- > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 3c20af9..8f10915 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -3,7 +3,6 @@ > # > > menu "Graphics support" > - depends on HAS_IOMEM > > config HAVE_FB_ATMEL > bool > @@ -11,20 +10,22 @@ config HAVE_FB_ATMEL > config SH_LCD_MIPI_DSI > bool > > -source "drivers/char/agp/Kconfig" > +if HAS_IOMEM > + source "drivers/char/agp/Kconfig" > > -source "drivers/gpu/vga/Kconfig" > + source "drivers/gpu/vga/Kconfig" > > -source "drivers/gpu/host1x/Kconfig" > -source "drivers/gpu/ipu-v3/Kconfig" > + source "drivers/gpu/host1x/Kconfig" > + source "drivers/gpu/ipu-v3/Kconfig" > > -source "drivers/gpu/drm/Kconfig" > + source "drivers/gpu/drm/Kconfig" > > -menu "Frame buffer Devices" > -source "drivers/video/fbdev/Kconfig" > -endmenu > + menu "Frame buffer Devices" > + source "drivers/video/fbdev/Kconfig" > + endmenu > > -source "drivers/video/backlight/Kconfig" > +source "drivers/video/backlight/Kconfig" > +endif > > config VGASTATE > tristate > diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig > index 7f1f1fb..0023b16 100644 > --- a/drivers/video/console/Kconfig > +++ b/drivers/video/console/Kconfig > @@ -85,7 +85,7 @@ config MDA_CONSOLE > > config SGI_NEWPORT_CONSOLE > tristate "SGI Newport Console support" > -depends on SGI_IP22 > +depends on SGI_IP22 && HAS_IOMEM > select FONT_SUPPORT > help >Say Y here if you want the console on the Newport aka XL graphics > @@ -153,7 +153,7 @@ config FRAMEBUFFER_CONSOLE_ROTATION > > config STI_CONSOLE > bool "STI text console" > -depends on PARISC > +depends on PARISC && HAS_IOMEM > select FONT_SUPPORT > default y > help > Maybe config VGA_CONSOLE should depend on HAS_IOMEM, too? I think you can hardly use a VGA card without IOMEM, can you? Anyway, this approach now looks reasonable to me, so either way, feel free to add my: Reviewed-by: Thomas Huth